diff mbox series

[RFC,walnascar,3/3] genericarm64: add ttyPS1 for KV260

Message ID 20250422190053.3244331-3-ross.burton@arm.com
State Deferred
Delegated to: Steve Sakoman
Headers show
Series [RFC,walnascar,1/3] systemd: enable getty generator by default | expand

Commit Message

Ross Burton April 22, 2025, 7 p.m. UTC
The AMD KV260 has a serial console on ttyPS1, so until we can dynamically
detect the console under sysvinit we can add it to SERIAL_CONSOLES so
this platform has a working console when not running systemd.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-yocto-bsp/conf/machine/genericarm64.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mikko Rapeli April 23, 2025, 10:24 a.m. UTC | #1
Hi,

On Tue, Apr 22, 2025 at 08:00:53PM +0100, Ross Burton wrote:
> The AMD KV260 has a serial console on ttyPS1, so until we can dynamically
> detect the console under sysvinit we can add it to SERIAL_CONSOLES so
> this platform has a working console when not running systemd.

So full circle back to
https://lists.yoctoproject.org/g/poky/topic/109273447#msg13461 then :)

To me this change is fine but it's also ok to not apply this and focus
on "poky-altcfg" distro with systemd which is much better at
detecting HW support at runtime.

NB, should this have been sent to poky list?

Cheers,

-Mikko

> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta-yocto-bsp/conf/machine/genericarm64.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-yocto-bsp/conf/machine/genericarm64.conf b/meta-yocto-bsp/conf/machine/genericarm64.conf
> index f5000402e51..eb79475e9a9 100644
> --- a/meta-yocto-bsp/conf/machine/genericarm64.conf
> +++ b/meta-yocto-bsp/conf/machine/genericarm64.conf
> @@ -28,7 +28,7 @@ WKS_FILE ?= "genericarm64.wks.in"
>  EFI_PROVIDER ?= "${@bb.utils.contains("DISTRO_FEATURES", "systemd", "systemd-boot", "grub-efi", d)}"
>  
>  # Try to bring up a selection of physical or virtual serial consoles
> -SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0 115200;ttyS0 115200;ttyS1 115200;ttyS2"
> +SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0 115200;ttyS0 115200;ttyS1 115200;ttyS2 115200;ttyPS1"
>  
>  # Allow u-boot to be built for use with qemu-system-aarch64.
>  # This u-boot is _not_ suitable for use with real hardware, and the expectation
> -- 
> 2.43.0
>
Ross Burton April 23, 2025, 10:26 a.m. UTC | #2
On 23 Apr 2025, at 11:24, Mikko Rapeli <mikko.rapeli@linaro.org> wrote:
> 
> Hi,
> 
> On Tue, Apr 22, 2025 at 08:00:53PM +0100, Ross Burton wrote:
>> The AMD KV260 has a serial console on ttyPS1, so until we can dynamically
>> detect the console under sysvinit we can add it to SERIAL_CONSOLES so
>> this platform has a working console when not running systemd.
> 
> So full circle back to
> https://lists.yoctoproject.org/g/poky/topic/109273447#msg13461 then :)

Pretty much.  It’s horrible but…

> To me this change is fine but it's also ok to not apply this and focus
> on "poky-altcfg" distro with systemd which is much better at
> detecting HW support at runtime.

Agreed, but also sysv shouldn’t be inoperable out of the box where possible.

> NB, should this have been sent to poky list?

Yes…

Ross
diff mbox series

Patch

diff --git a/meta-yocto-bsp/conf/machine/genericarm64.conf b/meta-yocto-bsp/conf/machine/genericarm64.conf
index f5000402e51..eb79475e9a9 100644
--- a/meta-yocto-bsp/conf/machine/genericarm64.conf
+++ b/meta-yocto-bsp/conf/machine/genericarm64.conf
@@ -28,7 +28,7 @@  WKS_FILE ?= "genericarm64.wks.in"
 EFI_PROVIDER ?= "${@bb.utils.contains("DISTRO_FEATURES", "systemd", "systemd-boot", "grub-efi", d)}"
 
 # Try to bring up a selection of physical or virtual serial consoles
-SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0 115200;ttyS0 115200;ttyS1 115200;ttyS2"
+SERIAL_CONSOLES ?= "115200;ttyAMA0 115200;hvc0 115200;ttyS0 115200;ttyS1 115200;ttyS2 115200;ttyPS1"
 
 # Allow u-boot to be built for use with qemu-system-aarch64.
 # This u-boot is _not_ suitable for use with real hardware, and the expectation