| Message ID | 20250401140430.13837-6-niko.mauno@vaisala.com |
|---|---|
| State | Accepted, archived |
| Commit | cf5b48d03f290a6bde94ee7a5c1aaee4d1a7793c |
| Headers | show |
| Series | [v4,1/6] default-providers: Add VIRTUAL-RUNTIME_dbus variable | expand |
BlueZ depends on dbus at runtime. Shouldn’t the recipe therefore explicitly list it in RDEPENDS? It seems weird to me to have the dependency come from a RRECOMMENDS in different recipe.
On 1 Apr 2025, at 15:35, Guðni Már Gilbert via lists.openembedded.org <gudni.m.g=gmail.com@lists.openembedded.org> wrote: > > BlueZ depends on dbus at runtime. Shouldn’t the recipe therefore explicitly list it in RDEPENDS? It seems weird to me to have the dependency come from a RRECOMMENDS in different recipe. bluez already RDEPENDS on libdbus which depends on dbus. The point here was to remove explicit ‘dbus’ dependencies from recipes which transitively depend on dbus already as they use libdbus. Ross
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index d626872103..c1f52c5f1b 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -7,7 +7,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ file://src/main.c;beginline=1;endline=24;md5=0ad83ca0dc37ab08af448777c581e7ac" DEPENDS = "dbus glib-2.0" -RDEPENDS:${PN} += "dbus" PROVIDES += "bluez-hcidump" RPROVIDES:${PN} += "bluez-hcidump" diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc index 133e8616da..804c2db9a7 100644 --- a/meta/recipes-connectivity/connman/connman.inc +++ b/meta/recipes-connectivity/connman/connman.inc @@ -118,10 +118,6 @@ RPROVIDES:${PN} = "\ ${@bb.utils.contains('PACKAGECONFIG', '3g','connman-plugin-ofono', '', d)} \ " -RDEPENDS:${PN} = "\ - dbus \ - " - PACKAGES_DYNAMIC += "^${PN}-plugin-.*" def add_rdepends(bb, d, file, pkg, depmap, multilib_prefix, add_insane_skip): diff --git a/meta/recipes-connectivity/neard/neard_0.19.bb b/meta/recipes-connectivity/neard/neard_0.19.bb index b04187bcc5..9e0ac6aa69 100644 --- a/meta/recipes-connectivity/neard/neard_0.19.bb +++ b/meta/recipes-connectivity/neard/neard_0.19.bb @@ -37,8 +37,6 @@ do_install:append() { fi } -RDEPENDS:${PN} = "dbus" - # Bluez & Wifi are not mandatory except for handover WIRELESS_DAEMON ??= "wpa-supplicant" RRECOMMENDS:${PN} = "\ diff --git a/meta/recipes-connectivity/ofono/ofono_2.15.bb b/meta/recipes-connectivity/ofono/ofono_2.15.bb index 40eeb3a086..bb4133eeda 100644 --- a/meta/recipes-connectivity/ofono/ofono_2.15.bb +++ b/meta/recipes-connectivity/ofono/ofono_2.15.bb @@ -37,7 +37,6 @@ PACKAGES =+ "${PN}-tests" FILES:${PN} += "${systemd_unitdir}" FILES:${PN}-tests = "${libdir}/${BPN}/test" -RDEPENDS:${PN} += "dbus" RDEPENDS:${PN}-tests = "\ python3-core \ python3-dbus \
Since each of these recipes already have 'dbus' in their DEPENDS, explicit runtime dependency declaration to dbus is not stricly necessary, because dbus-lib has runtime recommendation for ${VIRTUAL-RUNTIME_dbus} which in turn induces pulling also the preferred runtime D-Bus package to rootfs. Suggested-by: Ross Burton <ross.burton@arm.com> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> --- meta/recipes-connectivity/bluez5/bluez5.inc | 1 - meta/recipes-connectivity/connman/connman.inc | 4 ---- meta/recipes-connectivity/neard/neard_0.19.bb | 2 -- meta/recipes-connectivity/ofono/ofono_2.15.bb | 1 - 4 files changed, 8 deletions(-)