| Message ID | 20250322005552.603108-1-joaohf@gmail.com |
|---|---|
| State | Accepted, archived |
| Commit | 86b408919d9506b6f1ba69c96f1bc6212e724bbc |
| Headers | show |
| Series | [v2] neard: use WIRELESS_DAEMON | expand |
WIRELESS_DAEMON variable is now set separately from three different recipes. Can you make rather make it a PREFERRED_PROVIDER setting? Alex On Sat, 22 Mar 2025 at 01:56, João Henrique Ferreira de Freitas via lists.openembedded.org <joaohf=gmail.com@lists.openembedded.org> wrote: > > Honor WIRELESS_DAEMON when wifi is enable for DISTRO_FEATURE. > > Signed-off-by: João Henrique Ferreira de Freitas <joaohf@gmail.com> > --- > meta/recipes-connectivity/neard/neard_0.19.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-connectivity/neard/neard_0.19.bb b/meta/recipes-connectivity/neard/neard_0.19.bb > index 94df1ac3d6..b04187bcc5 100644 > --- a/meta/recipes-connectivity/neard/neard_0.19.bb > +++ b/meta/recipes-connectivity/neard/neard_0.19.bb > @@ -40,9 +40,10 @@ do_install:append() { > RDEPENDS:${PN} = "dbus" > > # Bluez & Wifi are not mandatory except for handover > +WIRELESS_DAEMON ??= "wpa-supplicant" > RRECOMMENDS:${PN} = "\ > ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ > - ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ > + ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','${WIRELESS_DAEMON}', '', d)} \ > " > > INITSCRIPT_NAME = "neard" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#213490): https://lists.openembedded.org/g/openembedded-core/message/213490 > Mute This Topic: https://lists.openembedded.org/mt/111838820/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Mon, 2025-03-24 at 10:46 +0100, Alexander Kanavin via lists.openembedded.org wrote: > WIRELESS_DAEMON variable is now set separately from three different > recipes. Can you make rather make it a PREFERRED_PROVIDER setting? That is not right since PREFERRED_PROVIDER works on DEPENDS where as this is a runtime dependency. This is where we end up with the VIRTUAL-RUNTIME_* variables, which are the best way we have of handling this right now despite my dislike of them. Cheers, Richard
diff --git a/meta/recipes-connectivity/neard/neard_0.19.bb b/meta/recipes-connectivity/neard/neard_0.19.bb index 94df1ac3d6..b04187bcc5 100644 --- a/meta/recipes-connectivity/neard/neard_0.19.bb +++ b/meta/recipes-connectivity/neard/neard_0.19.bb @@ -40,9 +40,10 @@ do_install:append() { RDEPENDS:${PN} = "dbus" # Bluez & Wifi are not mandatory except for handover +WIRELESS_DAEMON ??= "wpa-supplicant" RRECOMMENDS:${PN} = "\ ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} \ - ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ + ${@bb.utils.contains('DISTRO_FEATURES', 'wifi','${WIRELESS_DAEMON}', '', d)} \ " INITSCRIPT_NAME = "neard"
Honor WIRELESS_DAEMON when wifi is enable for DISTRO_FEATURE. Signed-off-by: João Henrique Ferreira de Freitas <joaohf@gmail.com> --- meta/recipes-connectivity/neard/neard_0.19.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)