diff mbox series

libgpg-error: Move yat2m binary to -dev package

Message ID 20250321072046.5349-1-mario.schuknecht@iris-sensing.com
State New
Headers show
Series libgpg-error: Move yat2m binary to -dev package | expand

Commit Message

Mario Schuknecht March 21, 2025, 7:20 a.m. UTC
The yat2m tool is a utility that is not required to use the pure
library.

Signed-off-by: Mario Schuknecht <mario.schuknecht@iris-sensing.com>
---
 meta/recipes-support/libgpg-error/libgpg-error_1.51.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Alexander Kanavin March 21, 2025, 9:01 a.m. UTC | #1
On Fri, 21 Mar 2025 at 08:21, Mario Schuknecht via
lists.openembedded.org
<Mario.Schuknecht=iris-sensing.com@lists.openembedded.org> wrote:
> -FILES:${PN}-dev += "${bindir}/gpg-error"
> +FILES:${PN}-dev += " \
> +    ${bindir}/gpg-error \
> +    ${bindir}/yat2m \
> +"

This has been in the recipe since before 2005 (!), but isn't actually
the right thing to do. -dev packages shouldn't contain target
executables at all.

The right fix should be to inherit lib_package.

Alex
Mathieu Dubois-Briand March 21, 2025, 10:38 a.m. UTC | #2
On Fri Mar 21, 2025 at 8:20 AM CET, Mario Schuknecht via lists.openembedded.org wrote:
> The yat2m tool is a utility that is not required to use the pure
> library.
>
> Signed-off-by: Mario Schuknecht <mario.schuknecht@iris-sensing.com>
> ---

Hi Mario,

Thanks for your patch.

This is breaking the selftests, as can be seen on the autobuilder:

ERROR: core-image-full-cmdline-1.0-r0 do_rootfs: Unable to install packages. Command '/srv/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-568868/tmp/work/qemux86_64-poky-linux/core-image-full-cmdline/1.0/recipe-sysroot-native/usr/bin/apt-get  install --allow-downgrades --allow-remove-essential --allow-change-held-packages --allow-unauthenticated --no-remove  apt dpkg gnupg packagegroup-core-boot packagegroup-core-full-cmdline packagegroup-core-ssh-openssh psplash run-postinsts signing-keys-packagefeed ssh-pregen-hostkeys' returned 100:
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 gnupg : Depends: gnupg-gpg but it is not going to be installed
         Depends: libgpg-error (>= 1.51)
         Recommends: pinentry but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/1199

Can you have a look at this error please?
diff mbox series

Patch

diff --git a/meta/recipes-support/libgpg-error/libgpg-error_1.51.bb b/meta/recipes-support/libgpg-error/libgpg-error_1.51.bb
index 741969beb0..4ef65a6acd 100644
--- a/meta/recipes-support/libgpg-error/libgpg-error_1.51.bb
+++ b/meta/recipes-support/libgpg-error/libgpg-error_1.51.bb
@@ -47,7 +47,10 @@  do_install_ptest() {
     install ${B}/tests/Makefile ${D}${PTEST_PATH}
 }
 
-FILES:${PN}-dev += "${bindir}/gpg-error"
+FILES:${PN}-dev += " \
+    ${bindir}/gpg-error \
+    ${bindir}/yat2m \
+"
 FILES:${PN}-doc += "${datadir}/libgpg-error/errorref.txt"
 
 BBCLASSEXTEND = "native nativesdk"