diff mbox series

[v4,8/9] man-db: Add missing rdep for col utility

Message ID 20250319214213.2505249-8-raj.khem@gmail.com
State Accepted, archived
Commit bf5c8801b471fa13df9d55932375bfaedb623bd0
Headers show
Series [v4,1/9] readline: Fixed build with GCC-15 | expand

Commit Message

Khem Raj March 19, 2025, 9:42 p.m. UTC
man utility calls col utility internally when formatting is asked for
therefore it expects col to be in rootfs otherwise silently errors with
retcode 3 meaning 'file not found' in this case its due to col not being
found, other distros eg. gets this via bsdextrautils dependency

libssh2 ptest mansyntax.sh fails due to this error, which now works

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-extended/man-db/man-db_2.13.0.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Ross Burton March 20, 2025, 4:42 p.m. UTC | #1
On 19 Mar 2025, at 21:42, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote:
> -DEPENDS = "libpipeline gdbm groff-native base-passwd"
> +DEPENDS = "libpipeline gdbm groff-native base-passwd zlib"

Wrong commit ;)

> RDEPENDS:${PN} += "base-passwd"
> +RDEPENDS:${PN}:append:libc-glibc = " util-linux-col"
> PACKAGE_WRITE_DEPS += "base-passwd"
> 
> # | /usr/src/debug/man-db/2.8.0-r0/man-db-2.8.0/src/whatis.c:939: undefined reference to `_nl_msg_cat_cntr'
> @@ -23,6 +24,10 @@ USE_NLS:libc-musl = "no"
> inherit gettext pkgconfig autotools systemd
> 
> EXTRA_OECONF = "--with-pager=less --with-systemdsystemunitdir=${systemd_system_unitdir}"
> +
> +# util-linux col is deprecated and only builds for glibc
> +EXTRA_OECONF:append:libc-musl = " --with-col=''"
> +

Feels like this could be neater as a PACKAGECONFIG.

PACKAGECONFIG ??= “col”
# util-linux col is deprecated and only builds for glibc
PACKAGECONFIG:remove:libc-musl = “col"
PACKAGECONFIG[col] = “—with-col,—without-col,,util-linux-col”

Ross
diff mbox series

Patch

diff --git a/meta/recipes-extended/man-db/man-db_2.13.0.bb b/meta/recipes-extended/man-db/man-db_2.13.0.bb
index 2178239bb60..a6ac82e6628 100644
--- a/meta/recipes-extended/man-db/man-db_2.13.0.bb
+++ b/meta/recipes-extended/man-db/man-db_2.13.0.bb
@@ -13,8 +13,9 @@  SRC_URI = "${SAVANNAH_NONGNU_MIRROR}/man-db/man-db-${PV}.tar.xz \
           "
 SRC_URI[sha256sum] = "82f0739f4f61aab5eb937d234de3b014e777b5538a28cbd31433c45ae09aefb9"
 
-DEPENDS = "libpipeline gdbm groff-native base-passwd"
+DEPENDS = "libpipeline gdbm groff-native base-passwd zlib"
 RDEPENDS:${PN} += "base-passwd"
+RDEPENDS:${PN}:append:libc-glibc = " util-linux-col"
 PACKAGE_WRITE_DEPS += "base-passwd"
 
 # | /usr/src/debug/man-db/2.8.0-r0/man-db-2.8.0/src/whatis.c:939: undefined reference to `_nl_msg_cat_cntr'
@@ -23,6 +24,10 @@  USE_NLS:libc-musl = "no"
 inherit gettext pkgconfig autotools systemd
 
 EXTRA_OECONF = "--with-pager=less --with-systemdsystemunitdir=${systemd_system_unitdir}"
+
+# util-linux col is deprecated and only builds for glibc
+EXTRA_OECONF:append:libc-musl = " --with-col=''"
+
 EXTRA_AUTORECONF += "-I ${S}/gl/m4"
 
 PACKAGECONFIG[bzip2] = "--with-bzip2=bzip2,ac_cv_prog_have_bzip2='',bzip2"