diff mbox series

[13/24] man-db: Add missing rdep for col utility

Message ID 20250318043846.2422141-13-raj.khem@gmail.com
State Accepted, archived
Commit bf5c8801b471fa13df9d55932375bfaedb623bd0
Headers show
Series [01/24] webkitgtk: 2.46.6 -> 2.48.0 | expand

Commit Message

Khem Raj March 18, 2025, 4:38 a.m. UTC
man utility calls col utility internally when formatting is asked for
therefore it expects col to be in rootfs otherwise silently errors with
retcode 3 meaning 'file not found' in this case its due to col not being
found, other distros eg. gets this via bsdextrautils dependency

libssh2 ptest mansyntax.sh fails due to this error, which now works

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-extended/man-db/man-db_2.13.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mathieu Dubois-Briand March 18, 2025, 3:47 p.m. UTC | #1
On Tue Mar 18, 2025 at 5:38 AM CET, Khem Raj via lists.openembedded.org wrote:
> man utility calls col utility internally when formatting is asked for
> therefore it expects col to be in rootfs otherwise silently errors with
> retcode 3 meaning 'file not found' in this case its due to col not being
> found, other distros eg. gets this via bsdextrautils dependency
>
> libssh2 ptest mansyntax.sh fails due to this error, which now works
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---

Hi Khem,

This triggers a new QA issue:

ERROR: man-db-2.13.0-r0 do_package_qa: QA Issue: man-db rdepends on util-linux-col, but it isn't a build dependency? [build-deps]
ERROR: man-db-2.13.0-r0 do_package_qa: Fatal QA errors were found, failing task.

https://autobuilder.yoctoproject.org/valkyrie/#/builders/3/builds/1229
Khem Raj March 19, 2025, 8:19 a.m. UTC | #2
On Tue, Mar 18, 2025 at 8:47 AM Mathieu Dubois-Briand
<mathieu.dubois-briand@bootlin.com> wrote:
>
> On Tue Mar 18, 2025 at 5:38 AM CET, Khem Raj via lists.openembedded.org wrote:
> > man utility calls col utility internally when formatting is asked for
> > therefore it expects col to be in rootfs otherwise silently errors with
> > retcode 3 meaning 'file not found' in this case its due to col not being
> > found, other distros eg. gets this via bsdextrautils dependency
> >
> > libssh2 ptest mansyntax.sh fails due to this error, which now works
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
>
> Hi Khem,
>
> This triggers a new QA issue:
>
> ERROR: man-db-2.13.0-r0 do_package_qa: QA Issue: man-db rdepends on util-linux-col, but it isn't a build dependency? [build-deps]
> ERROR: man-db-2.13.0-r0 do_package_qa: Fatal QA errors were found, failing task.
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/3/builds/1229
>

Its because col utility is deprecated and moreover only built for
glibc based sysrems see

https://github.com/util-linux/util-linux/commit/8886d84e25a457702b45194d69a47313f76dc6bc

Therefore the rdep has to be glibc specific and the second problem is
that man-db pokes for native tools like col and configures target
to use it which works in native compile but could be problematic with
cross compile. I have fixed this in V3 of the patchset so please take
the full set


> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
diff mbox series

Patch

diff --git a/meta/recipes-extended/man-db/man-db_2.13.0.bb b/meta/recipes-extended/man-db/man-db_2.13.0.bb
index 2178239bb60..17bb2996531 100644
--- a/meta/recipes-extended/man-db/man-db_2.13.0.bb
+++ b/meta/recipes-extended/man-db/man-db_2.13.0.bb
@@ -14,7 +14,7 @@  SRC_URI = "${SAVANNAH_NONGNU_MIRROR}/man-db/man-db-${PV}.tar.xz \
 SRC_URI[sha256sum] = "82f0739f4f61aab5eb937d234de3b014e777b5538a28cbd31433c45ae09aefb9"
 
 DEPENDS = "libpipeline gdbm groff-native base-passwd"
-RDEPENDS:${PN} += "base-passwd"
+RDEPENDS:${PN} += "base-passwd util-linux-col"
 PACKAGE_WRITE_DEPS += "base-passwd"
 
 # | /usr/src/debug/man-db/2.8.0-r0/man-db-2.8.0/src/whatis.c:939: undefined reference to `_nl_msg_cat_cntr'