[1/2] libcap: recipe cleanup

Drop 0001-ensure-the-XATTR_NAME_CAPS-is-defined-when-it-is-use.patch,
fixed upstream in "libcap: Fix for older kernels"[1].

Drop 0002-tests-do-not-run-target-executables.patch, doesn't appear to
be needed anymore and most likely resolved by "Don't build the
tests/binaries until we want to run them"[2].

There's no need to set PACKAGECONFIG:class-native as we disable PAM in
the native DISTRO_FEATURES.

The recipe LICENSE needs to reflect the _source_ license, so it can't
be controlled by PACKAGECONFIG. Also update the license to reflect the
actual licensing.

No need to set COPTS, since "Canonicalize build system"[3] the exported
CFLAGS/CPPFLAGS/LDFLAGS are respected.

Merge multiple make arguments into EXTRA_OEMAKE to remove duplication.

SYSTEM_HEADERS is not used upstream, remove.

Remove redundant FILES:PN-dev, this is part of the default.

[1] f1c3ac995d02d4f17b9d15656ab6d58f4c87435a
[2] 99799844ad9272d43892881d1090369e6032aec2
[3] 2762c2c1a8c98d9012fcd40f20d133493a0b3219

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 ..._NAME_CAPS-is-defined-when-it-is-use.patch | 35 -------------------
 ...-tests-do-not-run-target-executables.patch | 29 ---------------
 meta/recipes-support/libcap/libcap_2.74.bb    | 27 ++++----------
 3 files changed, 7 insertions(+), 84 deletions(-)
 delete mode 100644 meta/recipes-support/libcap/files/0001-ensure-the-XATTR_NAME_CAPS-is-defined-when-it-is-use.patch
 delete mode 100644 meta/recipes-support/libcap/files/0002-tests-do-not-run-target-executables.patch

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/1-2-libcap-recipe-cleanup.patch

FAIL: test lic files chksum modified not mentioned: LIC_FILES_CHKSUM changed without "License-Update:" tag and description in commit message (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Hi Ross,

On 3/17/25 4:12 PM, Ross Burton via lists.openembedded.org wrote:
> Drop 0001-ensure-the-XATTR_NAME_CAPS-is-defined-when-it-is-use.patch,
> fixed upstream in "libcap: Fix for older kernels"[1].
> 
> Drop 0002-tests-do-not-run-target-executables.patch, doesn't appear to
> be needed anymore and most likely resolved by "Don't build the
> tests/binaries until we want to run them"[2].
> 

Could be its own patch.

> There's no need to set PACKAGECONFIG:class-native as we disable PAM in
> the native DISTRO_FEATURES.
> 

Could be its own patch.

> The recipe LICENSE needs to reflect the _source_ license, so it can't
> be controlled by PACKAGECONFIG. Also update the license to reflect the
> actual licensing.
> 

Could be its own patch.

Also, would probably be better to have a package license too, to 
properly report the license based on the presence of the pam module or 
not, e.g.

LICENSE:${PN} = "(BSD-3-Clause | 
GPL-2.0-only)${@bb.utils.contains('PACKAGECONFIG', 'pam', ' & 
(BSD-3-Clause | LGPL-2.0-or-later)', '', d)}"

or something like that? (Not tested)

> No need to set COPTS, since "Canonicalize build system"[3] the exported
> CFLAGS/CPPFLAGS/LDFLAGS are respected.
> 

Could be its own patch.

> Merge multiple make arguments into EXTRA_OEMAKE to remove duplication.
> 

Could be its own patch.

> SYSTEM_HEADERS is not used upstream, remove.
> 

Could be its own patch.

> Remove redundant FILES:PN-dev, this is part of the default.
> 

Could be its own patch.

Missing License-Update: trailer like patchtest bot said.

Cheers,
Quentin