| Message ID | 20250317110519.1562513-2-niko.mauno@vaisala.com |
|---|---|
| State | New |
| Headers | show |
| Series | Support using alternative runtime D-Bus implementation | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/1-2-Add-VIRTUAL-RUNTIME_dbus-variable.patch FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/conf/distro/include/default-providers.inc b/meta/conf/distro/include/default-providers.inc index d3eefb754b..cebd0400f4 100644 --- a/meta/conf/distro/include/default-providers.inc +++ b/meta/conf/distro/include/default-providers.inc @@ -31,6 +31,7 @@ VIRTUAL-RUNTIME_base-utils ?= "busybox" VIRTUAL-RUNTIME_base-utils-hwclock ?= "busybox-hwclock" VIRTUAL-RUNTIME_base-utils-syslog ?= "busybox-syslog" VIRTUAL-RUNTIME_keymaps ?= "keymaps" +VIRTUAL-RUNTIME_dbus ?= "dbus" # # Default recipe providers diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index d31f4e2295..76d8d9ccfe 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \ file://src/main.c;beginline=1;endline=24;md5=0ad83ca0dc37ab08af448777c581e7ac" DEPENDS = "dbus glib-2.0" -RDEPENDS:${PN} += "dbus" +RDEPENDS:${PN} += "${VIRTUAL-RUNTIME_dbus}" PROVIDES += "bluez-hcidump" RPROVIDES:${PN} += "bluez-hcidump" diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc index 133e8616da..fa546ee872 100644 --- a/meta/recipes-connectivity/connman/connman.inc +++ b/meta/recipes-connectivity/connman/connman.inc @@ -119,7 +119,7 @@ RPROVIDES:${PN} = "\ " RDEPENDS:${PN} = "\ - dbus \ + ${VIRTUAL-RUNTIME_dbus} \ " PACKAGES_DYNAMIC += "^${PN}-plugin-.*" diff --git a/meta/recipes-connectivity/neard/neard_0.19.bb b/meta/recipes-connectivity/neard/neard_0.19.bb index 94df1ac3d6..3652d3aa30 100644 --- a/meta/recipes-connectivity/neard/neard_0.19.bb +++ b/meta/recipes-connectivity/neard/neard_0.19.bb @@ -37,7 +37,7 @@ do_install:append() { fi } -RDEPENDS:${PN} = "dbus" +RDEPENDS:${PN} = "${VIRTUAL-RUNTIME_dbus}" # Bluez & Wifi are not mandatory except for handover RRECOMMENDS:${PN} = "\ diff --git a/meta/recipes-connectivity/ofono/ofono_2.14.bb b/meta/recipes-connectivity/ofono/ofono_2.14.bb index 9a91afaa7b..400b5611fd 100644 --- a/meta/recipes-connectivity/ofono/ofono_2.14.bb +++ b/meta/recipes-connectivity/ofono/ofono_2.14.bb @@ -41,7 +41,7 @@ PACKAGES =+ "${PN}-tests" FILES:${PN} += "${systemd_unitdir}" FILES:${PN}-tests = "${libdir}/${BPN}/test" -RDEPENDS:${PN} += "dbus" +RDEPENDS:${PN} += "${VIRTUAL-RUNTIME_dbus}" RDEPENDS:${PN}-tests = "\ python3-core \ python3-dbus \ diff --git a/meta/recipes-core/dbus/dbus_1.16.2.bb b/meta/recipes-core/dbus/dbus_1.16.2.bb index 9475e55b57..0160f403a1 100644 --- a/meta/recipes-core/dbus/dbus_1.16.2.bb +++ b/meta/recipes-core/dbus/dbus_1.16.2.bb @@ -104,7 +104,9 @@ FILES:${PN}-tools = "${bindir}/dbus-uuidgen \ ${bindir}/dbus-update-activation-environment \ " FILES:${PN}-lib = "${libdir}/lib*.so.*" -RRECOMMENDS:${PN}-lib = "${PN}" +RRECOMMENDS:${PN}-lib:class-target = "${VIRTUAL-RUNTIME_dbus}" +RRECOMMENDS:${PN}-lib:class-native = "dbus" +RRECOMMENDS:${PN}-lib:class-nativesdk = "dbus" FILES:${PN}-dev += "${libdir}/dbus-1.0/include ${bindir}/dbus-test-tool ${datadir}/xml/dbus-1" RDEPENDS:${PN}-ptest += "bash make dbus" diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index 9d50a95c40..67860ddef0 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -162,7 +162,7 @@ RDEPENDS:${PN}-ptest += "${PN}-utils" RDEPENDS:${PN}-ptest += "\ coreutils \ libgcc \ - dbus \ + ${VIRTUAL-RUNTIME_dbus} \ desktop-file-utils \ gnome-desktop-testing \ tzdata \ diff --git a/meta/recipes-core/systemd/systemd_257.3.bb b/meta/recipes-core/systemd/systemd_257.3.bb index 64fb8fe69a..24aad11c0a 100644 --- a/meta/recipes-core/systemd/systemd_257.3.bb +++ b/meta/recipes-core/systemd/systemd_257.3.bb @@ -752,7 +752,7 @@ FILES:${PN} = " ${base_bindir}/* \ FILES:${PN}-dev += "${base_libdir}/security/*.la ${datadir}/dbus-1/interfaces/ ${sysconfdir}/rpm/macros.systemd" -RDEPENDS:${PN} += "kmod dbus util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) systemd-udev-rules util-linux-agetty util-linux-fsck util-linux-swaponoff util-linux-mkswap" +RDEPENDS:${PN} += "kmod ${VIRTUAL-RUNTIME_dbus} util-linux-mount util-linux-umount udev (= ${EXTENDPKGV}) systemd-udev-rules util-linux-agetty util-linux-fsck util-linux-swaponoff util-linux-mkswap" RDEPENDS:${PN} += "${@bb.utils.contains('PACKAGECONFIG', 'serial-getty-generator', '', 'systemd-serialgetty', d)}" RDEPENDS:${PN} += "volatile-binds"
The default value of this new variable can be overridden for instance in local.conf file like VIRTUAL-RUNTIME_dbus = "dbus-broker" to use an alternative implementation of D-Bus, recipe for which is currently available under meta-openembedded/meta-oe/recipes-core/dbus/ The functionality is accomplished by changing references to 'dbus' in recipe RDEPENDS and RRECOMMENDS to '${VIRTUAL-RUNTIME_dbus}'. Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> --- meta/conf/distro/include/default-providers.inc | 1 + meta/recipes-connectivity/bluez5/bluez5.inc | 2 +- meta/recipes-connectivity/connman/connman.inc | 2 +- meta/recipes-connectivity/neard/neard_0.19.bb | 2 +- meta/recipes-connectivity/ofono/ofono_2.14.bb | 2 +- meta/recipes-core/dbus/dbus_1.16.2.bb | 4 +++- meta/recipes-core/glib-2.0/glib.inc | 2 +- meta/recipes-core/systemd/systemd_257.3.bb | 2 +- 8 files changed, 10 insertions(+), 7 deletions(-)