diff mbox series

tcmode-default: eliminate needless linux-libc-headers version defaults

Message ID 20250313174036.102942-1-Randy.MacLeod@windriver.com
State New
Headers show
Series tcmode-default: eliminate needless linux-libc-headers version defaults | expand

Commit Message

Randy MacLeod March 13, 2025, 5:40 p.m. UTC
From: Randy MacLeod <Randy.MacLeod@windriver.com>

Manually setting the preferred version is not required or generally a
good idea as stated in:
   meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc

   # You're probably looking here thinking you need to create some new copy
   # of linux-libc-headers since you have your own custom kernel. To put
   # this simply, you DO NOT.

so remove that for linux-libc-headers.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 meta/conf/distro/include/tcmode-default.inc | 3 ---
 1 file changed, 3 deletions(-)

Comments

Khem Raj March 13, 2025, 6:53 p.m. UTC | #1
On Thu, Mar 13, 2025 at 10:40 AM Randy MacLeod via
lists.openembedded.org
<randy.macleod=windriver.com@lists.openembedded.org> wrote:
>
> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
> Manually setting the preferred version is not required or generally a
> good idea as stated in:
>    meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>
>    # You're probably looking here thinking you need to create some new copy
>    # of linux-libc-headers since you have your own custom kernel. To put
>    # this simply, you DO NOT.
>
> so remove that for linux-libc-headers.
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
> index b43d5ffe8b..cbe8442cde 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -12,7 +12,6 @@ PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
>  GCCVERSION ?= "14.%"
>  SDKGCCVERSION ?= "${GCCVERSION}"
>  GLIBCVERSION ?= "2.41%"
> -LINUXLIBCVERSION ?= "6.12%"

I think this is quite commonly used than others you were removing.
Mismatched kernel and kernel-headers
do have resulted in issues and BSPs do not match up to the released
kernel in oe-core. While I am fine with
this change, I think people will still need it, although a bit unwieldy now.

>  RUSTVERSION ?= "1.83%"
>
>  PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
> @@ -30,8 +29,6 @@ PREFERRED_VERSION_nativesdk-gcc ?= "${SDKGCCVERSION}"
>  PREFERRED_VERSION_nativesdk-libgcc ?= "${SDKGCCVERSION}"
>  PREFERRED_VERSION_nativesdk-libgcc-initial ?= "${SDKGCCVERSION}"
>
> -PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
> -PREFERRED_VERSION_nativesdk-linux-libc-headers ?= "${LINUXLIBCVERSION}"
>  PREFERRED_VERSION_glibc                    ?= "${GLIBCVERSION}"
>  PREFERRED_VERSION_glibc-locale             ?= "${GLIBCVERSION}"
>  PREFERRED_VERSION_glibc-mtrace             ?= "${GLIBCVERSION}"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#212798): https://lists.openembedded.org/g/openembedded-core/message/212798
> Mute This Topic: https://lists.openembedded.org/mt/111684601/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index b43d5ffe8b..cbe8442cde 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -12,7 +12,6 @@  PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
 GCCVERSION ?= "14.%"
 SDKGCCVERSION ?= "${GCCVERSION}"
 GLIBCVERSION ?= "2.41%"
-LINUXLIBCVERSION ?= "6.12%"
 RUSTVERSION ?= "1.83%"
 
 PREFERRED_VERSION_gcc ?= "${GCCVERSION}"
@@ -30,8 +29,6 @@  PREFERRED_VERSION_nativesdk-gcc ?= "${SDKGCCVERSION}"
 PREFERRED_VERSION_nativesdk-libgcc ?= "${SDKGCCVERSION}"
 PREFERRED_VERSION_nativesdk-libgcc-initial ?= "${SDKGCCVERSION}"
 
-PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
-PREFERRED_VERSION_nativesdk-linux-libc-headers ?= "${LINUXLIBCVERSION}"
 PREFERRED_VERSION_glibc                    ?= "${GLIBCVERSION}"
 PREFERRED_VERSION_glibc-locale             ?= "${GLIBCVERSION}"
 PREFERRED_VERSION_glibc-mtrace             ?= "${GLIBCVERSION}"