diff mbox series

[v2,2/2] scripts/install-buildtools: write download URLs to files for traceability

Message ID 20250313172223.3407902-2-alex.kanavin@gmail.com
State New
Headers show
Series [v2,1/2] scripts/install-buildtools: add an option to specify where downloads go | expand

Commit Message

Alexander Kanavin March 13, 2025, 5:22 p.m. UTC 
From: Alexander Kanavin <alex@linutronix.de>

This extends the previous commit, so that download URLs are preserved
in addition to actual artefacts. By default it's all written to a temporary
directory and erased together with artefacts, but users can choose
to preserve both:

$ install-buildtools -D --keep-downloads-directory=.
...

$ ls -1
buildtools_url
checksum_url
x86_64-buildtools-extended-nativesdk-standalone-5.1.2.sh
x86_64-buildtools-extended-nativesdk-standalone-5.1.2.sh.sha256sum

Additionally, rename check_url variable into checksum_url as it's
a better name.

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
 scripts/install-buildtools | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/scripts/install-buildtools b/scripts/install-buildtools
index 6287416c9a7..952da888bae 100755
--- a/scripts/install-buildtools
+++ b/scripts/install-buildtools
@@ -244,6 +244,8 @@  def main():
         # Fetch installer
         logger.info("Fetching buildtools installer")
         tmpbuildtools = os.path.join(sdk_dir, filename)
+        with open(os.path.join(sdk_dir, 'buildtools_url'), 'w') as f:
+            f.write(buildtools_url)
         ret = subprocess.call("wget -q -O %s %s" %
                               (tmpbuildtools, buildtools_url), shell=True)
         if ret != 0:
@@ -254,13 +256,15 @@  def main():
         if args.check:
             logger.info("Fetching buildtools installer checksum")
             checksum_type = "sha256sum"
-            check_url = "{}.{}".format(buildtools_url, checksum_type)
+            checksum_url = "{}.{}".format(buildtools_url, checksum_type)
             checksum_filename = "{}.{}".format(filename, checksum_type)
             tmpbuildtools_checksum = os.path.join(sdk_dir, checksum_filename)
+            with open(os.path.join(sdk_dir, 'checksum_url'), 'w') as f:
+                f.write(checksum_url)
             ret = subprocess.call("wget -q -O %s %s" %
-                                    (tmpbuildtools_checksum, check_url), shell=True)
+                                    (tmpbuildtools_checksum, checksum_url), shell=True)
             if ret != 0:
-                logger.error("Could not download file from %s" % check_url)
+                logger.error("Could not download file from %s" % checksum_url)
                 return ret
             regex = re.compile(r"^(?P<checksum>[0-9a-f]+)\s+(?P<path>.*/)?(?P<filename>.*)$")
             with open(tmpbuildtools_checksum, 'rb') as f: