diff mbox series

[1/2] tcmode-default: eliminate needless gdb, qemu defaults

Message ID 20250306185551.1758417-1-Randy.MacLeod@windriver.com
State Accepted, archived
Commit 4f22ca1233b390308f8266bafe96efaee0631cf4
Headers show
Series [1/2] tcmode-default: eliminate needless gdb, qemu defaults | expand

Commit Message

Randy MacLeod March 6, 2025, 6:55 p.m. UTC
From: Randy MacLeod <Randy.MacLeod@windriver.com>

Manually setting preferred version/provider is not required so remove
that for gdb and qemu as a first step of cleaning up this file.

This PREFERRED_VERSION list dates back to 2006, which is an era where
several versions of a given recipe was a common occurence.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 meta/conf/distro/include/tcmode-default.inc | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Khem Raj March 6, 2025, 11:24 p.m. UTC | #1
Are we sure that we don’t have external toolchains feeding gdb these days

On Thu, Mar 6, 2025 at 1:55 PM <Randy.MacLeod@windriver.com> wrote:

> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
> Manually setting preferred version/provider is not required so remove
> that for gdb and qemu as a first step of cleaning up this file.
>
> This PREFERRED_VERSION list dates back to 2006, which is an era where
> several versions of a given recipe was a common occurence.
>
> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> index 079a7ca3ea..ce0c8235e4 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -6,18 +6,14 @@ PREFERRED_PROVIDER_virtual/cross-binutils =
> "${MLPREFIX}binutils-cross-${TARGET_
>  PREFERRED_PROVIDER_virtual/cross-binutils:class-nativesdk ?=
> "binutils-crosssdk-${SDK_SYS}"
>  PREFERRED_PROVIDER_virtual/nativesdk-cross-binutils ?=
> "binutils-crosssdk-${SDK_SYS}"
>
> -PREFERRED_PROVIDER_gdb = "gdb"
> -
>  # Default libc config
>  PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
>
>  GCCVERSION ?= "14.%"
>  SDKGCCVERSION ?= "${GCCVERSION}"
>  BINUVERSION ?= "2.44%"
> -GDBVERSION ?= "16.%"
>  GLIBCVERSION ?= "2.41%"
>  LINUXLIBCVERSION ?= "6.12%"
> -QEMUVERSION ?= "9.2%"
>  GOVERSION ?= "1.24%"
>  RUSTVERSION ?= "1.83%"
>
> @@ -40,9 +36,6 @@ PREFERRED_VERSION_binutils-native ?= "${BINUVERSION}"
>  PREFERRED_VERSION_binutils-cross-${TARGET_ARCH} ?= "${BINUVERSION}"
>  PREFERRED_VERSION_binutils-crosssdk-${SDK_SYS} ?= "${BINUVERSION}"
>  PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} ?=
> "${BINUVERSION}"
> -PREFERRED_VERSION_gdb ?= "${GDBVERSION}"
> -PREFERRED_VERSION_gdb-cross-${TARGET_ARCH} ?= "${GDBVERSION}"
> -PREFERRED_VERSION_gdb-cross-canadian-${TRANSLATED_TARGET_ARCH} ?=
> "${GDBVERSION}"
>
>  PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
>  PREFERRED_VERSION_nativesdk-linux-libc-headers ?= "${LINUXLIBCVERSION}"
> @@ -53,10 +46,6 @@ PREFERRED_VERSION_glibc-scripts            ?=
> "${GLIBCVERSION}"
>  PREFERRED_VERSION_nativesdk-glibc          ?= "${GLIBCVERSION}"
>  PREFERRED_VERSION_cross-localedef-native   ?= "${GLIBCVERSION}"
>
> -PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
> -PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
> -PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
> -
>  # Bootstrap Go using a binary release from golang.org.  If you want to
> bootstrap
>  # from source using the C-implemented Go 1.4 (only supports x86-64 hosts)
> then use
>  # go-native.
> --
> 2.34.1
>
>
Randy MacLeod March 7, 2025, 1:39 a.m. UTC | #2
On 2025-03-06 6:24 p.m., Khem Raj wrote:
> Are we sure that we don’t have external toolchains feeding gdb these days


I'm not sure. That's why I cc'ed you.  :-)

How would I check or who would we ask?

Let's start with Mark and Ross.
It's easy enough to revert if we find that someone, somehow needs this
but I plan to remove the rust and binutils bits next and if that goes well,
drop the rest of the file at the start of 5.3 if not sooner.

../Randy


>
> On Thu, Mar 6, 2025 at 1:55 PM <Randy.MacLeod@windriver.com> wrote:
>
>     From: Randy MacLeod <Randy.MacLeod@windriver.com>
>
>     Manually setting preferred version/provider is not required so remove
>     that for gdb and qemu as a first step of cleaning up this file.
>
>     This PREFERRED_VERSION list dates back to 2006, which is an era where
>     several versions of a given recipe was a common occurence.
>
>     Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>     ---
>      meta/conf/distro/include/tcmode-default.inc
>     <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5qRa2oYmw$>
>     | 11 -----------
>      1 file changed, 11 deletions(-)
>
>     diff --git a/meta/conf/distro/include/tcmode-default.inc
>     <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5qRa2oYmw$>
>     b/meta/conf/distro/include/tcmode-default.inc
>     <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5qRa2oYmw$>
>     index 079a7ca3ea..ce0c8235e4 100644
>     --- a/meta/conf/distro/include/tcmode-default.inc
>     <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5qRa2oYmw$>
>     +++ b/meta/conf/distro/include/tcmode-default.inc
>     <https://urldefense.com/v3/__http://tcmode-default.inc__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5qRa2oYmw$>
>     @@ -6,18 +6,14 @@ PREFERRED_PROVIDER_virtual/cross-binutils =
>     "${MLPREFIX}binutils-cross-${TARGET_
>      PREFERRED_PROVIDER_virtual/cross-binutils:class-nativesdk ?=
>     "binutils-crosssdk-${SDK_SYS}"
>      PREFERRED_PROVIDER_virtual/nativesdk-cross-binutils ?=
>     "binutils-crosssdk-${SDK_SYS}"
>
>     -PREFERRED_PROVIDER_gdb = "gdb"
>     -
>      # Default libc config
>      PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
>
>      GCCVERSION ?= "14.%"
>      SDKGCCVERSION ?= "${GCCVERSION}"
>      BINUVERSION ?= "2.44%"
>     -GDBVERSION ?= "16.%"
>      GLIBCVERSION ?= "2.41%"
>      LINUXLIBCVERSION ?= "6.12%"
>     -QEMUVERSION ?= "9.2%"
>      GOVERSION ?= "1.24%"
>      RUSTVERSION ?= "1.83%"
>
>     @@ -40,9 +36,6 @@ PREFERRED_VERSION_binutils-native ?=
>     "${BINUVERSION}"
>      PREFERRED_VERSION_binutils-cross-${TARGET_ARCH} ?= "${BINUVERSION}"
>      PREFERRED_VERSION_binutils-crosssdk-${SDK_SYS} ?= "${BINUVERSION}"
>      PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH}
>     ?= "${BINUVERSION}"
>     -PREFERRED_VERSION_gdb ?= "${GDBVERSION}"
>     -PREFERRED_VERSION_gdb-cross-${TARGET_ARCH} ?= "${GDBVERSION}"
>     -PREFERRED_VERSION_gdb-cross-canadian-${TRANSLATED_TARGET_ARCH} ?=
>     "${GDBVERSION}"
>
>      PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
>      PREFERRED_VERSION_nativesdk-linux-libc-headers ?=
>     "${LINUXLIBCVERSION}"
>     @@ -53,10 +46,6 @@ PREFERRED_VERSION_glibc-scripts   ?=
>     "${GLIBCVERSION}"
>      PREFERRED_VERSION_nativesdk-glibc          ?= "${GLIBCVERSION}"
>      PREFERRED_VERSION_cross-localedef-native   ?= "${GLIBCVERSION}"
>
>     -PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
>     -PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
>     -PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
>     -
>      # Bootstrap Go using a binary release from golang.org
>     <https://urldefense.com/v3/__http://golang.org__;!!AjveYdw8EvQ!dsbtuYnz0eaBpWn8FlbH-Kg-yVU-NnmybrYYxp3Vi_6SjL_R-Xpy8sQ_S_HUWOf51ur_kGYmjQ8Zc5oPQTBExQ$>.
>     If you want to bootstrap
>      # from source using the C-implemented Go 1.4 (only supports
>     x86-64 hosts) then use
>      # go-native.
>     -- 
>     2.34.1
>
Khem Raj March 7, 2025, 4:48 p.m. UTC | #3
On Thu, Mar 6, 2025 at 5:40 PM Randy MacLeod
<randy.macleod@windriver.com> wrote:
>
> On 2025-03-06 6:24 p.m., Khem Raj wrote:
>
> Are we sure that we don’t have external toolchains feeding gdb these days
>
>
> I'm not sure. That's why I cc'ed you.  :-)
>
> How would I check or who would we ask?
>
> Let's start with Mark and Ross.
> It's easy enough to revert if we find that someone, somehow needs this
> but I plan to remove the rust and binutils bits next and if that goes well,
> drop the rest of the file at the start of 5.3 if not sooner.
>

In general I am ok with this it does make core policies a bit tighter,
and I do not have usecase for external toolchains myself
but we have tried to accommodate other providers of external
toolchains in past but there is
PREFERRED_PROVIDER way of hooking the overriding toolchains as well
e.g. in meta-go-binary layer
this is the way it is used.

> ../Randy
>
>
>
> On Thu, Mar 6, 2025 at 1:55 PM <Randy.MacLeod@windriver.com> wrote:
>>
>> From: Randy MacLeod <Randy.MacLeod@windriver.com>
>>
>> Manually setting preferred version/provider is not required so remove
>> that for gdb and qemu as a first step of cleaning up this file.
>>
>> This PREFERRED_VERSION list dates back to 2006, which is an era where
>> several versions of a given recipe was a common occurence.
>>
>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> ---
>>  meta/conf/distro/include/tcmode-default.inc | 11 -----------
>>  1 file changed, 11 deletions(-)
>>
>> diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
>> index 079a7ca3ea..ce0c8235e4 100644
>> --- a/meta/conf/distro/include/tcmode-default.inc
>> +++ b/meta/conf/distro/include/tcmode-default.inc
>> @@ -6,18 +6,14 @@ PREFERRED_PROVIDER_virtual/cross-binutils = "${MLPREFIX}binutils-cross-${TARGET_
>>  PREFERRED_PROVIDER_virtual/cross-binutils:class-nativesdk ?= "binutils-crosssdk-${SDK_SYS}"
>>  PREFERRED_PROVIDER_virtual/nativesdk-cross-binutils ?= "binutils-crosssdk-${SDK_SYS}"
>>
>> -PREFERRED_PROVIDER_gdb = "gdb"
>> -
>>  # Default libc config
>>  PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
>>
>>  GCCVERSION ?= "14.%"
>>  SDKGCCVERSION ?= "${GCCVERSION}"
>>  BINUVERSION ?= "2.44%"
>> -GDBVERSION ?= "16.%"
>>  GLIBCVERSION ?= "2.41%"
>>  LINUXLIBCVERSION ?= "6.12%"
>> -QEMUVERSION ?= "9.2%"
>>  GOVERSION ?= "1.24%"
>>  RUSTVERSION ?= "1.83%"
>>
>> @@ -40,9 +36,6 @@ PREFERRED_VERSION_binutils-native ?= "${BINUVERSION}"
>>  PREFERRED_VERSION_binutils-cross-${TARGET_ARCH} ?= "${BINUVERSION}"
>>  PREFERRED_VERSION_binutils-crosssdk-${SDK_SYS} ?= "${BINUVERSION}"
>>  PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${BINUVERSION}"
>> -PREFERRED_VERSION_gdb ?= "${GDBVERSION}"
>> -PREFERRED_VERSION_gdb-cross-${TARGET_ARCH} ?= "${GDBVERSION}"
>> -PREFERRED_VERSION_gdb-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${GDBVERSION}"
>>
>>  PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
>>  PREFERRED_VERSION_nativesdk-linux-libc-headers ?= "${LINUXLIBCVERSION}"
>> @@ -53,10 +46,6 @@ PREFERRED_VERSION_glibc-scripts            ?= "${GLIBCVERSION}"
>>  PREFERRED_VERSION_nativesdk-glibc          ?= "${GLIBCVERSION}"
>>  PREFERRED_VERSION_cross-localedef-native   ?= "${GLIBCVERSION}"
>>
>> -PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
>> -PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
>> -PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
>> -
>>  # Bootstrap Go using a binary release from golang.org.  If you want to bootstrap
>>  # from source using the C-implemented Go 1.4 (only supports x86-64 hosts) then use
>>  # go-native.
>> --
>> 2.34.1
>>
>
> --
> # Randy MacLeod
> # Wind River Linux
Richard Purdie March 7, 2025, 5:02 p.m. UTC | #4
On Fri, 2025-03-07 at 08:48 -0800, Khem Raj via lists.openembedded.org wrote:
> On Thu, Mar 6, 2025 at 5:40 PM Randy MacLeod
> <randy.macleod@windriver.com> wrote:
> > 
> > On 2025-03-06 6:24 p.m., Khem Raj wrote:
> > 
> > Are we sure that we don’t have external toolchains feeding gdb these days
> > 
> > 
> > I'm not sure. That's why I cc'ed you.  :-)
> > 
> > How would I check or who would we ask?
> > 
> > Let's start with Mark and Ross.
> > It's easy enough to revert if we find that someone, somehow needs this
> > but I plan to remove the rust and binutils bits next and if that goes well,
> > drop the rest of the file at the start of 5.3 if not sooner.
> > 
> 
> In general I am ok with this it does make core policies a bit tighter,
> and I do not have usecase for external toolchains myself
> but we have tried to accommodate other providers of external
> toolchains in past but there is
> PREFERRED_PROVIDER way of hooking the overriding toolchains as well
> e.g. in meta-go-binary layer
> this is the way it is used.

I think the way people use the project has changed and these are more
of a holdover from the past now. If a layer does need them they can
certainly add and set them but we probably don't need to in core any
more...

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index 079a7ca3ea..ce0c8235e4 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -6,18 +6,14 @@  PREFERRED_PROVIDER_virtual/cross-binutils = "${MLPREFIX}binutils-cross-${TARGET_
 PREFERRED_PROVIDER_virtual/cross-binutils:class-nativesdk ?= "binutils-crosssdk-${SDK_SYS}"
 PREFERRED_PROVIDER_virtual/nativesdk-cross-binutils ?= "binutils-crosssdk-${SDK_SYS}"
 
-PREFERRED_PROVIDER_gdb = "gdb"
-
 # Default libc config
 PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
 
 GCCVERSION ?= "14.%"
 SDKGCCVERSION ?= "${GCCVERSION}"
 BINUVERSION ?= "2.44%"
-GDBVERSION ?= "16.%"
 GLIBCVERSION ?= "2.41%"
 LINUXLIBCVERSION ?= "6.12%"
-QEMUVERSION ?= "9.2%"
 GOVERSION ?= "1.24%"
 RUSTVERSION ?= "1.83%"
 
@@ -40,9 +36,6 @@  PREFERRED_VERSION_binutils-native ?= "${BINUVERSION}"
 PREFERRED_VERSION_binutils-cross-${TARGET_ARCH} ?= "${BINUVERSION}"
 PREFERRED_VERSION_binutils-crosssdk-${SDK_SYS} ?= "${BINUVERSION}"
 PREFERRED_VERSION_binutils-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${BINUVERSION}"
-PREFERRED_VERSION_gdb ?= "${GDBVERSION}"
-PREFERRED_VERSION_gdb-cross-${TARGET_ARCH} ?= "${GDBVERSION}"
-PREFERRED_VERSION_gdb-cross-canadian-${TRANSLATED_TARGET_ARCH} ?= "${GDBVERSION}"
 
 PREFERRED_VERSION_linux-libc-headers ?= "${LINUXLIBCVERSION}"
 PREFERRED_VERSION_nativesdk-linux-libc-headers ?= "${LINUXLIBCVERSION}"
@@ -53,10 +46,6 @@  PREFERRED_VERSION_glibc-scripts            ?= "${GLIBCVERSION}"
 PREFERRED_VERSION_nativesdk-glibc          ?= "${GLIBCVERSION}"
 PREFERRED_VERSION_cross-localedef-native   ?= "${GLIBCVERSION}"
 
-PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
-PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
-PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
-
 # Bootstrap Go using a binary release from golang.org.  If you want to bootstrap
 # from source using the C-implemented Go 1.4 (only supports x86-64 hosts) then use
 # go-native.