| Message ID | 20250306145246.2923077-1-quic_bpothuno@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dhcpcd: upgrade 10.1.0 -> 10.2.2 | expand |
On Thu, Mar 06, 2025 at 08:22:46PM +0530, Balaji Pothunoori wrote: > This change includes: > a. upgrades dhcpcd version to latest 10.2.2. > b. update LIC_FILES_CHKSUM for dhcpcd > License-Update: Updated MD5 checksum for LICENSE file to reflect > changes in version 10.2.2 > > Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com> > --- > v2: added commit text. > > .../dhcpcd/{dhcpcd_10.1.0.bb => dhcpcd_10.2.2.bb} | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > rename meta/recipes-connectivity/dhcpcd/{dhcpcd_10.1.0.bb => dhcpcd_10.2.2.bb} (94%) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Thanks!
On Thu, 2025-03-06 at 20:22 +0530, Balaji Pothunoori via lists.openembedded.org wrote: > This change includes: > a. upgrades dhcpcd version to latest 10.2.2. > b. update LIC_FILES_CHKSUM for dhcpcd > License-Update: Updated MD5 checksum for LICENSE file to reflect > changes in version 10.2.2 The key thing we need to know is did the license of the code change? The recipe says it is BSD-2-Clause, is that still the case? Do we need to drop the fix I merged in one of your previous patches? Is it still needed with this version? Cheers, Richard
> -----Original Message----- > From: Richard Purdie <richard.purdie@linuxfoundation.org> > Sent: Thursday, March 6, 2025 10:06 PM > To: Balaji Pothunoori (QUIC) <quic_bpothuno@quicinc.com>; > openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH v2] dhcpcd: upgrade 10.1.0 -> 10.2.2 > > On Thu, 2025-03-06 at 20:22 +0530, Balaji Pothunoori via > lists.openembedded.org wrote: > > This change includes: > > a. upgrades dhcpcd version to latest 10.2.2. > > b. update LIC_FILES_CHKSUM for dhcpcd > > License-Update: Updated MD5 checksum for LICENSE file to reflect > > changes in version 10.2.2 > > The key thing we need to know is did the license of the code change? > The recipe says it is BSD-2-Clause, is that still the case? I noticed that the dhcpd source code is licensed under the BSD 2-Clause License. The MD5 checksum of the dhcpcd LICENSE file has changed, causing the recipe to throw a compilation error. ERROR: dhcpcd-10.2.2-r0 do_populate_lic: QA Issue: dhcpcd: The LIC_FILES_CHKSUM does not match for file://LICENSE;md5=d296c4bec306f351e676705aaf237c8c dhcpcd: The new md5 checksum is 4dda5beb433a809f2e0aeffbf9da3d91 & #md5sum LICENSE 4dda5beb433a809f2e0aeffbf9da3d91 LICENSE > > Do we need to drop the fix I merged in one of your previous patches? Is it still > needed with this version? Could you please direct me to the specific change you are mentioning? > > Cheers, > > Richard Regards, Balaji.
On Thu, 6 Mar 2025 at 18:17, Balaji Pothunoori via lists.openembedded.org <quic_bpothuno=quicinc.com@lists.openembedded.org> wrote: > > The key thing we need to know is did the license of the code change? > > The recipe says it is BSD-2-Clause, is that still the case? > > I noticed that the dhcpd source code is licensed under the BSD 2-Clause License. > The MD5 checksum of the dhcpcd LICENSE file has changed, causing the recipe to throw a compilation error. > > ERROR: dhcpcd-10.2.2-r0 do_populate_lic: QA Issue: dhcpcd: The LIC_FILES_CHKSUM does not match for file://LICENSE;md5=d296c4bec306f351e676705aaf237c8c > dhcpcd: The new md5 checksum is 4dda5beb433a809f2e0aeffbf9da3d91 > > & > > #md5sum LICENSE > 4dda5beb433a809f2e0aeffbf9da3d91 LICENSE In this case, you need to actually check what changed in the LICENSE file, and summarize it in License-Update tag. You cannot simply say "License-Update: something changed". It's probably just copyright years: https://github.com/NetworkConfiguration/dhcpcd/commits/master/LICENSE Alex
On Thu, Mar 06, 2025 at 04:36:29PM +0000, Richard Purdie wrote: > On Thu, 2025-03-06 at 20:22 +0530, Balaji Pothunoori via > lists.openembedded.org wrote: > > This change includes: > > a. upgrades dhcpcd version to latest 10.2.2. > > b. update LIC_FILES_CHKSUM for dhcpcd > > License-Update: Updated MD5 checksum for LICENSE file to reflect > > changes in version 10.2.2 > > The key thing we need to know is did the license of the code change? > The recipe says it is BSD-2-Clause, is that still the case? Yes > > Do we need to drop the fix I merged in one of your previous patches? Is > it still needed with this version? No, it was merged upstream and can be dropped. > > Cheers, > > Richard > >
diff --git a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.2.2.bb similarity index 94% rename from meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb rename to meta/recipes-connectivity/dhcpcd/dhcpcd_10.2.2.bb index 3f806bb18783..0b4345e7fa4a 100644 --- a/meta/recipes-connectivity/dhcpcd/dhcpcd_10.1.0.bb +++ b/meta/recipes-connectivity/dhcpcd/dhcpcd_10.2.2.bb @@ -7,7 +7,7 @@ DESCRIPTION = "dhcpcd runs on your machine and silently configures your \ HOMEPAGE = "http://roy.marples.name/projects/dhcpcd/" LICENSE = "BSD-2-Clause" -LIC_FILES_CHKSUM = "file://LICENSE;md5=d296c4bec306f351e676705aaf237c8c" +LIC_FILES_CHKSUM = "file://LICENSE;md5=4dda5beb433a809f2e0aeffbf9da3d91" SRC_URI = "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=master \ file://0001-remove-INCLUDEDIR-to-prevent-build-issues.patch \ @@ -17,7 +17,7 @@ SRC_URI = "git://github.com/NetworkConfiguration/dhcpcd;protocol=https;branch=ma file://0001-dhcpcd.8-Fix-conflict-error-when-enable-multilib.patch \ " -SRCREV = "57c3506a5622e199cf0e3fc1ef26a71cdedc9521" +SRCREV = "f6983c18dbf7989f43a2838beeaf62a54c53ff1d" S = "${WORKDIR}/git" inherit pkgconfig autotools-brokensep systemd useradd
This change includes: a. upgrades dhcpcd version to latest 10.2.2. b. update LIC_FILES_CHKSUM for dhcpcd License-Update: Updated MD5 checksum for LICENSE file to reflect changes in version 10.2.2 Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com> --- v2: added commit text. .../dhcpcd/{dhcpcd_10.1.0.bb => dhcpcd_10.2.2.bb} | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) rename meta/recipes-connectivity/dhcpcd/{dhcpcd_10.1.0.bb => dhcpcd_10.2.2.bb} (94%)