diff mbox series

[2/2] perf: enable zstd in default PACKAGECONFIG

Message ID 20250225155647.3295109-2-bruce.ashfield@gmail.com
State Accepted, archived
Commit c1b44f4e9f7d13673a93aa81be6a3e11aa9f742b
Headers show
Series [1/2] linux-yocto-dev: bump to v6.14 | expand

Commit Message

Bruce Ashfield Feb. 25, 2025, 3:56 p.m. UTC 
From: Bruce Ashfield <bruce.ashfield@gmail.com>

The following upstream commit:

  commit 44b44ffd5dcef03d273ad070d0b02a65a323f5f6
  Author: Leo Yan <leo.yan@arm.com>
  Date:   Sun Dec 15 22:12:22 2024 +0000

      perf build: Minor improvement for linking libzstd

      The zstd library will be automatically linked by detecting the feature
      libzstd.  It is no need to explicitly link it for static builds, so
      remove the redundant linkage.

      It is contradictory to detect the feature libelf-zstd while the build
      configuration NO_LIBZSTD is set.  Report an error for reminding users
      not to set NO_LIBZSTD.

      Signed-off-by: Leo Yan <leo.yan@arm.com>
      Tested-by: Namhyung Kim <namhyung@kernel.org>
      Acked-by: Andrii Nakryiko <andrii@kernel.org>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Alexei Starovoitov <ast@kernel.org>
      Cc: Daniel Borkmann <daniel@iogearbox.net>
      Cc: Eduard Zingerman <eddyz87@gmail.com>
      Cc: Guilherme Amadio <amadio@gentoo.org>
      Cc: Hao Luo <haoluo@google.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: James Clark <james.clark@linaro.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: John Fastabend <john.fastabend@gmail.com>
      Cc: KP Singh <kpsingh@kernel.org>
      Cc: Kan Liang <kan.liang@linux.intel.com>
      Cc: Martin KaFai Lau <martin.lau@linux.dev>
      Cc: Nick Terrell <terrelln@fb.com>
      Cc: Quentin Monnet <qmo@kernel.org>
      Cc: Song Liu <song@kernel.org>
      Cc: Stanislav Fomichev <sdf@google.com>
      Cc: Yonghong Song <yonghong.song@linux.dev>
      Link: https://lore.kernel.org/r/20241215221223.293205-3-leo.yan@arm.com
      Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

Enforces that zstd must be enabled if libelfstd is detected.

Our build of perf and the other default features lead to libelf-zstd
being detected, and hence the build aborts when the features are
checked.

We can't condionally enable this for 6.14+ kernels due to the way that
the perf recipe works. The feature is minor and probably should have
already been in the defaults. To keep things simple, we just enable it
and will watch for any fallout.

Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
---
 meta/recipes-kernel/perf/perf.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 18e2454f9a..d06dd2fa5a 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -9,8 +9,8 @@  HOMEPAGE = "https://perf.wiki.kernel.org/index.php/Main_Page"
 
 LICENSE = "GPL-2.0-only"
 
-
-PACKAGECONFIG ??= "python tui libunwind libtraceevent"
+# zstd is required for kernels 6.14+ when libelf-zstd is detected
+PACKAGECONFIG ??= "python tui libunwind libtraceevent zstd"
 PACKAGECONFIG[dwarf] = ",NO_DWARF=1"
 PACKAGECONFIG[perl] = ",NO_LIBPERL=1,perl"
 PACKAGECONFIG[python] = ",NO_LIBPYTHON=1,python3 python3-setuptools-native"