diff mbox series

[v2] gdb: enable xz in gdb-cross and gdb-cross-canadian

Message ID 20250210181625.3675958-1-ecordonnier@snap.com
State New
Headers show
Series [v2] gdb: enable xz in gdb-cross and gdb-cross-canadian | expand

Commit Message

Etienne Cordonnier Feb. 10, 2025, 6:16 p.m. UTC
From: Etienne Cordonnier <ecordonnier@snap.com>

- Keep a single base-value of the PACKAGECONFIG variable in gdb-common.inc for easier maintenance.

- Enable xz (needed by minidebuginfo) unconditionally in gdb-cross and
  gdb-cross-canadian since those are typically not used in minimal systems, but
  rather e.g. on an X86 desktop, and xz is not a huge dependency. It is also nice
  to not need to recompile gdb-cross when switching between a DISTRO where
  minidebuginfo is disabled, and one where minidebuginfo is enabled.

Signed-off-by: Etienne Cordonnier <ecordonnier@snap.com>
---
 meta/recipes-devtools/gdb/gdb-cross-canadian.inc | 2 +-
 meta/recipes-devtools/gdb/gdb-cross.inc          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
index 9150c196a85..2e7bf99d352 100644
--- a/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross-canadian.inc
@@ -12,7 +12,7 @@  DEPENDS = "nativesdk-ncurses nativesdk-expat nativesdk-gettext nativesdk-gmp nat
 GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
 
 # Overrides PACKAGECONFIG variables in gdb-common.inc
-PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
+PACKAGECONFIG:append = " xz"
 PACKAGECONFIG[python] = "--with-python=${WORKDIR}/python,--without-python,nativesdk-python3, \
                          nativesdk-python3-core \
                          nativesdk-python3-codecs nativesdk-python3-netclient \
diff --git a/meta/recipes-devtools/gdb/gdb-cross.inc b/meta/recipes-devtools/gdb/gdb-cross.inc
index 399f4bba97a..e7bffe11d3e 100644
--- a/meta/recipes-devtools/gdb/gdb-cross.inc
+++ b/meta/recipes-devtools/gdb/gdb-cross.inc
@@ -5,7 +5,7 @@  DEPENDS = "expat-native gmp-native mpfr-native ncurses-native flex-native bison-
 inherit python3native pkgconfig
 
 # Overrides PACKAGECONFIG variables in gdb-common.inc
-PACKAGECONFIG ??= "python readline ${@bb.utils.filter('DISTRO_FEATURES', 'debuginfod', d)}"
+PACKAGECONFIG:append = " xz"
 PACKAGECONFIG[python] = "--with-python=${PYTHON},--without-python,python3-native"
 PACKAGECONFIG[readline] = "--with-system-readline,--without-system-readline,readline-native"
 PACKAGECONFIG[debuginfod] = "--with-debuginfod, --without-debuginfod, elfutils-native"