diff mbox series

[v3,1/3] systemd-boot-native: undelete but disable configure and compile tasks

Message ID 20250204141705.1222153-1-mikko.rapeli@linaro.org
State Under Review
Headers show
Series [v3,1/3] systemd-boot-native: undelete but disable configure and compile tasks | expand

Commit Message

Mikko Rapeli Feb. 4, 2025, 2:17 p.m. UTC
The tasks were deleted and do_patch() was run after do_install()
which means that patches applied in SRC_URI were not in the
ukify.py binary installed. Mark the tasks as noexec since
they don't need to do anything.

Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
---
 meta/recipes-core/systemd/systemd-boot-native_257.1.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Richard Purdie Feb. 5, 2025, 12:58 p.m. UTC | #1
On Tue, 2025-02-04 at 16:17 +0200, Mikko Rapeli via
lists.openembedded.org wrote:
> The tasks were deleted and do_patch() was run after do_install()
> which means that patches applied in SRC_URI were not in the
> ukify.py binary installed. Mark the tasks as noexec since
> they don't need to do anything.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---
>  meta/recipes-core/systemd/systemd-boot-native_257.1.bb | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> index 58db408dcf..5b4b63c294 100644
> --- a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> +++ b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> @@ -2,13 +2,12 @@ require systemd.inc
>  
>  inherit native
>  
> -deltask do_configure
> -deltask do_compile
> +do_configure[noexec] = "1"
> +do_compile[noexec] = "1"
>  
>  do_install () {
>         install -Dm 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
>  }
> -addtask install after do_unpack

I'm a little torn on this, we could fix it by changing do_unpack to
do_patch.

Using deltask is slightly more efficient in that it completely removes
a a node on the task graph rather than having it present and running
all the way up to just short of execution.

Cheers,

Richard
Mikko Rapeli Feb. 6, 2025, 7:29 a.m. UTC | #2
Hi,

On Wed, Feb 05, 2025 at 12:58:17PM +0000, Richard Purdie wrote:
> On Tue, 2025-02-04 at 16:17 +0200, Mikko Rapeli via
> lists.openembedded.org wrote:
> > The tasks were deleted and do_patch() was run after do_install()
> > which means that patches applied in SRC_URI were not in the
> > ukify.py binary installed. Mark the tasks as noexec since
> > they don't need to do anything.
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> > ---
> > �meta/recipes-core/systemd/systemd-boot-native_257.1.bb | 5 ++---
> > �1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> > b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> > index 58db408dcf..5b4b63c294 100644
> > --- a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> > +++ b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
> > @@ -2,13 +2,12 @@ require systemd.inc
> > �
> > �inherit native
> > �
> > -deltask do_configure
> > -deltask do_compile
> > +do_configure[noexec] = "1"
> > +do_compile[noexec] = "1"
> > �
> > �do_install () {
> > ������� install -Dm 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
> > �}
> > -addtask install after do_unpack
> 
> I'm a little torn on this, we could fix it by changing do_unpack to
> do_patch.
> 
> Using deltask is slightly more efficient in that it completely removes
> a a node on the task graph rather than having it present and running
> all the way up to just short of execution.

Ok, sending this in v4.

Cheers,

-Mikko
diff mbox series

Patch

diff --git a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
index 58db408dcf..5b4b63c294 100644
--- a/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
+++ b/meta/recipes-core/systemd/systemd-boot-native_257.1.bb
@@ -2,13 +2,12 @@  require systemd.inc
 
 inherit native
 
-deltask do_configure
-deltask do_compile
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
 
 do_install () {
        install -Dm 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
 }
-addtask install after do_unpack
 
 PACKAGES = "${PN}"