diff mbox series

libxkbcommon: replace locale dependecy from RDEPENDS to RRECOMMENDS

Message ID 20250114002503.7321-1-hiagofranco@gmail.com
State New
Headers show
Series libxkbcommon: replace locale dependecy from RDEPENDS to RRECOMMENDS | expand

Commit Message

Hiago De Franco Jan. 14, 2025, 12:25 a.m. UTC
From: Hiago De Franco <hiago.franco@toradex.com>

The error described does not occur in all cases where libxkbcommon is
used. As example, a Qt application that depends on libxkbcommon might
not require any locales to be installed.

Add it to RRECOMMENDS, as libxkbcommon does not seen to have any hard
dependency on libx11-compose-data or libx11-locale. This change can help
users decide to disable it and save some space on the rootfs.

Signed-off-by: Hiago De Franco <hiago.franco@toradex.com>
---
The first version of this patch is at [1], now this patch is different
and changes the RDEPENDS to RRECOMMENDS (the subject is also different),
that is why I did not mark it as V2 on the subject.

[1] https://lore.kernel.org/all/20241212213429.250224-1-hiagofranco@gmail.com/
---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb b/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
index 40cf616f0bd2..d87ff661d9f6 100644
--- a/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
+++ b/meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb
@@ -31,9 +31,9 @@  python populate_packages:prepend () {
     do_split_packages(d, d.expand('${libdir}'), r'^(lib.*)\.so\.*', '%s', '%s library', extra_depends='', allow_links=True)
 }
 
-# Fix a following runtime error:
+# Recommended to fix a possible runtime error:
 # xkbcommon: ERROR: couldn't find a Compose file for locale "C"
-RDEPENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libx11-locale', 'libx11-compose-data', d)}"
+RRECOMMENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libx11-locale', 'libx11-compose-data', d)}"
 
 BBCLASSEXTEND += "native"