diff mbox series

package_rpm: set clamp_mtime_to_source_date_epoch to 0

Message ID 20250103063224.1988264-1-bin.lan.cn@windriver.com
State New
Headers show
Series package_rpm: set clamp_mtime_to_source_date_epoch to 0 | expand

Commit Message

Bin Lan Jan. 3, 2025, 6:32 a.m. UTC
There is the following warning when the do_package_write_rpm task is executed
when bitbake linux-yocto:
  warning: %clamp_mtime_to_source_date_epoch is deprecated, please use %build_mtime_policy

This change sets clamp_mtime_to_source_date_epoch to 0 in do_package_rpm() to remove the warning.

Signed-off-by: Bin Lan <bin.lan.cn@windriver.com>
---
 meta/classes-global/package_rpm.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Jan. 3, 2025, 10:24 a.m. UTC | #1
On Fri, 3 Jan 2025 at 07:32, Bin Lan via lists.openembedded.org
<bin.lan.cn=windriver.com@lists.openembedded.org> wrote:
>   warning: %clamp_mtime_to_source_date_epoch is deprecated, please use %build_mtime_policy
>
> This change sets clamp_mtime_to_source_date_epoch to 0 in do_package_rpm() to remove the warning.

But does this change introduce issues? This was originally set for a
reason, what was the reason? Should it be replaced with
built_mtime_policy as suggested?

> -    cmd = cmd + " --define 'clamp_mtime_to_source_date_epoch 1'"
> +    cmd = cmd + " --define 'clamp_mtime_to_source_date_epoch 0'"

Alex
diff mbox series

Patch

diff --git a/meta/classes-global/package_rpm.bbclass b/meta/classes-global/package_rpm.bbclass
index 3579d0d695..d7b57e301b 100644
--- a/meta/classes-global/package_rpm.bbclass
+++ b/meta/classes-global/package_rpm.bbclass
@@ -699,7 +699,7 @@  python do_package_rpm () {
     cmd = cmd + " --define '_smp_ncpus_max 4'"
     cmd = cmd + " --define '_source_payload %s'" % rpmbuild_compmode
     cmd = cmd + " --define '_binary_payload %s'" % rpmbuild_compmode
-    cmd = cmd + " --define 'clamp_mtime_to_source_date_epoch 1'"
+    cmd = cmd + " --define 'clamp_mtime_to_source_date_epoch 0'"
     cmd = cmd + " --define 'use_source_date_epoch_as_buildtime 1'"
     cmd = cmd + " --define '_buildhost reproducible'"
     cmd = cmd + " --define '__font_provides %{nil}'"