diff mbox series

builder: set CVE_PRODUCT

Message ID 20241124122711.18001-1-peter.marko@siemens.com
State Accepted, archived
Commit fd4ec5a5318b36af0a9a0a097a5b1f1de44a8edf
Headers show
Series builder: set CVE_PRODUCT | expand

Commit Message

Marko, Peter Nov. 24, 2024, 12:27 p.m. UTC 
From: Peter Marko <peter.marko@siemens.com>

Builder is a common word and there are many other builder components
which makes us to ignore CVEs for all of them.
There is already 1 ignored and currently 3 new ones.

Instead, set product to yocto to filter them.

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta/recipes-graphics/builder/builder_0.1.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ross Burton Nov. 25, 2024, 11:30 a.m. UTC | #1 
On 24 Nov 2024, at 12:27, Peter Marko via lists.openembedded.org <peter.marko=siemens.com@lists.openembedded.org> wrote:
> -CVE_STATUS[CVE-2008-4178] = "cpe-incorrect: This CVE is for an unrelated builder"
> +# do not report CVEs for other builder apps
> +CVE_PRODUCT = "yocto:builder"

Please don’t make up vendor names. There are already yocto_project and yoctoproject vendors so let's not add another variation.  Personally, I lean towards yoctoproject.

Ross
Marko, Peter Nov. 25, 2024, 12:09 p.m. UTC | #2 
Hi Ross,

I have realized this and sent v2 with yoctoproject only 10 minutes after sending this patch.
I guess I have forgotten to chain it with --in-reply-to=, sorry for that.

Peter

> -----Original Message-----
> From: Ross Burton <Ross.Burton@arm.com>
> Sent: Monday, November 25, 2024 12:30
> To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH] builder: set CVE_PRODUCT
> 
> On 24 Nov 2024, at 12:27, Peter Marko via lists.openembedded.org
> <peter.marko=siemens.com@lists.openembedded.org> wrote:
> > -CVE_STATUS[CVE-2008-4178] = "cpe-incorrect: This CVE is for an unrelated
> builder"
> > +# do not report CVEs for other builder apps
> > +CVE_PRODUCT = "yocto:builder"
> 
> Please don’t make up vendor names. There are already yocto_project and
> yoctoproject vendors so let's not add another variation.  Personally, I lean
> towards yoctoproject.
> 
> Ross
Ross Burton Nov. 25, 2024, 12:10 p.m. UTC | #3 
On 25 Nov 2024, at 12:09, Marko, Peter <Peter.Marko@siemens.com> wrote:
> 
> Hi Ross,
> 
> I have realized this and sent v2 with yoctoproject only 10 minutes after sending this patch.
> I guess I have forgotten to chain it with --in-reply-to=, sorry for that.

So you did, sorry about that.  Drive-by review over a coffee on a Monday might not be a good idea :)

Ross
diff mbox series

Patch

diff --git a/meta/recipes-graphics/builder/builder_0.1.bb b/meta/recipes-graphics/builder/builder_0.1.bb
index 7719b783c2..c0c271d564 100644
--- a/meta/recipes-graphics/builder/builder_0.1.bb
+++ b/meta/recipes-graphics/builder/builder_0.1.bb
@@ -29,4 +29,5 @@  do_install () {
 	chown  builder.builder ${D}${sysconfdir}/mini_x/session.d/builder_session.sh
 }
 
-CVE_STATUS[CVE-2008-4178] = "cpe-incorrect: This CVE is for an unrelated builder"
+# do not report CVEs for other builder apps
+CVE_PRODUCT = "yocto:builder"