| Message ID | 20241122201557.2247079-1-JPEWhacker@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | lib: sbom30: Prefix aliases with "http://spdx.org/spdxdocs/" | expand |
Hi Joshua, This patch conflicts with '[PATCH V2 1/3] sbom30/spdx30: add link prefix and name to namespace of spdxId and alias '[1], would you have suggestions about review '[RR V2][NULL][0/3] SPDX 3.0: Reduce redundant spdxid-hash symlinks to save inode on host '[2]? Should I rebase my review along with your patch? [1]https://lists.openembedded.org/g/openembedded-core/message/207412?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3ACreated%2C%2C%2C20%2C2%2C0%2C109680229%2Cd%253D4&d=4 [2]https://lists.openembedded.org/g/openembedded-core/topic/109680228#msg207411 //Hongxu
diff --git a/meta/lib/oe/sbom30.py b/meta/lib/oe/sbom30.py index 56cdd7ba4c6..7acb5234db2 100644 --- a/meta/lib/oe/sbom30.py +++ b/meta/lib/oe/sbom30.py @@ -344,7 +344,9 @@ class ObjectSet(oe.spdx30.SHACLObjectSet): alias_ext = set_alias( e, e._id.replace(unihash, "UNIHASH").replace( - namespace, self.d.getVar("PN") + namespace, + "http://spdx.org/spdxdocs/openembedded-alias/" + + self.d.getVar("PN"), ), )
While the SPDX ID aliases are primarily intended for internal use by the SPDX code, they are used in places where a valid SPDX ID is expected. In order to make sure that they still conform to this, prefix them with "http://spdx.org/spdxdocs/openembedded-alias" Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> --- meta/lib/oe/sbom30.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)