| Message ID | 20241115124115.14318-1-mail2szahir@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [master,V2] alsa-lib: enabling ptest for alsa-lib component | expand |
Hi Team, Could someone review the changes and integrate them into the master branch? Please let me know if you need any clarification from our side. Thanks! Zahir.
On Mon, Dec 02, 2024 at 08:36:34AM -0800, aszh07 via lists.openembedded.org wrote: > Hi Team, > > Could someone review the changes and integrate them into the master branch? > > Please let me know if you need any clarification from our side. > > Thanks! > Zahir. Hi Zahir, Thanks for your patch, it looks like I missed it previously. I tried to pick it in my branch, but the alsa-lib ptests are failing: WARNING: core-image-ptest-alsa-lib-1.0-r0 do_testimage: There were failing ptests. Traceback (most recent call last): File "/srv/pokybuild/yocto-worker/qemux86-64-ptest/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs) File "/srv/pokybuild/yocto-worker/qemux86-64-ptest/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs) File "/srv/pokybuild/yocto-worker/qemux86-64-ptest/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f return func(*args, **kwargs) File "/srv/pokybuild/yocto-worker/qemux86-64-ptest/build/meta/lib/oeqa/runtime/cases/ptest.py", line 27, in test_ptestrunner_expectfail self.do_ptestrunner() File "/srv/pokybuild/yocto-worker/qemux86-64-ptest/build/meta/lib/oeqa/runtime/cases/ptest.py", line 120, in do_ptestrunner self.fail(failmsg) AssertionError: Failed ptests: {'alsa-lib': 'START: ptest-runner\n' ... https://valkyrie.yoctoproject.org/#/builders/73/builds/504/steps/12/logs/stdio https://valkyrie.yoctoproject.org/#/builders/61/builds/504/steps/12/logs/stdio Details of failing tests can be found here: https://valkyrie.yocto.io/pub/non-release/20241202-101/testresults/qemux86-64-ptest/core-image-ptest-alsa-lib/ https://valkyrie.yocto.io/pub/non-release/20241202-101/testresults/qemuarm64-ptest/core-image-ptest-alsa-lib/ Can you look at this issue, please ?
diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc index 4a48188562..f0ffe11347 100644 --- a/meta/conf/distro/include/ptest-packagelists.inc +++ b/meta/conf/distro/include/ptest-packagelists.inc @@ -5,6 +5,7 @@ # PTESTS_FAST = "\ acl \ + alsa-lib \ apr-util \ attr \ babeltrace \ diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-remove-check_TESTS-from-automake.patch b/meta/recipes-multimedia/alsa/alsa-lib/0001-remove-check_TESTS-from-automake.patch new file mode 100644 index 0000000000..9ef3021cc3 --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-remove-check_TESTS-from-automake.patch @@ -0,0 +1,27 @@ +From 4afdc83b4069a4505c5928577321eef8097e5258 Mon Sep 17 00:00:00 2001 +From: Zahir Hussain <zahir.basha@kpit.com> +Date: Mon, 11 Nov 2024 22:08:33 +0530 +Subject: [PATCH] remove check_TESTS from automake + +Upstream-Status: Inappropriate [Project-Specific] + +Signed-off-by: Zahir Hussain <zahir.basha@kpit.com> +--- + test/lsb/Makefile.am | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/test/lsb/Makefile.am b/test/lsb/Makefile.am +index ceb4d71..c537bf0 100644 +--- a/test/lsb/Makefile.am ++++ b/test/lsb/Makefile.am +@@ -1,6 +1,4 @@ +-TESTS = config +-TESTS += midi_event +-check_PROGRAMS = $(TESTS) ++check_PROGRAMS = config midi_event + noinst_HEADERS = test.h + + AM_CFLAGS = -Wall -pipe +-- +2.25.1 + diff --git a/meta/recipes-multimedia/alsa/alsa-lib/run-ptest b/meta/recipes-multimedia/alsa/alsa-lib/run-ptest new file mode 100644 index 0000000000..dad94c23df --- /dev/null +++ b/meta/recipes-multimedia/alsa/alsa-lib/run-ptest @@ -0,0 +1,17 @@ +#!/bin/sh + +set -eux + +for t in *; do + if [ -f "$t" ] && [ -x "$t" ] && [ "$t" != "run-ptest" ]; then + if "./$t" > "alsa-lib_$t.log" 2>&1; then + echo "PASS: $t" + else + echo "FAIL: $t - Log" + cat "alsa-lib_$t.log" + fi + else + echo "SKIP: $t (Not executable or not a file)" + fi +done + diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.2.12.bb b/meta/recipes-multimedia/alsa/alsa-lib_1.2.12.bb index d9136052b7..da743a243b 100644 --- a/meta/recipes-multimedia/alsa/alsa-lib_1.2.12.bb +++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.12.bb @@ -9,10 +9,13 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \ file://src/socket.c;md5=285675b45e83f571c6a957fe4ab79c93;beginline=9;endline=24 \ " -SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2" +SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2 \ + file://run-ptest \ + file://0001-remove-check_TESTS-from-automake.patch \ + " SRC_URI[sha256sum] = "4868cd908627279da5a634f468701625be8cc251d84262c7e5b6a218391ad0d2" -inherit autotools pkgconfig +inherit autotools pkgconfig ptest EXTRA_OECONF += " \ ${@bb.utils.contains('TARGET_FPU', 'soft', '--with-softfloat', '', d)} \ @@ -42,3 +45,12 @@ RREPLACES:alsa-conf = "alsa-conf-base" RCONFLICTS:alsa-conf = "alsa-conf-base" BBCLASSEXTEND = "native nativesdk" + +do_compile_ptest() { + oe_runmake check +} + +do_install_ptest:append() { + install -m 0755 ${B}/test/.libs/* "${D}${PTEST_PATH}"; + install -m 0755 ${B}/test/lsb/.libs/* "${D}${PTEST_PATH}"; +}
These changes enable ptest for alsa-lib. 1) Removes the test suite execution 'make check-TESTS' call using patch file. 2) Compiled the test directory source code using "oe_runmake check" command. 3) Copied all the required binaries into PTEST_PATH using do_install_ptest() function. runqemu test result: 10/19 binaries are failing due to not getting PCM device handle. those are, chmap, midiloop, pcm-multi-thread, timer, user-ctl-element-set, audio_time, pcm_min, queue_timer, playmidi, oldapi. Below 9 binaries are passed on runqemu ptest, config, midi_event, rawmidi, control, pcm, client_event_filter,latency,namehint,seq Signed-off-by: aszh07 <mail2szahir@gmail.com> --- .../distro/include/ptest-packagelists.inc | 1 + ...001-remove-check_TESTS-from-automake.patch | 27 +++++++++++++++++++ .../alsa/alsa-lib/run-ptest | 17 ++++++++++++ .../alsa/alsa-lib_1.2.12.bb | 16 +++++++++-- 4 files changed, 59 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-remove-check_TESTS-from-automake.patch create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/run-ptest