diff mbox series

gdk-pixbuf: enable other loaders by default

Message ID 20241111120212.173440-1-changqing.li@windriver.com
State New
Headers show
Series gdk-pixbuf: enable other loaders by default | expand

Commit Message

Changqing Li Nov. 11, 2024, 12:02 p.m. UTC
From: Changqing Li <changqing.li@windriver.com>

Refer [1], upstream gdk-pixbuf disable some loaders by default from
2.42.11, this makes some format of icons not works well after upgrade
gdk-pixbuf, report error like:
matchbox-deskto[501]: Error loading icon: Failed to load /usr/share/pixmaps/xinput_calibrator.xpm: Unrecognized image file format

Fixed the same as some other sdks and arch linux, enable
these loaders by default, refer [2][3][4]

[1] https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/e052a112075a19fb75f1f2ff3de4c82923de13f2
[2] https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/846
[3] https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/3ab7810255c64ce8aa2ae3ac10250148588ab49b
[4] https://gitlab.archlinux.org/archlinux/packaging/packages/gdk-pixbuf2/-/commit/4fa2d98a197781354b66a9710c9d596d502c961b

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexander Kanavin Nov. 11, 2024, 12:05 p.m. UTC | #1
This should be a PACKAGECONFIG option.

Alex

On Mon, 11 Nov 2024 at 13:02, Changqing Li via lists.openembedded.org
<changqing.li=windriver.com@lists.openembedded.org> wrote:
>
> From: Changqing Li <changqing.li@windriver.com>
>
> Refer [1], upstream gdk-pixbuf disable some loaders by default from
> 2.42.11, this makes some format of icons not works well after upgrade
> gdk-pixbuf, report error like:
> matchbox-deskto[501]: Error loading icon: Failed to load /usr/share/pixmaps/xinput_calibrator.xpm: Unrecognized image file format
>
> Fixed the same as some other sdks and arch linux, enable
> these loaders by default, refer [2][3][4]
>
> [1] https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/e052a112075a19fb75f1f2ff3de4c82923de13f2
> [2] https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/846
> [3] https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/3ab7810255c64ce8aa2ae3ac10250148588ab49b
> [4] https://gitlab.archlinux.org/archlinux/packaging/packages/gdk-pixbuf2/-/commit/4fa2d98a197781354b66a9710c9d596d502c961b
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
> index 9f825a68ef..e48589dcd1 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
> @@ -43,7 +43,7 @@ PACKAGECONFIG[jpeg] = "-Djpeg=enabled,-Djpeg=disabled,jpeg"
>  PACKAGECONFIG[tiff] = "-Dtiff=enabled,-Dtiff=disabled,tiff"
>  PACKAGECONFIG[tests] = "-Dinstalled_tests=true,-Dinstalled_tests=false"
>
> -EXTRA_OEMESON = "-Dman=false"
> +EXTRA_OEMESON = "-Dman=false -Dothers=enabled"
>
>  PACKAGES =+ "${PN}-xlib"
>
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#206948): https://lists.openembedded.org/g/openembedded-core/message/206948
> Mute This Topic: https://lists.openembedded.org/mt/109513172/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Changqing Li Nov. 12, 2024, 3:16 a.m. UTC | #2
On 11/11/24 20:05, Alexander Kanavin wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> This should be a PACKAGECONFIG option.
>
> Alex

Hi,

V2 patch is sent.

Thanks

Changqing

> On Mon, 11 Nov 2024 at 13:02, Changqing Li via lists.openembedded.org
> <changqing.li=windriver.com@lists.openembedded.org>  wrote:
>> From: Changqing Li<changqing.li@windriver.com>
>>
>> Refer [1], upstream gdk-pixbuf disable some loaders by default from
>> 2.42.11, this makes some format of icons not works well after upgrade
>> gdk-pixbuf, report error like:
>> matchbox-deskto[501]: Error loading icon: Failed to load /usr/share/pixmaps/xinput_calibrator.xpm: Unrecognized image file format
>>
>> Fixed the same as some other sdks and arch linux, enable
>> these loaders by default, refer [2][3][4]
>>
>> [1]https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/commit/e052a112075a19fb75f1f2ff3de4c82923de13f2
>> [2]https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/846
>> [3]https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/commit/3ab7810255c64ce8aa2ae3ac10250148588ab49b
>> [4]https://gitlab.archlinux.org/archlinux/packaging/packages/gdk-pixbuf2/-/commit/4fa2d98a197781354b66a9710c9d596d502c961b
>>
>> Signed-off-by: Changqing Li<changqing.li@windriver.com>
>> ---
>>   meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
>> index 9f825a68ef..e48589dcd1 100644
>> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
>> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
>> @@ -43,7 +43,7 @@ PACKAGECONFIG[jpeg] = "-Djpeg=enabled,-Djpeg=disabled,jpeg"
>>   PACKAGECONFIG[tiff] = "-Dtiff=enabled,-Dtiff=disabled,tiff"
>>   PACKAGECONFIG[tests] = "-Dinstalled_tests=true,-Dinstalled_tests=false"
>>
>> -EXTRA_OEMESON = "-Dman=false"
>> +EXTRA_OEMESON = "-Dman=false -Dothers=enabled"
>>
>>   PACKAGES =+ "${PN}-xlib"
>>
>> --
>> 2.25.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#206948):https://lists.openembedded.org/g/openembedded-core/message/206948
>> Mute This Topic:https://lists.openembedded.org/mt/109513172/1686489
>> Group Owner:openembedded-core+owner@lists.openembedded.org
>> Unsubscribe:https://lists.openembedded.org/g/openembedded-core/unsub  [alex.kanavin@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
index 9f825a68ef..e48589dcd1 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.42.12.bb
@@ -43,7 +43,7 @@  PACKAGECONFIG[jpeg] = "-Djpeg=enabled,-Djpeg=disabled,jpeg"
 PACKAGECONFIG[tiff] = "-Dtiff=enabled,-Dtiff=disabled,tiff"
 PACKAGECONFIG[tests] = "-Dinstalled_tests=true,-Dinstalled_tests=false"
 
-EXTRA_OEMESON = "-Dman=false"
+EXTRA_OEMESON = "-Dman=false -Dothers=enabled"
 
 PACKAGES =+ "${PN}-xlib"