| Message ID | 20241107172404.4017047-1-ross.burton@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/8] python3-setuptools: add more comments to a patch | expand |
On Thu, Nov 07, 2024 at 05:23:57PM +0000, Ross Burton wrote: > Add more explanatory comments, including when we can drop the patch. > > Signed-off-by: Ross Burton <ross.burton@arm.com> Hi Ross, Thanks for the v2, but I suspect it is still responsible for some failures on the autobuilder. First we have some reproducibility issues on numpy. (Issues on piglit are probably linked to the build fail described below). AssertionError: Bitbake reproducibleA failure The following deb packages are different and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/python3-numpy-dbg_1.26.4-r0_amd64.deb /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/python3-numpy_1.26.4-r0_amd64.deb The following deb packages are missing and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/piglit-bash-completion_1.0+gitr0+c11c9374c1-r0_amd64.deb /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/piglit-dbg_1.0+gitr0+c11c9374c1-r0_amd64.deb /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/piglit-dev_1.0+gitr0+c11c9374c1-r0_amd64.deb /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/piglit-doc_1.0+gitr0+c11c9374c1-r0_amd64.deb /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./core2-64/piglit_1.0+gitr0+c11c9374c1-r0_amd64.deb The following ipk packages are different and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/python3-numpy-dbg_1.26.4-r0_core2-64.ipk /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/python3-numpy_1.26.4-r0_core2-64.ipk The following ipk packages are missing and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/piglit-bash-completion_1.0+gitr0+c11c9374c1-r0_core2-64.ipk /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/piglit-dbg_1.0+gitr0+c11c9374c1-r0_core2-64.ipk /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/piglit-dev_1.0+gitr0+c11c9374c1-r0_core2-64.ipk /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/piglit-doc_1.0+gitr0+c11c9374c1-r0_core2-64.ipk /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./core2-64/piglit_1.0+gitr0+c11c9374c1-r0_core2-64.ipk The following rpm packages are different and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/python3-numpy-1.26.4-r0.core2_64.rpm /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/python3-numpy-dbg-1.26.4-r0.core2_64.rpm The following rpm packages are missing and not in exclusion list: /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/piglit-1.0+gitr0+c11c9374c1-r0.core2_64.rpm /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/piglit-bash-completion-1.0+gitr0+c11c9374c1-r0.core2_64.rpm /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/piglit-dbg-1.0+gitr0+c11c9374c1-r0.core2_64.rpm /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/piglit-dev-1.0+gitr0+c11c9374c1-r0.core2_64.rpm /srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./core2_64/piglit-doc-1.0+gitr0+c11c9374c1-r0.core2_64.rpm https://valkyrie.yoctoproject.org/#/builders/37/builds/421/steps/13/logs/stdio Diffoscope output can be found here: https://valkyrie.yocto.io/pub/repro-fail/oe-reproducible-20241108-wkf8tasz/packages/ There is also a build error on piglit. I'm not sure but I suspect this is also caused by these patches, as piglit depends on numpy. I will confirm this with a new build today. | CMake Error at /srv/pokybuild/yocto-worker/qemux86-world/build/build/tmp/work/core2-64-poky-linux/piglit/1.0+gitr/recipe-sysroot-native/usr/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message): | Could NOT find PythonNumpy (missing: PythonNumpy_STATUS) (Required is at | least version "1.7.0") https://valkyrie.yoctoproject.org/#/builders/59/builds/399/steps/11/logs/stdio Can you have a look at these issues please ?
On 8 Nov 2024, at 10:16, Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> wrote: > > On Thu, Nov 07, 2024 at 05:23:57PM +0000, Ross Burton wrote: >> Add more explanatory comments, including when we can drop the patch. >> >> Signed-off-by: Ross Burton <ross.burton@arm.com> > > Hi Ross, > > Thanks for the v2, but I suspect it is still responsible for some > failures on the autobuilder. I just pulled out the parallel/out-of-tree changes and sent v3 with just the cython changes, which are the important ones. I’ll glare at setuptools harder, later. Sorry about this. I just verified that qemux86-world built piglit fine for me with this branch: https://valkyrie.yoctoproject.org/#/builders/59/builds/401 and I hope the reproducibility thing is due to ordering changes thanks to the parallelism. Ross
diff --git a/meta/recipes-devtools/python/python3-setuptools/0001-conditionally-do-not-fetch-code-by-easy_install.patch b/meta/recipes-devtools/python/python3-setuptools/0001-conditionally-do-not-fetch-code-by-easy_install.patch index e227c2889cf..16b316e9cc2 100644 --- a/meta/recipes-devtools/python/python3-setuptools/0001-conditionally-do-not-fetch-code-by-easy_install.patch +++ b/meta/recipes-devtools/python/python3-setuptools/0001-conditionally-do-not-fetch-code-by-easy_install.patch @@ -3,11 +3,13 @@ From: Hongxu Jia <hongxu.jia@windriver.com> Date: Tue, 17 Jul 2018 10:13:38 +0800 Subject: [PATCH] conditionally do not fetch code by easy_install -If var-NO_FETCH_BUILD is set, do not allow to fetch code from -internet by easy_install. +If NO_FETCH_BUILD is set, do not fetch code in easy_install. This avoids setup.py +trying to fetch missing dependencies at build time. -Upstream-Status: Inappropriate [oe specific] +This is only used by the deprecated codepath as implemented by setuptools3.bbclass, so +when that ever gets removed this patch can also be deleted. +Upstream-Status: Denied [https://github.com/pypa/setuptools/issues/4735] Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> --- setuptools/command/easy_install.py | 5 +++++
Add more explanatory comments, including when we can drop the patch. Signed-off-by: Ross Burton <ross.burton@arm.com> --- ...-conditionally-do-not-fetch-code-by-easy_install.patch | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)