diff mbox series

[2/2] oeqa/selftest/cases/buildoptions.py: ensure libgfortran's package_qa is run

Message ID 20241018083135.3643966-2-Qi.Chen@windriver.com
State Under Review
Headers show
Series [1/2] libgfortran: fix buildpath QA issue | expand

Commit Message

ChenQi Oct. 18, 2024, 8:31 a.m. UTC
From: Chen Qi <Qi.Chen@windriver.com>

fortran-helloworld DEPENDS on libgfortran, so merely 'bitbake fortran-helloworld'
does not ensure that libgfortran's package_qa is run. This actually covers
the buildpath issue in libgfortran. This patch ensures that libgfortran's package_qa
is run to avoid any future regression.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/lib/oeqa/selftest/cases/buildoptions.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Richard Purdie Oct. 23, 2024, 11:51 a.m. UTC | #1
On Fri, 2024-10-18 at 01:31 -0700, Chen Qi via lists.openembedded.org wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> fortran-helloworld DEPENDS on libgfortran, so merely 'bitbake fortran-helloworld'
> does not ensure that libgfortran's package_qa is run. This actually covers
> the buildpath issue in libgfortran. This patch ensures that libgfortran's package_qa
> is run to avoid any future regression.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/lib/oeqa/selftest/cases/buildoptions.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/buildoptions.py b/meta/lib/oeqa/selftest/cases/buildoptions.py
> index 423c31e189..4e82c34de9 100644
> --- a/meta/lib/oeqa/selftest/cases/buildoptions.py
> +++ b/meta/lib/oeqa/selftest/cases/buildoptions.py
> @@ -203,7 +203,7 @@ class ToolchainOptions(OESelftestTestCase):
>  
>          features = 'FORTRAN:forcevariable = ",fortran"\n'
>          self.write_config(features)
> -        bitbake('fortran-helloworld')
> +        bitbake('libgfortran fortran-helloworld')
>  
>  @OETestTag("yocto-mirrors")
>  class SourceMirroring(OESelftestTestCase):

I took the first patch but this second one made me worry about our task
dependencies. I've looked into it and I think there is a bigger issue.
I've sent an alternative one to insane.bbclass which should mean this
is unneeded. If you could double check that would be great.

Thanks,

Richard
diff mbox series

Patch

diff --git a/meta/lib/oeqa/selftest/cases/buildoptions.py b/meta/lib/oeqa/selftest/cases/buildoptions.py
index 423c31e189..4e82c34de9 100644
--- a/meta/lib/oeqa/selftest/cases/buildoptions.py
+++ b/meta/lib/oeqa/selftest/cases/buildoptions.py
@@ -203,7 +203,7 @@  class ToolchainOptions(OESelftestTestCase):
 
         features = 'FORTRAN:forcevariable = ",fortran"\n'
         self.write_config(features)
-        bitbake('fortran-helloworld')
+        bitbake('libgfortran fortran-helloworld')
 
 @OETestTag("yocto-mirrors")
 class SourceMirroring(OESelftestTestCase):