| Message ID | 20241016101442.1566155-1-alban.bedel@aerq.com |
|---|---|
| State | New |
| Headers | show |
| Series | bluez5: Fix the files installed in the obex package | expand |
Hi Alban, On 10/16/24 12:14 PM, Alban Bedel via lists.openembedded.org wrote: > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#205960): https://lists.openembedded.org/g/openembedded-core/message/205960 > Mute This Topic: https://lists.openembedded.org/mt/109041163/6293953 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [quentin.schulz@cherry.de] > -=-=-=-=-=-=-=-=-=-=-=- > The above is the entirety of the mail I have received from you (same for your other patch for util-linux). This will drastically lower your chances of having reviews or even the patches merged. It seems like you did send something, c.f. https://lore.kernel.org/openembedded-core/20241016080520.1532567-1-alban.bedel@aerq.com/T/#u but the patch appears to be an attachment, rather than the body of the mail like expected. Is there something you could fix there so we get the patch as content of the mail and not an attachment? If you figure out what the issue is, could you let us know, maybe there's something we can add to https://docs.yoctoproject.org/contributor-guide/submit-changes.html#sending-the-patches-via-email for example! Cheers, Quentin
On Wed, 2024-10-16 at 13:52 +0200, Quentin Schulz via lists.openembedded.org wrote: > Hi Alban, > > On 10/16/24 12:14 PM, Alban Bedel via lists.openembedded.org wrote: > > > > > > > > > > The above is the entirety of the mail I have received from you (same for > your other patch for util-linux). This will drastically lower your > chances of having reviews or even the patches merged. > > It seems like you did send something, c.f. > https://lore.kernel.org/openembedded-core/20241016080520.1532567-1-alban.bedel@aerq.com/T/#u > > but the patch appears to be an attachment, rather than the body of the > mail like expected. Is there something you could fix there so we get the > patch as content of the mail and not an attachment? > > If you figure out what the issue is, could you let us know, maybe > there's something we can add to > https://docs.yoctoproject.org/contributor-guide/submit-changes.html#sending-the-patches-via-email > > for example! > Thanks for the info, strangle the version I got from the CC is fine. I'm using `git send-email` but I have to use the office365 SMTP server which seems to mangle my email :( I will investigate and resend the patches. Alban
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc index b3bcd278e626..34115626bf01 100644 --- a/meta/recipes-connectivity/bluez5/bluez5.inc +++ b/meta/recipes-connectivity/bluez5/bluez5.inc @@ -130,11 +130,9 @@ FILES:${PN}-dev += " \ " FILES:${PN}-obex = "${libexecdir}/bluetooth/obexd \ - ${exec_prefix}/lib/systemd/user/obex.service \ - ${systemd_system_unitdir}/obex.service \ - ${sysconfdir}/systemd/system/multi-user.target.wants/obex.service \ + ${systemd_user_unitdir}/obex.service \ + ${systemd_user_unitdir}/dbus-org.bluez.obex.service \ ${datadir}/dbus-1/services/org.bluez.obex.service \ - ${sysconfdir}/dbus-1/system.d/obexd.conf \ " SYSTEMD_SERVICE:${PN}-obex = "obex.service"
The obex package is missing the `dbus-org.bluez.obex.service` symlink which then ends up in the main package. While at it also make use of the `${systemd_user_unitdir}` variable for systemd user services and remove dead entries. Signed-off-by: Alban Bedel <alban.bedel@aerq.com> --- meta/recipes-connectivity/bluez5/bluez5.inc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)