diff mbox series

[v2,02/11] ffmpeg: no need for textrel INSANE_SKIP

Message ID 20241010160623.2880937-2-ross.burton@arm.com
State Accepted, archived
Commit 98d577fef75d54a59eeacaabb4a45e44b2f6832e
Headers show
Series [v2,01/11] ffmpeg: nasm is x86 only, so only DEPEND if x86 | expand

Commit Message

Ross Burton Oct. 10, 2024, 4:06 p.m. UTC
It appears in testing that modern ffmpeg no longer needs to disable PIC,
so there's no need to ignore textrel warnings.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Khem Raj Oct. 12, 2024, 8:40 p.m. UTC | #1
The textrels still occur on qemux86 when using clang+lld

https://errors.yoctoproject.org/Errors/Details/809513/


On Thu, Oct 10, 2024 at 9:06 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:
>
> It appears in testing that modern ffmpeg no longer needs to disable PIC,
> so there's no need to ignore textrel warnings.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
> index b16bd51dbd7..af66104ebf3 100644
> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
> @@ -181,13 +181,3 @@ FILES:libpostproc = "${libdir}/libpostproc${SOLIBS}"
>  FILES:libswresample = "${libdir}/libswresample${SOLIBS}"
>  FILES:libswscale = "${libdir}/libswscale${SOLIBS}"
>  FILES:${PN}-examples = "${datadir}/${PN}/examples"
> -
> -# ffmpeg disables PIC on some platforms (e.g. x86-32)
> -INSANE_SKIP:${MLPREFIX}libavcodec = "textrel"
> -INSANE_SKIP:${MLPREFIX}libavdevice = "textrel"
> -INSANE_SKIP:${MLPREFIX}libavfilter = "textrel"
> -INSANE_SKIP:${MLPREFIX}libavformat = "textrel"
> -INSANE_SKIP:${MLPREFIX}libavutil = "textrel"
> -INSANE_SKIP:${MLPREFIX}libswscale = "textrel"
> -INSANE_SKIP:${MLPREFIX}libswresample = "textrel"
> -INSANE_SKIP:${MLPREFIX}libpostproc = "textrel"
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#205411): https://lists.openembedded.org/g/openembedded-core/message/205411
> Mute This Topic: https://lists.openembedded.org/mt/108932124/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
index b16bd51dbd7..af66104ebf3 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_7.0.2.bb
@@ -181,13 +181,3 @@  FILES:libpostproc = "${libdir}/libpostproc${SOLIBS}"
 FILES:libswresample = "${libdir}/libswresample${SOLIBS}"
 FILES:libswscale = "${libdir}/libswscale${SOLIBS}"
 FILES:${PN}-examples = "${datadir}/${PN}/examples"
-
-# ffmpeg disables PIC on some platforms (e.g. x86-32)
-INSANE_SKIP:${MLPREFIX}libavcodec = "textrel"
-INSANE_SKIP:${MLPREFIX}libavdevice = "textrel"
-INSANE_SKIP:${MLPREFIX}libavfilter = "textrel"
-INSANE_SKIP:${MLPREFIX}libavformat = "textrel"
-INSANE_SKIP:${MLPREFIX}libavutil = "textrel"
-INSANE_SKIP:${MLPREFIX}libswscale = "textrel"
-INSANE_SKIP:${MLPREFIX}libswresample = "textrel"
-INSANE_SKIP:${MLPREFIX}libpostproc = "textrel"