diff mbox series

kmscube: Upgrade to latest revision

Message ID 20240927105333.52805-1-purushottam27.kumar@lge.com
State Under Review
Headers show
Series kmscube: Upgrade to latest revision | expand

Commit Message

Purushottam Choudhary Sept. 27, 2024, 10:53 a.m. UTC
Upgrade to the latest kmscube revision.

Signed-off-by: Purushottam Choudhary <purushottam27.kumar@lge.com>
---
 meta/recipes-graphics/kmscube/kmscube_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Quentin Schulz Sept. 27, 2024, 11:18 a.m. UTC | #1
Hi,

On 9/27/24 12:53 PM, Purushottam Choudhary via lists.openembedded.org wrote:
> [You don't often get email from purushottam27.kumar=lge.com@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> Upgrade to the latest kmscube revision.
> 
> Signed-off-by: Purushottam Choudhary <purushottam27.kumar@lge.com>
> ---
>   meta/recipes-graphics/kmscube/kmscube_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/kmscube/kmscube_git.bb b/meta/recipes-graphics/kmscube/kmscube_git.bb
> index 34d5a7d71d..01ea80a142 100644
> --- a/meta/recipes-graphics/kmscube/kmscube_git.bb
> +++ b/meta/recipes-graphics/kmscube/kmscube_git.bb
> @@ -10,7 +10,7 @@ DEPENDS = "virtual/libgles3 virtual/libgles2 virtual/egl libdrm virtual/libgbm"
> 
>   LIC_FILES_CHKSUM = "file://kmscube.c;beginline=1;endline=23;md5=8b309d4ee67b7315ff7381270dd631fb"
> 
> -SRCREV = "467e86c5cbeb2a2051b31ce2c240d6ddf5bc3112"
> +SRCREV = "b2f97f53e01e07a920761e5d3e3ba22898b794a4"

This seems to bump the gstreamer dependency requirement to 1.22.0 and 
later, which is only supported on mickledore and later so backporting 
(if there is) should only go to scarthgap and not kirkstone.

We may want to do the backporting, c.f.:
https://gitlab.freedesktop.org/mesa/kmscube/-/commit/4961a04b4a434aefbd412eb24fb76998036eaaf6

"""
This solves negotiation issues encountered with V4L2 stateless hardware
video decoders when using kmscube video playback option.
"""

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Quentin Schulz Sept. 27, 2024, 2:25 p.m. UTC | #2
Hi Purushottam,

On 9/27/24 4:17 PM, Purushottam Kumar wrote:
> Hi,
> 
> Thanks for the quick response.
> Yes, for kirkstone branch need a separate commit but there gstreamer version is
> 1.20.7.
> Please ignore this patch i will share specific change commit for kmscube for
> master and kirskstone.
> 

I think this patch is fine for master and scarthgap? Is ther

For kirkstone, we probably want to bump + revert the patch that 
introduces a dependency version we cannot meet, or simply backport only 
the patches you're interested in in kirkstone?

Cheers,
Quentin
diff mbox series

Patch

diff --git a/meta/recipes-graphics/kmscube/kmscube_git.bb b/meta/recipes-graphics/kmscube/kmscube_git.bb
index 34d5a7d71d..01ea80a142 100644
--- a/meta/recipes-graphics/kmscube/kmscube_git.bb
+++ b/meta/recipes-graphics/kmscube/kmscube_git.bb
@@ -10,7 +10,7 @@  DEPENDS = "virtual/libgles3 virtual/libgles2 virtual/egl libdrm virtual/libgbm"
 
 LIC_FILES_CHKSUM = "file://kmscube.c;beginline=1;endline=23;md5=8b309d4ee67b7315ff7381270dd631fb"
 
-SRCREV = "467e86c5cbeb2a2051b31ce2c240d6ddf5bc3112"
+SRCREV = "b2f97f53e01e07a920761e5d3e3ba22898b794a4"
 SRC_URI = "git://gitlab.freedesktop.org/mesa/kmscube;branch=master;protocol=https \
            file://0001-cube-gears-Change-header-file-to-GLES3-gl3.h.patch \
            "