diff mbox series

[v5,2/2] nativesdk-packagegroup-sdk-host: Add missing perl modules to RDEPENDS

Message ID 20240919124848.653457-2-Harish.Sadineni@windriver.com
State New
Headers show
Series [v5,1/2] binutils: Fix packaging of bfd-plugins | expand

Commit Message

Sadineni, Harish Sept. 19, 2024, 12:48 p.m. UTC
From: Harish Sadineni <Harish.Sadineni@windriver.com>

In SDK, missing perl modules causes 'x86_64-pokysdk-linux-gp-display-html --help' to abort with below errors..
  - Can't locate bignum.pm in @INC (you may need to install the feature module).
  - Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)

By adding the following perl modules to RDEPENDS fixes the above errors:
  nativesdk-perl-module-bignum
  nativesdk-perl-module-bigint
  nativesdk-perl-module-math-bigint

Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
---
 meta/recipes-devtools/binutils/binutils_2.43.1.bb | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Richard Purdie Sept. 19, 2024, 8:43 p.m. UTC | #1
On Thu, 2024-09-19 at 05:48 -0700, Sadineni, Harish via lists.openembedded.org wrote:
> From: Harish Sadineni <Harish.Sadineni@windriver.com>
> 
> In SDK, missing perl modules causes 'x86_64-pokysdk-linux-gp-display-html --help' to abort with below errors..
>   - Can't locate bignum.pm in @INC (you may need to install the feature module).
>   - Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)
> 
> By adding the following perl modules to RDEPENDS fixes the above errors:
>   nativesdk-perl-module-bignum
>   nativesdk-perl-module-bigint
>   nativesdk-perl-module-math-bigint
> 
> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
> ---
>  meta/recipes-devtools/binutils/binutils_2.43.1.bb | 4 ++++
>  1 file changed, 4 insertions(+)

You've updated the commit to do what is needed whic is great, thanks.

Unfortunately the shortlog is now incorrect though. It should now read:

"binutils: Add missing perl modules to RDEPENDS for nativsdk variant"

The patch also fails to apply as I can't take 1/2 for other reasons as
discussed. I'm going to tweak the patch locally for testing though on
this occasion.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/recipes-devtools/binutils/binutils_2.43.1.bb b/meta/recipes-devtools/binutils/binutils_2.43.1.bb
index eb7c16cbc4..44cd17bc78 100644
--- a/meta/recipes-devtools/binutils/binutils_2.43.1.bb
+++ b/meta/recipes-devtools/binutils/binutils_2.43.1.bb
@@ -73,5 +73,9 @@  SRC_URI:append:class-nativesdk =  " file://0003-binutils-nativesdk-Search-for-al
 USE_ALTERNATIVES_FOR:class-nativesdk = ""
 FILES:${PN}:append:class-nativesdk = " ${bindir}"
 FILES:${PN}:append:class-nativesdk = " ${libdir}/bfd-plugins"
+RDEPENDS:gprofng:class-nativesdk = " nativesdk-perl-module-bignum \
+                                     nativesdk-perl-module-bigint \
+                                     nativesdk-perl-module-math-bigint \
+"
 
 BBCLASSEXTEND = "native nativesdk"