diff mbox series

[v4,2/2] nativesdk-packagegroup-sdk-host: Add missing perl modules to RDEPENDS

Message ID 20240919094231.3840077-2-Harish.Sadineni@windriver.com
State New
Headers show
Series [v4,1/2] binutils: Fix packaging of bfd-plugins | expand

Commit Message

Sadineni, Harish Sept. 19, 2024, 9:42 a.m. UTC
From: Harish Sadineni <Harish.Sadineni@windriver.com>

In SDK, missing perl modules causes 'x86_64-pokysdk-linux-gp-display-html --help' to abort with below errors..
  - Can't locate bignum.pm in @INC (you may need to install the feature module).
  - Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)

By adding the following perl modules to RDEPENDS fixes the above errors:
  nativesdk-perl-module-bignum
  nativesdk-perl-module-bigint
  nativesdk-perl-module-math-bigint

Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
---
 .../packagegroups/nativesdk-packagegroup-sdk-host.bb           | 3 +++
 1 file changed, 3 insertions(+)

Comments

Richard Purdie Sept. 19, 2024, 10:05 a.m. UTC | #1
On Thu, 2024-09-19 at 02:42 -0700, Sadineni, Harish via lists.openembedded.org wrote:
> From: Harish Sadineni <Harish.Sadineni@windriver.com>
> 
> In SDK, missing perl modules causes 'x86_64-pokysdk-linux-gp-display-html --help' to abort with below errors..
>   - Can't locate bignum.pm in @INC (you may need to install the feature module).
>   - Can't locate Math/BigInt.pm in @INC (you may need to install the Math::BigInt module)
> 
> By adding the following perl modules to RDEPENDS fixes the above errors:
>   nativesdk-perl-module-bignum
>   nativesdk-perl-module-bigint
>   nativesdk-perl-module-math-bigint
> 
> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
> ---
>  .../packagegroups/nativesdk-packagegroup-sdk-host.bb           | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> index c1d3c25060..70a7d3e494 100644
> --- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> +++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
> @@ -30,6 +30,9 @@ RDEPENDS:${PN} = "\
>      nativesdk-bison \
>      nativesdk-flex \
>      nativesdk-perl-module-integer \
> +    nativesdk-perl-module-bignum  \
> +    nativesdk-perl-module-bigint \
> +    nativesdk-perl-module-math-bigint \
>      "
>  
>  RDEPENDS:${PN}:darwin = "\

This doesn't address my feedback/concerns in the original patch.
SHouldn't these dependencies be added to the nativesdk-binutils-gprofng
RDEPENDS?

Cheers,

Richard
Sadineni, Harish Sept. 19, 2024, 12:51 p.m. UTC | #2
>This doesn't address my feedback/concerns in the original patch.
>SHouldn't these dependencies be added to the nativesdk-binutils-gprofng
>RDEPENDS?

As you suggested, we made changes accordingly and sent v5 .

Thanks
Harish
diff mbox series

Patch

diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
index c1d3c25060..70a7d3e494 100644
--- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
+++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
@@ -30,6 +30,9 @@  RDEPENDS:${PN} = "\
     nativesdk-bison \
     nativesdk-flex \
     nativesdk-perl-module-integer \
+    nativesdk-perl-module-bignum  \
+    nativesdk-perl-module-bigint \
+    nativesdk-perl-module-math-bigint \
     "
 
 RDEPENDS:${PN}:darwin = "\