diff mbox series

vulkan-samples: limit to aarch64/x86-64

Message ID 20240910163139.2913214-1-ross.burton@arm.com
State New
Headers show
Series vulkan-samples: limit to aarch64/x86-64 | expand

Commit Message

Ross Burton Sept. 10, 2024, 4:31 p.m. UTC
This package is only tested upstream for aarch64 and x86-64 targets,
for example there are int/long cast issues on 32-bit platforms and ATSC
is only ported to aarch64/x86-64.

Instead of listing the machines where we know it doesn't work, limit the
recipe to machines where it is known to work.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-graphics/vulkan/vulkan-samples_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj Sept. 10, 2024, 4:33 p.m. UTC | #1
On Tue, Sep 10, 2024 at 9:31 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:
>
> This package is only tested upstream for aarch64 and x86-64 targets,
> for example there are int/long cast issues on 32-bit platforms and ATSC
> is only ported to aarch64/x86-64.
>
> Instead of listing the machines where we know it doesn't work, limit the
> recipe to machines where it is known to work.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-graphics/vulkan/vulkan-samples_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
> index 93d4cdfdd9e..06e996d2435 100644
> --- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
> +++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
> @@ -36,4 +36,4 @@ EXTRA_OECMAKE += "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON"
>  # This needs to be specified explicitly to avoid xcb/xlib dependencies
>  EXTRA_OECMAKE += "-DVKB_WSI_SELECTION=D2D"
>
> -COMPATIBLE_HOST:x86 = "null"
> +COMPATIBLE_HOST = "(aarch64|x86_64).*-linux"

LGTM.
Reviewed-by: Khem Raj <raj.khem@gmail.com>

> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#204358): https://lists.openembedded.org/g/openembedded-core/message/204358
> Mute This Topic: https://lists.openembedded.org/mt/108378166/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
index 93d4cdfdd9e..06e996d2435 100644
--- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
+++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
@@ -36,4 +36,4 @@  EXTRA_OECMAKE += "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON"
 # This needs to be specified explicitly to avoid xcb/xlib dependencies
 EXTRA_OECMAKE += "-DVKB_WSI_SELECTION=D2D"
 
-COMPATIBLE_HOST:x86 = "null"
+COMPATIBLE_HOST = "(aarch64|x86_64).*-linux"