diff mbox series

[scarthgap,4/4] sstate: Drop SSTATEPOSTINSTFUNC support

Message ID 20240902103148.3762538-4-pedro.silva.ferreira@criticaltechworks.com
State Changes Requested
Delegated to: Steve Sakoman
Headers show
Series [scarthgap,1/4] buildhistory: Fix intermittent package file list creation | expand

Commit Message

Pedro Ferreira Sept. 2, 2024, 10:31 a.m. UTC 
From: Richard Purdie <richard.purdie@linuxfoundation.org>

This was deprecated with the introduction of postfunc support for tasks
in general and only used by buildhistory. Now that usage has been removed,
drop the code from sstate.bbclass. Any other users should be able to use
postfuncs too.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-global/sstate.bbclass | 6 ------
 1 file changed, 6 deletions(-)

--
2.34.1

The information in this communication may contain confidential or legally privileged information. It is intended solely for the use of the individual or entity it addresses and others authorized to receive it. If you are not an intended recipient, you are hereby notified that any disclosure, copying, distribution or action in reliance on the contents of this information is strictly prohibited and may be unlawful. If you have received this communication by error, please notify us immediately by responding to this e-mail and then delete it from your system. Critical TechWorks is not liable for the proper and complete transmission of the information in this communication nor for any delay in its receipt

This e-mail is environmentally friendly, just like Critical TechWorks, which lives in a paper-free atmosphere. Therefore, please consider the environment before printing it!

Comments

Richard Purdie Sept. 2, 2024, 12:01 p.m. UTC | #1 
On Mon, 2024-09-02 at 11:31 +0100, Pedro Ferreira wrote:
> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> This was deprecated with the introduction of postfunc support for
> tasks
> in general and only used by buildhistory. Now that usage has been
> removed,
> drop the code from sstate.bbclass. Any other users should be able to
> use
> postfuncs too.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/classes-global/sstate.bbclass | 6 ------
>  1 file changed, 6 deletions(-)

I suspect this patch can be dropped from the series as we wouldn't
remove this on a stable branch.

I'd also highlight that this has not merged to master yet.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta/classes-global/sstate.bbclass b/meta/classes-global/sstate.bbclass
index 93df5fa9e6..42b7e03513 100644
--- a/meta/classes-global/sstate.bbclass
+++ b/meta/classes-global/sstate.bbclass
@@ -103,7 +103,6 @@  SSTATECREATEFUNCS[vardeps] = "SSTATE_SCAN_FILES"
 SSTATEPOSTCREATEFUNCS = ""
 SSTATEPREINSTFUNCS = ""
 SSTATEPOSTUNPACKFUNCS = "sstate_hardcode_path_unpack"
-SSTATEPOSTINSTFUNCS = ""
 EXTRA_STAGING_FIXMES ?= "HOSTTOOLS_DIR"

 # Check whether sstate exists for tasks that support sstate and are in the
@@ -332,15 +331,10 @@  def sstate_install(ss, d):
         if os.path.exists(state[1]):
             oe.path.copyhardlinktree(state[1], state[2])

-    for postinst in (d.getVar('SSTATEPOSTINSTFUNCS') or '').split():
-        # All hooks should run in the SSTATE_INSTDIR
-        bb.build.exec_func(postinst, d, (sstateinst,))
-
     for lock in locks:
         bb.utils.unlockfile(lock)

 sstate_install[vardepsexclude] += "SSTATE_ALLOW_OVERLAP_FILES SSTATE_MANMACH SSTATE_MANFILEPREFIX"
-sstate_install[vardeps] += "${SSTATEPOSTINSTFUNCS}"

 def sstate_installpkg(ss, d):
     from oe.gpg_sign import get_signer