| Message ID | 20240829163128.502025-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | fmt: Include missing header <algorithm> | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/fmt-Include-missing-header-algorithm.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence) PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-devtools/fmt/fmt/0001-Include-algorithm-for-std-copy.patch b/meta/recipes-devtools/fmt/fmt/0001-Include-algorithm-for-std-copy.patch new file mode 100644 index 00000000000..0391de9a7a3 --- /dev/null +++ b/meta/recipes-devtools/fmt/fmt/0001-Include-algorithm-for-std-copy.patch @@ -0,0 +1,29 @@ +From 170d72330a2253eec4c1e37f6671f787df532782 Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Thu, 29 Aug 2024 09:19:29 -0700 +Subject: [PATCH] Include <algorithm> for std::copy + +Some headers like color.h are using std::copy API +from C++ std library, but missing to include the +right header [1] + +[1] https://en.cppreference.com/w/cpp/algorithm/copy + +Upstream-Status: Submitted [https://github.com/fmtlib/fmt/pull/4138] +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + include/fmt/color.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/include/fmt/color.h b/include/fmt/color.h +index 231d93c8..6130a2d0 100644 +--- a/include/fmt/color.h ++++ b/include/fmt/color.h +@@ -8,6 +8,7 @@ + #ifndef FMT_COLOR_H_ + #define FMT_COLOR_H_ + ++#include <algorithm> // std::copy + #include "format.h" + + FMT_BEGIN_NAMESPACE diff --git a/meta/recipes-devtools/fmt/fmt_11.0.2.bb b/meta/recipes-devtools/fmt/fmt_11.0.2.bb index 5a7041088cd..fdc2a7dd5fa 100644 --- a/meta/recipes-devtools/fmt/fmt_11.0.2.bb +++ b/meta/recipes-devtools/fmt/fmt_11.0.2.bb @@ -4,7 +4,9 @@ HOMEPAGE = "https://fmt.dev" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://LICENSE;md5=b9257785fc4f3803a4b71b76c1412729" -SRC_URI = "git://github.com/fmtlib/fmt;branch=master;protocol=https" +SRC_URI = "git://github.com/fmtlib/fmt;branch=master;protocol=https \ + file://0001-Include-algorithm-for-std-copy.patch \ + " SRCREV = "0c9fce2ffefecfdce794e1859584e25877b7b592" S = "${WORKDIR}/git"
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../0001-Include-algorithm-for-std-copy.patch | 29 +++++++++++++++++++ meta/recipes-devtools/fmt/fmt_11.0.2.bb | 4 ++- 2 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 meta/recipes-devtools/fmt/fmt/0001-Include-algorithm-for-std-copy.patch