diff mbox series

[v2,2/2] insane: Optimise ERROR_QA/WARN_QA references in do_populate_sysroot

Message ID 20240828171548.1545246-2-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit 51f767d92efb3daeb4aa3b91d72e6d2993cb0f46
Headers show
Series [v2,1/2] lib/oe: Use new visitorcode functionality for qa.handle_error() | expand

Commit Message

Richard Purdie Aug. 28, 2024, 5:15 p.m. UTC
The new contains code can't inspect variable references in handle_error()
calls. Expand what is effectively a hardcoded reference anyway so the code
can optimise it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-global/insane.bbclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index 6a84c4aa74d..a008f21c6ee 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -789,9 +789,8 @@  def qa_check_staged(path,d):
             if not skip_shebang_size:
                 errors = {}
                 package_qa_check_shebang_size(path, "", d, None, errors)
-                for e in errors:
-                    oe.qa.handle_error(e, errors[e], d)
-
+                if "shebang-size" in errors:
+                    oe.qa.handle_error("shebang-size", errors["shebang-size"], d)
 
 # Run all package-wide warnfuncs and errorfuncs
 def package_qa_package(warnfuncs, errorfuncs, package, d):