| Message ID | 20240827100343.127172-1-dmitry.baryshkov@linaro.org |
|---|---|
| State | Accepted |
| Delegated to: | Steve Sakoman |
| Headers | show |
| Series | [scarthgap,v2] linux-firmware: add a package for ath12k firmware | expand |
Hi Dmitry, On 8/27/24 12:03 PM, Dmitry Baryshkov via lists.openembedded.org wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add the firmware package for the ATH12K module. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > [DB: added rdepends from PN to PN-ath12k] > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > Changes since v1: > - Added PN-ath12k to RDEPENDS:PN as not to break users expecting ath12k > from linux-firmware (Quentin Schulz) > Was it really part of the linux-firmware package? I hadn't checked myself, it was an assumption. Cheers, Quentin
On Tue, 27 Aug 2024 at 14:32, Quentin Schulz <quentin.schulz@cherry.de> wrote: > > Hi Dmitry, > > On 8/27/24 12:03 PM, Dmitry Baryshkov via lists.openembedded.org wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add the firmware package for the ATH12K module. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > [DB: added rdepends from PN to PN-ath12k] > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > > > Changes since v1: > > - Added PN-ath12k to RDEPENDS:PN as not to break users expecting ath12k > > from linux-firmware (Quentin Schulz) > > > > Was it really part of the linux-firmware package? I hadn't checked > myself, it was an assumption. Yes, it wasn't split to any of the packages, so it was in ${PN}.
Hi Dmitry, On 8/27/24 1:37 PM, Dmitry Baryshkov wrote: > On Tue, 27 Aug 2024 at 14:32, Quentin Schulz <quentin.schulz@cherry.de> wrote: >> >> Hi Dmitry, >> >> On 8/27/24 12:03 PM, Dmitry Baryshkov via lists.openembedded.org wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> Add the firmware package for the ATH12K module. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> [DB: added rdepends from PN to PN-ath12k] >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> >>> Changes since v1: >>> - Added PN-ath12k to RDEPENDS:PN as not to break users expecting ath12k >>> from linux-firmware (Quentin Schulz) >>> >> >> Was it really part of the linux-firmware package? I hadn't checked >> myself, it was an assumption. > > Yes, it wasn't split to any of the packages, so it was in ${PN}. > ACK. Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de> Thanks! Quentin
diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb index ff79bb9b33c6..5819d9287cc8 100644 --- a/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_20240312.bb @@ -322,7 +322,7 @@ PACKAGES =+ "${PN}-amphion-vpu-license ${PN}-amphion-vpu \ ${PN}-cnm-license ${PN}-cnm \ ${PN}-atheros-license ${PN}-ar5523 ${PN}-ar9170 ${PN}-ath6k ${PN}-ath9k ${PN}-ath3k \ ${PN}-carl9170 \ - ${PN}-ar3k-license ${PN}-ar3k ${PN}-ath10k-license ${PN}-ath10k ${PN}-ath11k ${PN}-qca \ + ${PN}-ar3k-license ${PN}-ar3k ${PN}-ath10k-license ${PN}-ath10k ${PN}-ath11k ${PN}-ath12k ${PN}-qca \ \ ${PN}-imx-sdma-license ${PN}-imx-sdma-imx6q ${PN}-imx-sdma-imx7d \ \ @@ -487,6 +487,11 @@ FILES:${PN}-ath11k = " \ ${nonarch_base_libdir}/firmware/ath11k \ " +FILES:${PN}-ath12k = " \ + ${nonarch_base_libdir}/firmware/ath12k \ +" +RDEPENDS:${PN} += "${PN}-ath12k" + FILES:${PN}-qca = " \ ${nonarch_base_libdir}/firmware/qca \ " @@ -494,6 +499,7 @@ FILES:${PN}-qca = " \ RDEPENDS:${PN}-ar3k += "${PN}-ar3k-license ${PN}-atheros-license" RDEPENDS:${PN}-ath10k += "${PN}-ath10k-license" RDEPENDS:${PN}-ath11k += "${PN}-ath10k-license" +RDEPENDS:${PN}-ath12k += "${PN}-ath10k-license" RDEPENDS:${PN}-qca += "${PN}-ath10k-license" # For ralink