diff mbox series

[v3,2/2] ofono: add ptests

Message ID 20240801082253.974486-2-martin@geanix.com
State New
Headers show
Series [v3,1/2] ell: add ptests | expand

Commit Message

Martin Hundebøll Aug. 1, 2024, 8:22 a.m. UTC 
Install and run the unit tests already provided by ofono. Test execution
time is about a second.

Signed-off-by: Martin Hundebøll <martin@geanix.com>
---

Change since v2:
 * disable basic mux test that requires phonesim service to connect to

Change since v1:
 * add missing run-ptest file

 .../distro/include/ptest-packagelists.inc     |  1 +
 .../ofono/ofono/run-ptest                     | 25 +++++++++++++++++++
 meta/recipes-connectivity/ofono/ofono_2.9.bb  | 12 ++++++++-
 3 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-connectivity/ofono/ofono/run-ptest

Comments

Ross Burton Aug. 2, 2024, 12:39 p.m. UTC | #1 
> On 1 Aug 2024, at 09:22, Martin Hundeb?ll via lists.openembedded.org <martin=geanix.com@lists.openembedded.org> wrote:
> +do_install_ptest() {
> +    install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit -executable -type f)
> +    install -m644 -Dt ${D}${PTEST_PATH}/unit ${B}/unit/test-provision.db
> +}

As as ell: the binaries are built with libtool, so use libtool —mode=install to install them.

Ross
diff mbox series

Patch

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index a655439f5ebe..ad117c1bcc76 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -54,6 +54,7 @@  PTESTS_FAST = "\
     lzo \
     m4 \
     nettle \
+    ofono \
     opkg \
     popt \
     python3-atomicwrites \
diff --git a/meta/recipes-connectivity/ofono/ofono/run-ptest b/meta/recipes-connectivity/ofono/ofono/run-ptest
new file mode 100644
index 000000000000..99a79376382a
--- /dev/null
+++ b/meta/recipes-connectivity/ofono/ofono/run-ptest
@@ -0,0 +1,25 @@ 
+#!/bin/sh
+
+ret_val=0
+
+for test in test-*; do
+    case "$test" in
+      test-mux)
+        # the basic mux test requires a phonesim server process
+        # to connect to
+        args="-s /testmux/basic"
+        ;;
+      *)
+        args=""
+        ;;
+    esac
+
+    if "./$test" $args >> ofono_test.log 2>&1; then
+        echo "PASS: $test"
+    else
+        echo "FAIL: $test"
+        ret_val=1
+    fi
+done
+
+exit $ret_val
diff --git a/meta/recipes-connectivity/ofono/ofono_2.9.bb b/meta/recipes-connectivity/ofono/ofono_2.9.bb
index 26cb9bb7ffb7..6b641a6e854d 100644
--- a/meta/recipes-connectivity/ofono/ofono_2.9.bb
+++ b/meta/recipes-connectivity/ofono/ofono_2.9.bb
@@ -10,10 +10,11 @@  DEPENDS = "dbus glib-2.0 udev mobile-broadband-provider-info ell"
 SRC_URI = "\
     ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
     file://ofono \
+    file://run-ptest \
 "
 SRC_URI[sha256sum] = "9d2612925a23a7fb668f297a044b5ea136215cc399ecc3f127135c8f2a9845f9"
 
-inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data
+inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data ptest
 
 INITSCRIPT_NAME = "ofono"
 INITSCRIPT_PARAMS = "defaults 22"
@@ -28,11 +29,20 @@  PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, bluez5"
 
 EXTRA_OECONF += "--enable-test --enable-external-ell"
 
+do_compile_ptest() {
+    oe_runmake buildtest-TESTS
+}
+
 do_install:append() {
     install -d ${D}${sysconfdir}/init.d/
     install -m 0755 ${UNPACKDIR}/ofono ${D}${sysconfdir}/init.d/ofono
 }
 
+do_install_ptest() {
+    install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit -executable -type f)
+    install -m644 -Dt ${D}${PTEST_PATH}/unit ${B}/unit/test-provision.db
+}
+
 PACKAGES =+ "${PN}-tests"
 
 FILES:${PN} += "${systemd_unitdir}"