diff mbox series

tune: octeontx2: remove crypto from TUNE_FEATURES

Message ID 20240703020027.3434756-1-ruiqiang.hao@windriver.com
State New
Headers show
Series tune: octeontx2: remove crypto from TUNE_FEATURES | expand

Commit Message

Hao, Ruiqiang July 3, 2024, 2 a.m. UTC 
From: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>

Since GCC's configuration includes the crypto feature when specifying
'-mcpu=octeontx2', there's no need to additionally include this feature
in TUNE_FEATURES. Removing crypto to fix the following error:

aarch64-wrs-linux-clang: error: unsupported argument 'octeontx2+crypto' for option '-mcpu='

Signed-off-by: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
---
 meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj July 3, 2024, 3:30 a.m. UTC | #1 
On Tue, Jul 2, 2024 at 7:00 PM Ruiqiang Hao via lists.openembedded.org
<Ruiqiang.Hao=windriver.com@lists.openembedded.org> wrote:
>
> From: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
>
> Since GCC's configuration includes the crypto feature when specifying
> '-mcpu=octeontx2', there's no need to additionally include this feature
> in TUNE_FEATURES. Removing crypto to fix the following error:
>
> aarch64-wrs-linux-clang: error: unsupported argument 'octeontx2+crypto' for option '-mcpu='

This is a clang problem. It should be fixed in clang, not here.
Additionally we check for 'crypto' in TUNE_FEATURES in
many recipes for making specific tweaks, they will fail for octeonx2
if we apply this. See
https://github.com/kraj/meta-clang/blob/master/classes/clang.bbclass#L49-L53

>
> Signed-off-by: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
> ---
>  meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> index e9d7a59c51..d51d19b980 100644
> --- a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> @@ -9,6 +9,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc
>  AVAILTUNES += "octeontx2"
>  ARMPKGARCH:tune-octeontx2             = "octeontx2"
>  # We do not want -march since -mcpu is added above to cover for it
> -TUNE_FEATURES:tune-octeontx2          = "aarch64 crypto octeontx2"
> +TUNE_FEATURES:tune-octeontx2          = "aarch64 octeontx2"
>  PACKAGE_EXTRA_ARCHS:tune-octeontx2    = "${PACKAGE_EXTRA_ARCHS:tune-armv8-2a-crypto} octeontx2"
>  BASE_LIB:tune-octeontx2               = "lib64"
> --
> 2.45.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#201448): https://lists.openembedded.org/g/openembedded-core/message/201448
> Mute This Topic: https://lists.openembedded.org/mt/107012841/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Hao, Ruiqiang July 3, 2024, 6:57 a.m. UTC | #2 
This is a clang problem. It should be fixed in clang, not here. Additionally we check for 'crypto' in TUNE_FEATURES in many recipes for making specific tweaks, they will fail for octeonx2 if we apply this. See https://github.com/kraj/meta-clang/blob/master/classes/clang.bbclass#L49-L53
Hi kraj,

Thanks for your prompt feedback.
I have limited experience with Clang, could you provide some suggestions for fixing this issue?
Additionally, this link is not related to the TUNE_FEATURES check for octeontx2.
Could you provide one name of recipe that checks whether TUNE_FEATURES includes 'crypto' to help me with troubleshooting?

B.R.
Ruiqiang
________________________________
From: Khem Raj <raj.khem@gmail.com>
Sent: Wednesday, July 3, 2024 11:30
To: Hao, Ruiqiang <Ruiqiang.Hao@windriver.com>
Cc: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] tune: octeontx2: remove crypto from TUNE_FEATURES

CAUTION: This email comes from a non Wind River email account!
Do not click links or open attachments unless you recognize the sender and know the content is safe.

On Tue, Jul 2, 2024 at 7:00 PM Ruiqiang Hao via lists.openembedded.org
<Ruiqiang.Hao=windriver.com@lists.openembedded.org> wrote:
>
> From: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
>
> Since GCC's configuration includes the crypto feature when specifying
> '-mcpu=octeontx2', there's no need to additionally include this feature
> in TUNE_FEATURES. Removing crypto to fix the following error:
>
> aarch64-wrs-linux-clang: error: unsupported argument 'octeontx2+crypto' for option '-mcpu='

This is a clang problem. It should be fixed in clang, not here.
Additionally we check for 'crypto' in TUNE_FEATURES in
many recipes for making specific tweaks, they will fail for octeonx2
if we apply this. See
https://github.com/kraj/meta-clang/blob/master/classes/clang.bbclass#L49-L53

>
> Signed-off-by: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
> ---
>  meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> index e9d7a59c51..d51d19b980 100644
> --- a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> +++ b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> @@ -9,6 +9,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc
>  AVAILTUNES += "octeontx2"
>  ARMPKGARCH:tune-octeontx2             = "octeontx2"
>  # We do not want -march since -mcpu is added above to cover for it
> -TUNE_FEATURES:tune-octeontx2          = "aarch64 crypto octeontx2"
> +TUNE_FEATURES:tune-octeontx2          = "aarch64 octeontx2"
>  PACKAGE_EXTRA_ARCHS:tune-octeontx2    = "${PACKAGE_EXTRA_ARCHS:tune-armv8-2a-crypto} octeontx2"
>  BASE_LIB:tune-octeontx2               = "lib64"
> --
> 2.45.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#201448): https://lists.openembedded.org/g/openembedded-core/message/201448
> Mute This Topic: https://lists.openembedded.org/mt/107012841/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Khem Raj July 3, 2024, 7:16 a.m. UTC | #3 
On Tue, Jul 2, 2024 at 11:57 PM Hao, Ruiqiang <Ruiqiang.Hao@windriver.com>
wrote:

> This is a clang problem. It should be fixed in clang, not here.
> Additionally we check for 'crypto' in TUNE_FEATURES in many recipes for
> making specific tweaks, they will fail for octeonx2 if we apply this. See
> https://github.com/kraj/meta-clang/blob/master/classes/clang.bbclass#L49-L53
> Hi kraj,
>
> Thanks for your prompt feedback.
> I have limited experience with Clang, could you provide some suggestions
> for fixing this issue?
> Additionally, this link is not related to the TUNE_FEATURES check for
> octeontx2.
> Could you provide one name of recipe that checks whether TUNE_FEATURES
> includes 'crypto' to help me with troubleshooting?
>

add it to TUNE_CCARGS:remove:toolchain-clang list
-mcpu=octeontx2+crypto

then add to TUNE_CCARGS e.g
TUNE_CCARGS:append:toolchain-clang = "${@bb.utils.contains("TUNE_FEATURES",
"octeontx2 crypto", " -mcpu=octeontx2", "", d)}"


>
> B.R.
> Ruiqiang
> ------------------------------
> *From:* Khem Raj <raj.khem@gmail.com>
> *Sent:* Wednesday, July 3, 2024 11:30
> *To:* Hao, Ruiqiang <Ruiqiang.Hao@windriver.com>
> *Cc:* openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org>
> *Subject:* Re: [OE-core] [PATCH] tune: octeontx2: remove crypto from
> TUNE_FEATURES
>
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and
> know the content is safe.
>
> On Tue, Jul 2, 2024 at 7:00 PM Ruiqiang Hao via lists.openembedded.org
> <Ruiqiang.Hao=windriver.com@lists.openembedded.org> wrote:
> >
> > From: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
> >
> > Since GCC's configuration includes the crypto feature when specifying
> > '-mcpu=octeontx2', there's no need to additionally include this feature
> > in TUNE_FEATURES. Removing crypto to fix the following error:
> >
> > aarch64-wrs-linux-clang: error: unsupported argument 'octeontx2+crypto'
> for option '-mcpu='
>
> This is a clang problem. It should be fixed in clang, not here.
> Additionally we check for 'crypto' in TUNE_FEATURES in
> many recipes for making specific tweaks, they will fail for octeonx2
> if we apply this. See
>
> https://github.com/kraj/meta-clang/blob/master/classes/clang.bbclass#L49-L53
>
> >
> > Signed-off-by: Ruiqiang Hao <Ruiqiang.Hao@windriver.com>
> > ---
> >  meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> > index e9d7a59c51..d51d19b980 100644
> > --- a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> > +++ b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
> > @@ -9,6 +9,6 @@ require conf/machine/include/arm/arch-armv8-2a.inc
> >  AVAILTUNES += "octeontx2"
> >  ARMPKGARCH:tune-octeontx2             = "octeontx2"
> >  # We do not want -march since -mcpu is added above to cover for it
> > -TUNE_FEATURES:tune-octeontx2          = "aarch64 crypto octeontx2"
> > +TUNE_FEATURES:tune-octeontx2          = "aarch64 octeontx2"
> >  PACKAGE_EXTRA_ARCHS:tune-octeontx2    =
> "${PACKAGE_EXTRA_ARCHS:tune-armv8-2a-crypto} octeontx2"
> >  BASE_LIB:tune-octeontx2               = "lib64"
> > --
> > 2.45.0
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#201448):
> https://lists.openembedded.org/g/openembedded-core/message/201448
> > Mute This Topic: https://lists.openembedded.org/mt/107012841/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
diff mbox series

Patch

diff --git a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
index e9d7a59c51..d51d19b980 100644
--- a/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
+++ b/meta/conf/machine/include/arm/armv8-2a/tune-octeontx2.inc
@@ -9,6 +9,6 @@  require conf/machine/include/arm/arch-armv8-2a.inc
 AVAILTUNES += "octeontx2"
 ARMPKGARCH:tune-octeontx2             = "octeontx2"
 # We do not want -march since -mcpu is added above to cover for it
-TUNE_FEATURES:tune-octeontx2          = "aarch64 crypto octeontx2"
+TUNE_FEATURES:tune-octeontx2          = "aarch64 octeontx2"
 PACKAGE_EXTRA_ARCHS:tune-octeontx2    = "${PACKAGE_EXTRA_ARCHS:tune-armv8-2a-crypto} octeontx2"
 BASE_LIB:tune-octeontx2               = "lib64"