diff mbox series

[3/3] go: move to a single binary bootstrap option

Message ID 20240619103406.276716-3-jose.quaresma@foundries.io
State Under Review
Headers show
Series [1/3] go: upgrade 1.22.3 -> 1.22.4 | expand

Commit Message

Jose Quaresma June 19, 2024, 10:34 a.m. UTC
With the drop of the old 1.4 bootstrap C version we can
move the go-binary-native to go-binary and drop the PREFERRED_PROVIDER

Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
---
 meta/conf/distro/include/tcmode-default.inc                   | 4 ----
 .../go/{go-binary-native_1.22.4.bb => go-native_1.22.4.bb}    | 2 --
 2 files changed, 6 deletions(-)
 rename meta/recipes-devtools/go/{go-binary-native_1.22.4.bb => go-native_1.22.4.bb} (98%)

Comments

Alexandre Belloni June 21, 2024, 7:51 p.m. UTC | #1
Hello,

This caused:
AssertionError: 
Unable to find recipes for the following entries in maintainers.inc:
go-binary-native

On 19/06/2024 11:34:06+0100, Jose Quaresma wrote:
> With the drop of the old 1.4 bootstrap C version we can
> move the go-binary-native to go-binary and drop the PREFERRED_PROVIDER
> 
> Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> ---
>  meta/conf/distro/include/tcmode-default.inc                   | 4 ----
>  .../go/{go-binary-native_1.22.4.bb => go-native_1.22.4.bb}    | 2 --
>  2 files changed, 6 deletions(-)
>  rename meta/recipes-devtools/go/{go-binary-native_1.22.4.bb => go-native_1.22.4.bb} (98%)
> 
> diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
> index 4fb6e47b7f..a9724d7621 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -62,10 +62,6 @@ PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
>  PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
>  PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
>  
> -# Bootstrap Go using a binary release from golang.org.  If you want to bootstrap
> -# from source using the C-implemented Go 1.4 (only supports x86-64 hosts) then use
> -# go-native.
> -PREFERRED_PROVIDER_go-native ?= "go-binary-native"
>  PREFERRED_VERSION_virtual/${TARGET_PREFIX}go ?= "${GOVERSION}"
>  PREFERRED_VERSION_go-cross-${TUNE_PKGARCH} ?= "${GOVERSION}"
>  PREFERRED_VERSION_go-crosssdk-${SDK_ARCH} ?= "${GOVERSION}"
> diff --git a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb b/meta/recipes-devtools/go/go-native_1.22.4.bb
> similarity index 98%
> rename from meta/recipes-devtools/go/go-binary-native_1.22.4.bb
> rename to meta/recipes-devtools/go/go-native_1.22.4.bb
> index 61da51be3a..ee094435a7 100644
> --- a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb
> +++ b/meta/recipes-devtools/go/go-native_1.22.4.bb
> @@ -5,8 +5,6 @@ HOMEPAGE = " http://golang.org/"
>  LICENSE = "BSD-3-Clause"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707"
>  
> -PROVIDES = "go-native"
> -
>  # Checksums available at https://go.dev/dl/
>  SRC_URI = "https://dl.google.com/go/go${PV}.${BUILD_GOOS}-${BUILD_GOARCH}.tar.gz;name=go_${BUILD_GOTUPLE}"
>  SRC_URI[go_linux_amd64.sha256sum] = "ba79d4526102575196273416239cca418a651e049c2b099f3159db85e7bade7d"
> -- 
> 2.45.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#200907): https://lists.openembedded.org/g/openembedded-core/message/200907
> Mute This Topic: https://lists.openembedded.org/mt/106757823/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jose Quaresma June 24, 2024, 7:27 a.m. UTC | #2
Alexandre Belloni <alexandre.belloni@bootlin.com> escreveu (sexta,
21/06/2024 à(s) 20:51):

> Hello,
>
> This caused:
> AssertionError:
> Unable to find recipes for the following entries in maintainers.inc:
> go-binary-native
>

I noticed that you have fixed what was missing in maintainers.inc.
Thanks

Jose


>
> On 19/06/2024 11:34:06+0100, Jose Quaresma wrote:
> > With the drop of the old 1.4 bootstrap C version we can
> > move the go-binary-native to go-binary and drop the PREFERRED_PROVIDER
> >
> > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> > ---
> >  meta/conf/distro/include/tcmode-default.inc                   | 4 ----
> >  .../go/{go-binary-native_1.22.4.bb => go-native_1.22.4.bb}    | 2 --
> >  2 files changed, 6 deletions(-)
> >  rename meta/recipes-devtools/go/{go-binary-native_1.22.4.bb =>
> go-native_1.22.4.bb} (98%)
> >
> > diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> > index 4fb6e47b7f..a9724d7621 100644
> > --- a/meta/conf/distro/include/tcmode-default.inc
> > +++ b/meta/conf/distro/include/tcmode-default.inc
> > @@ -62,10 +62,6 @@ PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
> >  PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
> >  PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
> >
> > -# Bootstrap Go using a binary release from golang.org.  If you want to
> bootstrap
> > -# from source using the C-implemented Go 1.4 (only supports x86-64
> hosts) then use
> > -# go-native.
> > -PREFERRED_PROVIDER_go-native ?= "go-binary-native"
> >  PREFERRED_VERSION_virtual/${TARGET_PREFIX}go ?= "${GOVERSION}"
> >  PREFERRED_VERSION_go-cross-${TUNE_PKGARCH} ?= "${GOVERSION}"
> >  PREFERRED_VERSION_go-crosssdk-${SDK_ARCH} ?= "${GOVERSION}"
> > diff --git a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb
> b/meta/recipes-devtools/go/go-native_1.22.4.bb
> > similarity index 98%
> > rename from meta/recipes-devtools/go/go-binary-native_1.22.4.bb
> > rename to meta/recipes-devtools/go/go-native_1.22.4.bb
> > index 61da51be3a..ee094435a7 100644
> > --- a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb
> > +++ b/meta/recipes-devtools/go/go-native_1.22.4.bb
> > @@ -5,8 +5,6 @@ HOMEPAGE = " http://golang.org/"
> >  LICENSE = "BSD-3-Clause"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707"
> >
> > -PROVIDES = "go-native"
> > -
> >  # Checksums available at https://go.dev/dl/
> >  SRC_URI = "
> https://dl.google.com/go/go${PV}.${BUILD_GOOS}-${BUILD_GOARCH}.tar.gz;name=go_${BUILD_GOTUPLE}
> "
> >  SRC_URI[go_linux_amd64.sha256sum] =
> "ba79d4526102575196273416239cca418a651e049c2b099f3159db85e7bade7d"
> > --
> > 2.45.2
> >
>
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#200907):
> https://lists.openembedded.org/g/openembedded-core/message/200907
> > Mute This Topic: https://lists.openembedded.org/mt/106757823/3617179
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> alexandre.belloni@bootlin.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc
index 4fb6e47b7f..a9724d7621 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -62,10 +62,6 @@  PREFERRED_VERSION_qemu ?= "${QEMUVERSION}"
 PREFERRED_VERSION_qemu-native ?= "${QEMUVERSION}"
 PREFERRED_VERSION_nativesdk-qemu ?= "${QEMUVERSION}"
 
-# Bootstrap Go using a binary release from golang.org.  If you want to bootstrap
-# from source using the C-implemented Go 1.4 (only supports x86-64 hosts) then use
-# go-native.
-PREFERRED_PROVIDER_go-native ?= "go-binary-native"
 PREFERRED_VERSION_virtual/${TARGET_PREFIX}go ?= "${GOVERSION}"
 PREFERRED_VERSION_go-cross-${TUNE_PKGARCH} ?= "${GOVERSION}"
 PREFERRED_VERSION_go-crosssdk-${SDK_ARCH} ?= "${GOVERSION}"
diff --git a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb b/meta/recipes-devtools/go/go-native_1.22.4.bb
similarity index 98%
rename from meta/recipes-devtools/go/go-binary-native_1.22.4.bb
rename to meta/recipes-devtools/go/go-native_1.22.4.bb
index 61da51be3a..ee094435a7 100644
--- a/meta/recipes-devtools/go/go-binary-native_1.22.4.bb
+++ b/meta/recipes-devtools/go/go-native_1.22.4.bb
@@ -5,8 +5,6 @@  HOMEPAGE = " http://golang.org/"
 LICENSE = "BSD-3-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707"
 
-PROVIDES = "go-native"
-
 # Checksums available at https://go.dev/dl/
 SRC_URI = "https://dl.google.com/go/go${PV}.${BUILD_GOOS}-${BUILD_GOARCH}.tar.gz;name=go_${BUILD_GOTUPLE}"
 SRC_URI[go_linux_amd64.sha256sum] = "ba79d4526102575196273416239cca418a651e049c2b099f3159db85e7bade7d"