diff mbox series

[3/3] ofono: add ptests

Message ID 20240617133643.1856546-3-martin@geanix.com
State New
Headers show
Series [1/3] ofono: upgrade 2.7 -> 2.8 | expand

Commit Message

Martin Hundebøll June 17, 2024, 1:36 p.m. UTC
Install and run the unit tests already provided by ofono. Test execution
time is about a second.

Signed-off-by: Martin Hundebøll <martin@geanix.com>
---
 meta/conf/distro/include/ptest-packagelists.inc |  1 +
 meta/recipes-connectivity/ofono/ofono_2.8.bb    | 12 +++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

Comments

Alexandre Belloni June 18, 2024, 7:31 a.m. UTC | #1
ERROR: /home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono_2.8.bb: Unable to get checksum for ofono SRC_URI entry run-ptest: file could not be found
The following paths were searched:
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono-2.8/poky/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono/poky/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/files/poky/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono-2.8/qemux86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono/qemux86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/files/qemux86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono-2.8/qemuall/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono/qemuall/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/files/qemuall/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono-2.8/x86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono/x86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/files/x86-64/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono-2.8/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/ofono/run-ptest
/home/pokybuild/yocto-worker/a-full/build/meta/recipes-connectivity/ofono/files/run-ptest
ERROR: Parsing halted due to errors, see error messages above

On 17/06/2024 15:36:42+0200, Martin Hundeb?ll wrote:
> Install and run the unit tests already provided by ofono. Test execution
> time is about a second.
> 
> Signed-off-by: Martin Hundeb�ll <martin@geanix.com>
> ---
>  meta/conf/distro/include/ptest-packagelists.inc |  1 +
>  meta/recipes-connectivity/ofono/ofono_2.8.bb    | 12 +++++++++++-
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
> index c60575a45cc2..60cbea0f19e9 100644
> --- a/meta/conf/distro/include/ptest-packagelists.inc
> +++ b/meta/conf/distro/include/ptest-packagelists.inc
> @@ -53,6 +53,7 @@ PTESTS_FAST = "\
>      lzo \
>      m4 \
>      nettle \
> +    ofono \
>      opkg \
>      pango \
>      popt \
> diff --git a/meta/recipes-connectivity/ofono/ofono_2.8.bb b/meta/recipes-connectivity/ofono/ofono_2.8.bb
> index 809485d42178..f54367848f05 100644
> --- a/meta/recipes-connectivity/ofono/ofono_2.8.bb
> +++ b/meta/recipes-connectivity/ofono/ofono_2.8.bb
> @@ -10,10 +10,11 @@ DEPENDS = "dbus glib-2.0 udev mobile-broadband-provider-info ell"
>  SRC_URI = "\
>      ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
>      file://ofono \
> +    file://run-ptest \
>  "
>  SRC_URI[sha256sum] = "b5aef455b3a374ce43bad43c2ade9d0430d9c0d28952385c44ac7d0dc933bbb8"
>  
> -inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data
> +inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data ptest
>  
>  INITSCRIPT_NAME = "ofono"
>  INITSCRIPT_PARAMS = "defaults 22"
> @@ -28,11 +29,20 @@ PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, bluez5"
>  
>  EXTRA_OECONF += "--enable-test --enable-external-ell"
>  
> +do_compile_ptest() {
> +    oe_runmake buildtest-TESTS
> +}
> +
>  do_install:append() {
>      install -d ${D}${sysconfdir}/init.d/
>      install -m 0755 ${UNPACKDIR}/ofono ${D}${sysconfdir}/init.d/ofono
>  }
>  
> +do_install_ptest() {
> +    install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit -executable -type f)
> +    install -m644 -Dt ${D}${PTEST_PATH}/unit ${B}/unit/test-provision.db
> +}
> +
>  PACKAGES =+ "${PN}-tests"
>  
>  FILES:${PN} += "${systemd_unitdir}"
> -- 
> 2.45.2
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#200838): https://lists.openembedded.org/g/openembedded-core/message/200838
> Mute This Topic: https://lists.openembedded.org/mt/106720606/3617179
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/conf/distro/include/ptest-packagelists.inc b/meta/conf/distro/include/ptest-packagelists.inc
index c60575a45cc2..60cbea0f19e9 100644
--- a/meta/conf/distro/include/ptest-packagelists.inc
+++ b/meta/conf/distro/include/ptest-packagelists.inc
@@ -53,6 +53,7 @@  PTESTS_FAST = "\
     lzo \
     m4 \
     nettle \
+    ofono \
     opkg \
     pango \
     popt \
diff --git a/meta/recipes-connectivity/ofono/ofono_2.8.bb b/meta/recipes-connectivity/ofono/ofono_2.8.bb
index 809485d42178..f54367848f05 100644
--- a/meta/recipes-connectivity/ofono/ofono_2.8.bb
+++ b/meta/recipes-connectivity/ofono/ofono_2.8.bb
@@ -10,10 +10,11 @@  DEPENDS = "dbus glib-2.0 udev mobile-broadband-provider-info ell"
 SRC_URI = "\
     ${KERNELORG_MIRROR}/linux/network/${BPN}/${BP}.tar.xz \
     file://ofono \
+    file://run-ptest \
 "
 SRC_URI[sha256sum] = "b5aef455b3a374ce43bad43c2ade9d0430d9c0d28952385c44ac7d0dc933bbb8"
 
-inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data
+inherit autotools pkgconfig update-rc.d systemd gobject-introspection-data ptest
 
 INITSCRIPT_NAME = "ofono"
 INITSCRIPT_PARAMS = "defaults 22"
@@ -28,11 +29,20 @@  PACKAGECONFIG[bluez] = "--enable-bluetooth, --disable-bluetooth, bluez5"
 
 EXTRA_OECONF += "--enable-test --enable-external-ell"
 
+do_compile_ptest() {
+    oe_runmake buildtest-TESTS
+}
+
 do_install:append() {
     install -d ${D}${sysconfdir}/init.d/
     install -m 0755 ${UNPACKDIR}/ofono ${D}${sysconfdir}/init.d/ofono
 }
 
+do_install_ptest() {
+    install -m755 -Dt ${D}${PTEST_PATH} $(find ${B}/unit -executable -type f)
+    install -m644 -Dt ${D}${PTEST_PATH}/unit ${B}/unit/test-provision.db
+}
+
 PACKAGES =+ "${PN}-tests"
 
 FILES:${PN} += "${systemd_unitdir}"