| Message ID | 20240612204640.3909981-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | gstreamer1.0-plugins-bad: Fix build with musl | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/gstreamer1.0-plugins-bad-Fix-build-with-musl.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files) PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence) PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) PASS: test max line length (test_metadata.TestMetadata.test_max_line_length) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-uvcgadget-Use-g_path_get_basename-instead-of-libc-ba.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-uvcgadget-Use-g_path_get_basename-instead-of-libc-ba.patch new file mode 100644 index 00000000000..3c93384d3db --- /dev/null +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-uvcgadget-Use-g_path_get_basename-instead-of-libc-ba.patch @@ -0,0 +1,98 @@ +From 7c558e8ef9375aea953d1e7c854b25947c967f76 Mon Sep 17 00:00:00 2001 +From: Khem Raj <raj.khem@gmail.com> +Date: Fri, 7 Jun 2024 23:09:54 -0700 +Subject: [PATCH] uvcgadget: Use g_path_get_basename instead of libc basename + +Musl does not implement GNU basename and have fixed a bug where the +prototype was leaked into string.h [1], which resullts in compile errors +with GCC-14 and Clang-17+ + +| sys/uvcgadget/configfs.c:262:21: error: call to undeclared function 'basename' +ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] +| 262 | const char *v = basename (globbuf.gl_pathv[i]); +| | ^ + +Use glib function instead makes it portable across musl and glibc on +linux + +[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7a + +Upstream-Status: Submitted [https://gitlab.freedesktop.org/gstreamer/gstreamer/merge_requests/7006] +Signed-off-by: Khem Raj <raj.khem@gmail.com> +--- + .../gst-plugins-bad/sys/uvcgadget/configfs.c | 18 ++++++++++++------ + 1 file changed, 12 insertions(+), 6 deletions(-) + +diff --git a/subprojects/gst-plugins-bad/sys/uvcgadget/configfs.c b/subprojects/gst-plugins-bad/sys/uvcgadget/configfs.c +index 51b75cd795..3f43b80f6e 100644 +--- a/subprojects/gst-plugins-bad/sys/uvcgadget/configfs.c ++++ b/subprojects/gst-plugins-bad/sys/uvcgadget/configfs.c +@@ -7,7 +7,7 @@ + * Contact: Kieran Bingham <kieran.bingham@ideasonboard.com> + */ + +-/* To provide basename and asprintf from the GNU library. */ ++/* To provide asprintf from the GNU library. */ + #define _GNU_SOURCE + + #include <dirent.h> +@@ -259,9 +259,10 @@ udc_find_video_device (const char *udc, const char *function) + } + + if (i < globbuf.gl_pathc) { +- const char *v = basename (globbuf.gl_pathv[i]); ++ gchar *v = g_path_get_basename (globbuf.gl_pathv[i]); + + video = path_join ("/dev", v); ++ g_free (v); + } + + globfree (&globbuf); +@@ -894,6 +895,7 @@ configfs_parse_uvc_function (const char *function) + { + struct uvc_function_config *fc; + char *fpath; ++ gchar *bname; + int ret = 0; + + fc = malloc (sizeof *fc); +@@ -923,11 +925,10 @@ configfs_parse_uvc_function (const char *function) + * Parse the function configuration. Remove the gadget name qualifier + * from the function name, if any. + */ +- if (function) +- function = basename (function); ++ bname = g_path_get_basename (function); + + fc->udc = attribute_read_str (fpath, "../../UDC"); +- fc->video = udc_find_video_device (fc->udc, function); ++ fc->video = udc_find_video_device (fc->udc, bname); + if (!fc->video) { + ret = -ENODEV; + goto done; +@@ -942,6 +943,7 @@ done: + } + + free (fpath); ++ g_free (bname); + + return fc; + } +@@ -979,12 +981,16 @@ configfs_parse_uvc_videodev (int fd, const char *video) + char *function = NULL; + char rpath[PATH_MAX]; + char *res; ++ gchar *bname; + + res = realpath (video, rpath); + if (!res) + return NULL; + +- function = video_find_config_name (basename (rpath)); ++ bname = g_path_get_basename (rpath); ++ function = video_find_config_name (bname); ++ g_free (bname); ++ + if (!function) + return NULL; + diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb index dbd504e87dc..ccb1a544562 100644 --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.24.3.bb @@ -9,6 +9,7 @@ SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad file://0001-fix-maybe-uninitialized-warnings-when-compiling-with.patch \ file://0002-avoid-including-sys-poll.h-directly.patch \ file://0004-opencv-resolve-missing-opencv-data-dir-in-yocto-buil.patch \ + file://0001-uvcgadget-Use-g_path_get_basename-instead-of-libc-ba.patch \ " SRC_URI[sha256sum] = "e90f26c7dc9c76f4aa599b758cfd6d8c10d6a0b9cb265ba2c3c9bdf3888558f8"
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- ...path_get_basename-instead-of-libc-ba.patch | 98 +++++++++++++++++++ .../gstreamer1.0-plugins-bad_1.24.3.bb | 1 + 2 files changed, 99 insertions(+) create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-uvcgadget-Use-g_path_get_basename-instead-of-libc-ba.patch