| Message ID | 20240604081023.38549-3-martin.jansa@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RESENDv3,1/4] selftest: gitrepotest: add Upstream-Status to 0001-testpatch.patch | expand |
On Tue, 2024-06-04 at 10:10 +0200, Martin Jansa via lists.openembedded.org wrote: > * now patchreview complains only about missing SOBs > > $ scripts/contrib/patchreview.py -v meta-selftest/ > Found layers meta-selftest > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-patch- > overrides/qemuarm/arm.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-patch- > overrides/qemux86/x86.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-test-ignored/devtool-test- > ignored.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-test-long-filename/0001-I-ll- > patch-you-only-if-devtool-lets-me-to-do-it-corr.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-upgrade-test1-1.5.3/0001-Add-a- > note-line-to-the-quick-reference.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/devtool/devtool-upgrade-test1- > 1.5.3/backported.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/man-db/files/0001-Test-patch-here.patch) > Missing Signed-off-by tag (/OE/layers/openembedded-core/meta- > selftest/recipes-test/recipetool/files/add-file.patch) > > Total patches found: 13 > Patches missing Signed-off-by: 9 (69%) > Patches with malformed Signed-off-by: 0 (0%) > Patches missing CVE: 0 (0%) > Patches missing Upstream-Status: 0 (0%) > Patches with malformed Upstream-Status: 0 (0%) > Patches in Pending state: 4 (31%) > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > --- > .../devtool/devtool-patch-overrides/qemuarm/arm.patch | 2 > ++ > .../devtool/devtool-patch-overrides/qemux86/x86.patch | 2 > ++ > .../recipes-test/man-db/files/0001-Test-patch-here.patch | 2 > ++ > 3 files changed, 6 insertions(+) > > diff --git a/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemuarm/arm.patch b/meta-selftest/recipes- > test/devtool/devtool-patch-overrides/qemuarm/arm.patch > index e33a2753f9..f7f729a86c 100644 > --- a/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemuarm/arm.patch > +++ b/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemuarm/arm.patch > @@ -1,3 +1,5 @@ > +Upstream-Status: Pending > + > --- source.orig 2020-10-06 13:26:10.792688630 +0100 > +++ source 2020-10-06 13:26:18.853424694 +0100 > @@ -1 +1 @@ > diff --git a/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemux86/x86.patch b/meta-selftest/recipes- > test/devtool/devtool-patch-overrides/qemux86/x86.patch > index 1a0a175fa8..0aa1affedd 100644 > --- a/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemux86/x86.patch > +++ b/meta-selftest/recipes-test/devtool/devtool-patch- > overrides/qemux86/x86.patch > @@ -1,3 +1,5 @@ > +Upstream-Status: Pending > + > --- source.orig 2020-10-06 13:26:10.792688630 +0100 > +++ source 2020-10-06 13:26:18.853424694 +0100 > @@ -1 +1 @@ > diff --git a/meta-selftest/recipes-test/man-db/files/0001-Test-patch- > here.patch b/meta-selftest/recipes-test/man-db/files/0001-Test-patch- > here.patch > index b1d5eab2b8..d4d43904df 100644 > --- a/meta-selftest/recipes-test/man-db/files/0001-Test-patch- > here.patch > +++ b/meta-selftest/recipes-test/man-db/files/0001-Test-patch- > here.patch > @@ -4,6 +4,8 @@ Date: Fri, 9 Feb 2018 17:37:48 +0200 > Subject: [PATCH] Test patch here! > > This is an invalid patch used by oe-selftest > + > +Upstream-Status: Pending > --- > README | 1 + > 1 file changed, 1 insertion(+) > "Pending" implies we're going to do something with these which we're not. "Inappropriate" might be a better choice? I mention this mainly as we have an aim of triaging all the Pending patches over time and can hopefully reduce the numbers. Having some kind of "TestArtefact" category might be helpful in that regard... Cheers, Richard
diff --git a/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemuarm/arm.patch b/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemuarm/arm.patch index e33a2753f9..f7f729a86c 100644 --- a/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemuarm/arm.patch +++ b/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemuarm/arm.patch @@ -1,3 +1,5 @@ +Upstream-Status: Pending + --- source.orig 2020-10-06 13:26:10.792688630 +0100 +++ source 2020-10-06 13:26:18.853424694 +0100 @@ -1 +1 @@ diff --git a/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemux86/x86.patch b/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemux86/x86.patch index 1a0a175fa8..0aa1affedd 100644 --- a/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemux86/x86.patch +++ b/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemux86/x86.patch @@ -1,3 +1,5 @@ +Upstream-Status: Pending + --- source.orig 2020-10-06 13:26:10.792688630 +0100 +++ source 2020-10-06 13:26:18.853424694 +0100 @@ -1 +1 @@ diff --git a/meta-selftest/recipes-test/man-db/files/0001-Test-patch-here.patch b/meta-selftest/recipes-test/man-db/files/0001-Test-patch-here.patch index b1d5eab2b8..d4d43904df 100644 --- a/meta-selftest/recipes-test/man-db/files/0001-Test-patch-here.patch +++ b/meta-selftest/recipes-test/man-db/files/0001-Test-patch-here.patch @@ -4,6 +4,8 @@ Date: Fri, 9 Feb 2018 17:37:48 +0200 Subject: [PATCH] Test patch here! This is an invalid patch used by oe-selftest + +Upstream-Status: Pending --- README | 1 + 1 file changed, 1 insertion(+)
* now patchreview complains only about missing SOBs $ scripts/contrib/patchreview.py -v meta-selftest/ Found layers meta-selftest Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemuarm/arm.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-patch-overrides/qemux86/x86.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-test-ignored/devtool-test-ignored.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-test-long-filename/0001-I-ll-patch-you-only-if-devtool-lets-me-to-do-it-corr.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-upgrade-test1-1.5.3/0001-Add-a-note-line-to-the-quick-reference.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/devtool/devtool-upgrade-test1-1.5.3/backported.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/man-db/files/0001-Test-patch-here.patch) Missing Signed-off-by tag (/OE/layers/openembedded-core/meta-selftest/recipes-test/recipetool/files/add-file.patch) Total patches found: 13 Patches missing Signed-off-by: 9 (69%) Patches with malformed Signed-off-by: 0 (0%) Patches missing CVE: 0 (0%) Patches missing Upstream-Status: 0 (0%) Patches with malformed Upstream-Status: 0 (0%) Patches in Pending state: 4 (31%) Signed-off-by: Martin Jansa <martin.jansa@gmail.com> --- .../devtool/devtool-patch-overrides/qemuarm/arm.patch | 2 ++ .../devtool/devtool-patch-overrides/qemux86/x86.patch | 2 ++ .../recipes-test/man-db/files/0001-Test-patch-here.patch | 2 ++ 3 files changed, 6 insertions(+)