[RESENDv2,2/2] insane: add patch-status to default ERROR_QA

* it's enabled for patches in oe-core for very long time and I was using
  it for many other layers as well, so most layers should be in good
  shape

* it's also possible to disable it for individual layer as shown
  by oe-core in:
  https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
---
 meta/classes-global/insane.bbclass | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

On Sat, 2024-06-01 at 01:01 +0200, Martin Jansa via
lists.openembedded.org wrote:
> * it's enabled for patches in oe-core for very long time and I was
> using
>   it for many other layers as well, so most layers should be in good
>   shape
> 
> * it's also possible to disable it for individual layer as shown
>   by oe-core in:
>  
> https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3
> 
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> ---
>  meta/classes-global/insane.bbclass | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

I'm pretty sure this is causing at least some of the failures in oe-
selftest:

https://valkyrie.yoctoproject.org/#/builders/35/builds/36/steps/14/logs/stdio

Cheers,

Richard

Thanks and sorry for not catching it earlier.

The errors refer to these 5 files:
/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-795212/meta-selftest/recipes-test/recipetool/files/add-file.patch
/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-795262/meta-selftest/recipes-test/devtool/devtool-test-ignored/devtool-test-ignored.patch
/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-795262/meta-selftest/recipes-test/devtool/devtool-test-long-filename/0001-I-ll-patch-you-only-if-devtool-lets-me-to-do-it-corr.patch
/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-795274/meta-selftest/recipes-test/devtool/devtool-upgrade-test1-1.5.3/0001-Add-a-note-line-to-the-quick-reference.patch
/home/pokybuild/yocto-worker/oe-selftest-debian/build/build-st-795274/meta-selftest/recipes-test/devtool/devtool-upgrade-test1-1.5.3/backported.patch

will check where they are used and send v3 with fixes.

Regards,

On Mon, Jun 3, 2024 at 11:26 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Sat, 2024-06-01 at 01:01 +0200, Martin Jansa via
> lists.openembedded.org wrote:
> > * it's enabled for patches in oe-core for very long time and I was
> > using
> >   it for many other layers as well, so most layers should be in good
> >   shape
> >
> > * it's also possible to disable it for individual layer as shown
> >   by oe-core in:
> >
> > https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3
> >
> > Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> > ---
> >  meta/classes-global/insane.bbclass | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
>
> I'm pretty sure this is causing at least some of the failures in oe-
> selftest:
>
> https://valkyrie.yoctoproject.org/#/builders/35/builds/36/steps/14/logs/stdio
>
> Cheers,
>
> Richard

On Fri, May 31, 2024 at 4:01 PM Martin Jansa via
lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
wrote:
>
> * it's enabled for patches in oe-core for very long time and I was using
>   it for many other layers as well, so most layers should be in good
>   shape

Do other layers have the patches taken care of is what you mean here ?
otherwise I would suggest sending those fixes ahead of merging this.

>
> * it's also possible to disable it for individual layer as shown
>   by oe-core in:
>   https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3
>
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
> ---
>  meta/classes-global/insane.bbclass | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
> index 99736830b9..6d2f83c6f7 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
>              already-stripped installed-vs-shipped ldflags compile-host-path \
>              install-host-path pn-overrides unknown-configure-option \
>              useless-rpaths rpaths staticdev empty-dirs \
> -            patch-fuzz \
> +            patch-fuzz patch-status \
>              "
>  # Add usrmerge QA check based on distro feature
>  ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}"
> -ERROR_QA:append:layer-core = " patch-status"
>  WARN_QA:append:layer-core = " missing-metadata missing-maintainer"
>
>  FAKEROOT_QA = "host-user-contaminated"
> --
> 2.45.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#200091): https://lists.openembedded.org/g/openembedded-core/message/200091
> Mute This Topic: https://lists.openembedded.org/mt/106418259/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

On Tue, Jun 4, 2024 at 8:46 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Fri, May 31, 2024 at 4:01 PM Martin Jansa via
> lists.openembedded.org <martin.jansa=gmail.com@lists.openembedded.org>
> wrote:
> >
> > * it's enabled for patches in oe-core for very long time and I was using
> >   it for many other layers as well, so most layers should be in good
> >   shape
>
> Do other layers have the patches taken care of is what you mean here ?
> otherwise I would suggest sending those fixes ahead of merging this.

The layers I sometimes use were already fixed, the list of fixes was
included in:
https://lists.openembedded.org/g/openembedded-core/message/197115