| Message ID | 20240524160025.275450-1-martin.jansa@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND] insane: add patch-status to default ERROR_QA | expand |
ERROR: gitrepotest-1.0-r0 do_patch: QA Issue: Missing Upstream-Status in patch /home/pokybuild/yocto-worker/reproducible/build/build-st/meta-selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch Please add according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status . [patch-status] ERROR: gitrepotest-1.0-r0 do_patch: Fatal QA errors were found, failing task. On 24/05/2024 18:00:25+0200, Martin Jansa wrote: > * it's enabled for patches in oe-core for very long time and I was using > it for many other layers as well, so most layers should be in good > shape > > * it's also possible to disable it for individual layer as shown > by oe-core in: > https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > --- > Resend https://patchwork.yoctoproject.org/project/oe-core/patch/20240314070903.83765-1-martin.jansa@gmail.com/ > now when scarthgap is released and master is open for development > > meta/classes-global/insane.bbclass | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > index 99736830b9..6d2f83c6f7 100644 > --- a/meta/classes-global/insane.bbclass > +++ b/meta/classes-global/insane.bbclass > @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > already-stripped installed-vs-shipped ldflags compile-host-path \ > install-host-path pn-overrides unknown-configure-option \ > useless-rpaths rpaths staticdev empty-dirs \ > - patch-fuzz \ > + patch-fuzz patch-status \ > " > # Add usrmerge QA check based on distro feature > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > -ERROR_QA:append:layer-core = " patch-status" > WARN_QA:append:layer-core = " missing-metadata missing-maintainer" > > FAKEROOT_QA = "host-user-contaminated" > -- > 2.45.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#199853): https://lists.openembedded.org/g/openembedded-core/message/199853 > Mute This Topic: https://lists.openembedded.org/mt/106284256/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, May 31, 2024 at 11:29 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > > ERROR: gitrepotest-1.0-r0 do_patch: QA Issue: Missing Upstream-Status in patch > /home/pokybuild/yocto-worker/reproducible/build/build-st/meta-selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch > Please add according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status . [patch-status] > ERROR: gitrepotest-1.0-r0 do_patch: Fatal QA errors were found, failing task. https://lists.openembedded.org/g/openembedded-core/message/200086 should fix that. Thanks, > > On 24/05/2024 18:00:25+0200, Martin Jansa wrote: > > * it's enabled for patches in oe-core for very long time and I was using > > it for many other layers as well, so most layers should be in good > > shape > > > > * it's also possible to disable it for individual layer as shown > > by oe-core in: > > https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 > > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > > --- > > Resend https://patchwork.yoctoproject.org/project/oe-core/patch/20240314070903.83765-1-martin.jansa@gmail.com/ > > now when scarthgap is released and master is open for development > > > > meta/classes-global/insane.bbclass | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > index 99736830b9..6d2f83c6f7 100644 > > --- a/meta/classes-global/insane.bbclass > > +++ b/meta/classes-global/insane.bbclass > > @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > install-host-path pn-overrides unknown-configure-option \ > > useless-rpaths rpaths staticdev empty-dirs \ > > - patch-fuzz \ > > + patch-fuzz patch-status \ > > " > > # Add usrmerge QA check based on distro feature > > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > > -ERROR_QA:append:layer-core = " patch-status" > > WARN_QA:append:layer-core = " missing-metadata missing-maintainer" > > > > FAKEROOT_QA = "host-user-contaminated" > > -- > > 2.45.1 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#199853): https://lists.openembedded.org/g/openembedded-core/message/199853 > > Mute This Topic: https://lists.openembedded.org/mt/106284256/3617179 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On 01/06/2024 00:37:50+0200, Martin Jansa wrote: > On Fri, May 31, 2024 at 11:29 PM Alexandre Belloni > <alexandre.belloni@bootlin.com> wrote: > > > > ERROR: gitrepotest-1.0-r0 do_patch: QA Issue: Missing Upstream-Status in patch > > /home/pokybuild/yocto-worker/reproducible/build/build-st/meta-selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch > > Please add according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status . [patch-status] > > ERROR: gitrepotest-1.0-r0 do_patch: Fatal QA errors were found, failing task. > > https://lists.openembedded.org/g/openembedded-core/message/200086 > should fix that. I can't keep track of the tens f patches I need to reapply once they have been dropped so please always resend complete series. I'm pretty sure that once my current a-full build will be finished I'll have forgotten. The other option is to resend later on. > > Thanks, > > > > > On 24/05/2024 18:00:25+0200, Martin Jansa wrote: > > > * it's enabled for patches in oe-core for very long time and I was using > > > it for many other layers as well, so most layers should be in good > > > shape > > > > > > * it's also possible to disable it for individual layer as shown > > > by oe-core in: > > > https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 > > > > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > > > --- > > > Resend https://patchwork.yoctoproject.org/project/oe-core/patch/20240314070903.83765-1-martin.jansa@gmail.com/ > > > now when scarthgap is released and master is open for development > > > > > > meta/classes-global/insane.bbclass | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > > index 99736830b9..6d2f83c6f7 100644 > > > --- a/meta/classes-global/insane.bbclass > > > +++ b/meta/classes-global/insane.bbclass > > > @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > > install-host-path pn-overrides unknown-configure-option \ > > > useless-rpaths rpaths staticdev empty-dirs \ > > > - patch-fuzz \ > > > + patch-fuzz patch-status \ > > > " > > > # Add usrmerge QA check based on distro feature > > > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > > > -ERROR_QA:append:layer-core = " patch-status" > > > WARN_QA:append:layer-core = " missing-metadata missing-maintainer" > > > > > > FAKEROOT_QA = "host-user-contaminated" > > > -- > > > 2.45.1 > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > > Links: You receive all messages sent to this group. > > > View/Reply Online (#199853): https://lists.openembedded.org/g/openembedded-core/message/199853 > > > Mute This Topic: https://lists.openembedded.org/mt/106284256/3617179 > > > Group Owner: openembedded-core+owner@lists.openembedded.org > > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > > > -=-=-=-=-=-=-=-=-=-=-=- > > > > > > > > > -- > > Alexandre Belloni, co-owner and COO, Bootlin > > Embedded Linux and Kernel engineering > > https://bootlin.com
On 01/06/2024 00:53:21+0200, Alexandre Belloni via lists.openembedded.org wrote: > On 01/06/2024 00:37:50+0200, Martin Jansa wrote: > > On Fri, May 31, 2024 at 11:29 PM Alexandre Belloni > > <alexandre.belloni@bootlin.com> wrote: > > > > > > ERROR: gitrepotest-1.0-r0 do_patch: QA Issue: Missing Upstream-Status in patch > > > /home/pokybuild/yocto-worker/reproducible/build/build-st/meta-selftest/recipes-test/gitrepotest/gitrepotest/0001-testpatch.patch > > > Please add according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status . [patch-status] > > > ERROR: gitrepotest-1.0-r0 do_patch: Fatal QA errors were found, failing task. > > > > https://lists.openembedded.org/g/openembedded-core/message/200086 > > should fix that. > > I can't keep track of the tens f patches I need to reapply once they > have been dropped so please always resend complete series. I'm pretty > sure that once my current a-full build will be finished I'll have > forgotten. > The other option is to resend later on. And you sent it properly as a series so you can disregard my rant ;) Thanks! > > > > > Thanks, > > > > > > > > On 24/05/2024 18:00:25+0200, Martin Jansa wrote: > > > > * it's enabled for patches in oe-core for very long time and I was using > > > > it for many other layers as well, so most layers should be in good > > > > shape > > > > > > > > * it's also possible to disable it for individual layer as shown > > > > by oe-core in: > > > > https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 > > > > > > > > Signed-off-by: Martin Jansa <martin.jansa@gmail.com> > > > > --- > > > > Resend https://patchwork.yoctoproject.org/project/oe-core/patch/20240314070903.83765-1-martin.jansa@gmail.com/ > > > > now when scarthgap is released and master is open for development > > > > > > > > meta/classes-global/insane.bbclass | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass > > > > index 99736830b9..6d2f83c6f7 100644 > > > > --- a/meta/classes-global/insane.bbclass > > > > +++ b/meta/classes-global/insane.bbclass > > > > @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ > > > > already-stripped installed-vs-shipped ldflags compile-host-path \ > > > > install-host-path pn-overrides unknown-configure-option \ > > > > useless-rpaths rpaths staticdev empty-dirs \ > > > > - patch-fuzz \ > > > > + patch-fuzz patch-status \ > > > > " > > > > # Add usrmerge QA check based on distro feature > > > > ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" > > > > -ERROR_QA:append:layer-core = " patch-status" > > > > WARN_QA:append:layer-core = " missing-metadata missing-maintainer" > > > > > > > > FAKEROOT_QA = "host-user-contaminated" > > > > -- > > > > 2.45.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Alexandre Belloni, co-owner and COO, Bootlin > > > Embedded Linux and Kernel engineering > > > https://bootlin.com > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#200089): https://lists.openembedded.org/g/openembedded-core/message/200089 > Mute This Topic: https://lists.openembedded.org/mt/106284256/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass index 99736830b9..6d2f83c6f7 100644 --- a/meta/classes-global/insane.bbclass +++ b/meta/classes-global/insane.bbclass @@ -45,11 +45,10 @@ ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \ already-stripped installed-vs-shipped ldflags compile-host-path \ install-host-path pn-overrides unknown-configure-option \ useless-rpaths rpaths staticdev empty-dirs \ - patch-fuzz \ + patch-fuzz patch-status \ " # Add usrmerge QA check based on distro feature ERROR_QA:append = "${@bb.utils.contains('DISTRO_FEATURES', 'usrmerge', ' usrmerge', '', d)}" -ERROR_QA:append:layer-core = " patch-status" WARN_QA:append:layer-core = " missing-metadata missing-maintainer" FAKEROOT_QA = "host-user-contaminated"
* it's enabled for patches in oe-core for very long time and I was using it for many other layers as well, so most layers should be in good shape * it's also possible to disable it for individual layer as shown by oe-core in: https://git.openembedded.org/openembedded-core/commit/meta/classes-global/insane.bbclass?h=scarthgap&id=61a881fdbe8b5a21c6276b8a5d06cc30486b1eb3 Signed-off-by: Martin Jansa <martin.jansa@gmail.com> --- Resend https://patchwork.yoctoproject.org/project/oe-core/patch/20240314070903.83765-1-martin.jansa@gmail.com/ now when scarthgap is released and master is open for development meta/classes-global/insane.bbclass | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)