diff mbox series

[2/5] insane: Add error for B = WORKDIR

Message ID 20240523075818.2307756-2-richard.purdie@linuxfoundation.org
State Accepted, archived
Commit e3c2c1fac904bb518d85e10a2ac0177c81cbf7e8
Headers show
Series [1/5] usbinit: Drop recipe | expand

Commit Message

Richard Purdie May 23, 2024, 7:58 a.m. UTC 
This was never a good idea and would have mostly happened from S = WORKDIR
however explictly disallow it and error if anyone tries.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes-global/insane.bbclass | 3 +++
 1 file changed, 3 insertions(+)
diff mbox series

Patch

diff --git a/meta/classes-global/insane.bbclass b/meta/classes-global/insane.bbclass
index eeef43d00e2..42ed1a24a74 100644
--- a/meta/classes-global/insane.bbclass
+++ b/meta/classes-global/insane.bbclass
@@ -1603,9 +1603,12 @@  python () {
         oe.qa.handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d)
 
     sourcedir = d.getVar("S")
+    builddir = d.getVar("B")
     workdir = d.getVar("WORKDIR")
     if sourcedir == workdir:
         bb.fatal("Using S = ${WORKDIR} is no longer supported")
+    if builddir == workdir:
+        bb.fatal("Using B = ${WORKDIR} is no longer supported")
 
     # Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder
     # why it doesn't work.