| Message ID | 20240522145252.58663-2-ninette@thehoodiefirm.com |
|---|---|
| State | New |
| Headers | show |
| Series | oe-build-perf-report: Update tooltip to include commit link | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/1-1-oe-build-perf-report-Add-commit-hash-link-to-chart-tooltip.patch FAIL: test max line length: Patch line too long (current length 201, maximum is 200) (test_metadata.TestMetadata.test_max_line_length) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files) SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore) SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format) SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence) SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned) SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence) SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files) SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence) SKIP: test target mailing list: Series merged, no reason to check other mailing lists (test_mbox.TestMbox.test_target_mailing_list) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
On Wed, 2024-05-22 at 16:52 +0200, Ninette Adhikari wrote: > Update tooltip to include the commit hash link to the poky repository > > Signed-off-by: Ninette Adhikari <ninette@thehoodiefirm.com> I ran a test build of this and have to say it is awesome! https://autobuilder.yocto.io/pub/non-release/20240523-22/testresults/buildperf-alma8/perf-alma8_master-next_20240523112827_c0bd181fcf.html This means we can much more easily narrow down the commit causing a problem, thanks! We've needed this for so long its wonderful to finally have it work properly. Cheers, Richard
diff --git a/scripts/lib/build_perf/html/measurement_chart.html b/scripts/lib/build_perf/html/measurement_chart.html index ad4a93ed02..05bd84e6ce 100644 --- a/scripts/lib/build_perf/html/measurement_chart.html +++ b/scripts/lib/build_perf/html/measurement_chart.html @@ -2,7 +2,7 @@ // Get raw data const rawData = [ {% for sample in measurement.samples %} - [{{ sample.commit_num }}, {{ sample.mean.gv_value() }}, {{ sample.start_time }}], + [{{ sample.commit_num }}, {{ sample.mean.gv_value() }}, {{ sample.start_time }}, '{{sample.commit}}'], {% endfor %} ]; @@ -30,23 +30,23 @@ const option = { tooltip: { trigger: 'axis', - valueFormatter: (value) => { - const commitNumber = rawData.filter(([commit, dataValue, time]) => updateValue(dataValue) === value) + enterable: true, + position: function (point, params, dom, rect, size) { + return [point[0]-150, '10%']; + }, + formatter: function (param) { + const value = param[0].value[1] + const sample = rawData.filter(([commit, dataValue]) => updateValue(dataValue) === value) + // Add commit hash to the tooltip as a link + const commitLink = `https://git.yoctoproject.org/poky/commit/?id=${sample[0][3]}` if ('{{ measurement.value_type.quantity }}' == 'time') { const hours = Math.floor(value/60) const minutes = Math.floor(value % 60) const seconds = Math.floor((value * 60) % 60) - return [ - hours + ':' + minutes + ':' + seconds + ', ' + - 'commit number: ' + commitNumber[0][0] - ] + return `<strong>Duration:</strong> ${hours}:${minutes}:${seconds}, <br/> <strong>Commit number:</strong> <a href="${commitLink}" target="_blank" rel="noreferrer noopener">${sample[0][0]}</a>` } - return [ - value.toFixed(2) + ' MB' + ', ' + - 'commit number: ' + commitNumber[0][0] - ] - }, - + return `<strong>Size:</strong> ${value.toFixed(2)} MB, <br/> <strong>Commit number:</strong> <a href="${commitLink}" target="_blank" rel="noreferrer noopener">${sample[0][0]}</a>` + ;} }, xAxis: { type: 'time', diff --git a/scripts/oe-build-perf-report b/scripts/oe-build-perf-report index 266700d294..6c3c726ee3 100755 --- a/scripts/oe-build-perf-report +++ b/scripts/oe-build-perf-report @@ -336,10 +336,12 @@ def print_html_report(data, id_comp, buildstats): test_i = test_data['tests'][test] meas_i = test_i['measurements'][meas] commit_num = get_data_item(meta, 'layers.meta.commit_count') + commit = get_data_item(meta, 'layers.meta.commit') # Add start_time for both test measurement types of sysres and disk usage start_time = test_i['start_time'][0] samples.append(measurement_stats(meas_i, '', start_time)) samples[-1]['commit_num'] = commit_num + samples[-1]['commit'] = commit absdiff = samples[-1]['val_cls'](samples[-1]['mean'] - samples[id_comp]['mean']) reldiff = absdiff * 100 / samples[id_comp]['mean']
Update tooltip to include the commit hash link to the poky repository Signed-off-by: Ninette Adhikari <ninette@thehoodiefirm.com> --- .../build_perf/html/measurement_chart.html | 26 +++++++++---------- scripts/oe-build-perf-report | 2 ++ 2 files changed, 15 insertions(+), 13 deletions(-)