Message ID | 20240426083038.8555-1-alexandre.truong@smile.fr |
---|---|
State | New |
Headers | show |
Series | [1/2] Revert "oeqa/selftest/devtool: fix test_devtool_add_git_style2" | expand |
When you revert something, you need to explain why. Alex On Fri, 26 Apr 2024 at 10:31, Alexandre Truong via lists.openembedded.org <alexandre.truong=smile.fr@lists.openembedded.org> wrote: > > This reverts commit ab6d3e3d645ffc343f434bf731339fa237df027a > from poky repository. > > Signed-off-by: Alexandre Truong <alexandre.truong@smile.fr> > Reviewed-by: Yoann Congal <yoann.congal@smile.fr> > --- > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py > index 51949e3c93..1f8781a28b 100644 > --- a/meta/lib/oeqa/selftest/cases/devtool.py > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > @@ -482,7 +482,7 @@ class DevtoolAddTests(DevtoolBase): > pn = 'mbedtls' > # this will trigger reformat_git_uri with branch parameter in url > git_url = "'git://git@github.com/ARMmbed/mbedtls.git;protocol=https'" > - resulting_src_uri = "gitsm://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" > + resulting_src_uri = "git://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" > self._test_devtool_add_git_url(git_url, version, pn, resulting_src_uri) > > def test_devtool_add_library(self): > -- > 2.34.1 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#198715): https://lists.openembedded.org/g/openembedded-core/message/198715 > Mute This Topic: https://lists.openembedded.org/mt/105746807/1686489 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Yes, you are absolutelty right. In a V2, I will add an explanation for the revert. Alexandre Truong Le ven. 26 avr. 2024 à 10:36, Alexander Kanavin <alex.kanavin@gmail.com> a écrit : > When you revert something, you need to explain why. > > Alex > > On Fri, 26 Apr 2024 at 10:31, Alexandre Truong via > lists.openembedded.org > <alexandre.truong=smile.fr@lists.openembedded.org> wrote: > > > > This reverts commit ab6d3e3d645ffc343f434bf731339fa237df027a > > from poky repository. > > > > Signed-off-by: Alexandre Truong <alexandre.truong@smile.fr> > > Reviewed-by: Yoann Congal <yoann.congal@smile.fr> > > --- > > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py > b/meta/lib/oeqa/selftest/cases/devtool.py > > index 51949e3c93..1f8781a28b 100644 > > --- a/meta/lib/oeqa/selftest/cases/devtool.py > > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > > @@ -482,7 +482,7 @@ class DevtoolAddTests(DevtoolBase): > > pn = 'mbedtls' > > # this will trigger reformat_git_uri with branch parameter in > url > > git_url = "'git:// > git@github.com/ARMmbed/mbedtls.git;protocol=https'" > > - resulting_src_uri = "gitsm:// > git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" > > + resulting_src_uri = "git:// > git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" > > self._test_devtool_add_git_url(git_url, version, pn, > resulting_src_uri) > > > > def test_devtool_add_library(self): > > -- > > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > > Links: You receive all messages sent to this group. > > View/Reply Online (#198715): > https://lists.openembedded.org/g/openembedded-core/message/198715 > > Mute This Topic: https://lists.openembedded.org/mt/105746807/1686489 > > Group Owner: openembedded-core+owner@lists.openembedded.org > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > alex.kanavin@gmail.com] > > -=-=-=-=-=-=-=-=-=-=-=- > > >
diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py index 51949e3c93..1f8781a28b 100644 --- a/meta/lib/oeqa/selftest/cases/devtool.py +++ b/meta/lib/oeqa/selftest/cases/devtool.py @@ -482,7 +482,7 @@ class DevtoolAddTests(DevtoolBase): pn = 'mbedtls' # this will trigger reformat_git_uri with branch parameter in url git_url = "'git://git@github.com/ARMmbed/mbedtls.git;protocol=https'" - resulting_src_uri = "gitsm://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" + resulting_src_uri = "git://git@github.com/ARMmbed/mbedtls.git;protocol=https;branch=master" self._test_devtool_add_git_url(git_url, version, pn, resulting_src_uri) def test_devtool_add_library(self):