| Message ID | 20240402045654.3717582-1-pkj@axis.com |
|---|---|
| State | Accepted, archived |
| Commit | c2c7e1624e8080fb8fa1f14d252f20e85b232eb7 |
| Headers | show |
| Series | util-linux: Set the license for util-linux-fcntl-lock to MIT | expand |
Hello, This caused: https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/ I guess we need to bump PR? On 02/04/2024 06:56:54+0200, Peter Kjellerstedt wrote: > This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since > util-linux-fcntl-lock is now a dependency of run-postinsts. > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > --- > meta/recipes-core/util-linux/util-linux.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc > index f4b547215e..d506783f9a 100644 > --- a/meta/recipes-core/util-linux/util-linux.inc > +++ b/meta/recipes-core/util-linux/util-linux.inc > @@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo > SECTION = "base" > > LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT" > +LICENSE:${PN}-fcntl-lock = "MIT" > LICENSE:${PN}-fdisk = "GPL-1.0-or-later" > LICENSE:${PN}-libblkid = "LGPL-2.1-or-later" > LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#197864): https://lists.openembedded.org/g/openembedded-core/message/197864 > Mute This Topic: https://lists.openembedded.org/mt/105282531/3617179 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alexandre.belloni@bootlin.com] > -=-=-=-=-=-=-=-=-=-=-=- >
> -----Original Message----- > From: Alexandre Belloni <alexandre.belloni@bootlin.com> > Sent: den 4 april 2024 01:45 > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > Cc: openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH] util-linux: Set the license for util-linux-fcntl-lock to MIT > > Hello, > > This caused: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio > https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/ Doesn't this type of breakage happen all the time for pure recipe changes that affect the output if the PR server is not enabled? > > I guess we need to bump PR? Given that RP removed all PR variables from the recipes in OE-Core (see commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect that he is not too keen to see them coming back... //Peter > > On 02/04/2024 06:56:54+0200, Peter Kjellerstedt wrote: > > This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since > > util-linux-fcntl-lock is now a dependency of run-postinsts. > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > --- > > meta/recipes-core/util-linux/util-linux.inc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc > > index f4b547215e..d506783f9a 100644 > > --- a/meta/recipes-core/util-linux/util-linux.inc > > +++ b/meta/recipes-core/util-linux/util-linux.inc > > @@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo > > SECTION = "base" > > > > LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT" > > +LICENSE:${PN}-fcntl-lock = "MIT" > > LICENSE:${PN}-fdisk = "GPL-1.0-or-later" > > LICENSE:${PN}-libblkid = "LGPL-2.1-or-later" > > LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
On 04/04/2024 17:25:52+0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: Alexandre Belloni <alexandre.belloni@bootlin.com> > > Sent: den 4 april 2024 01:45 > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > Cc: openembedded-core@lists.openembedded.org > > Subject: Re: [OE-core] [PATCH] util-linux: Set the license for util-linux-fcntl-lock to MIT > > > > Hello, > > > > This caused: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio > > https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/ > > Doesn't this type of breakage happen all the time for pure recipe > changes that affect the output if the PR server is not enabled? > > > > > I guess we need to bump PR? > > Given that RP removed all PR variables from the recipes in OE-Core (see > commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect that he > is not too keen to see them coming back... > The plan is to take your patch as-is in master and if this causes reop failures bump PR > //Peter > > > > > On 02/04/2024 06:56:54+0200, Peter Kjellerstedt wrote: > > > This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since > > > util-linux-fcntl-lock is now a dependency of run-postinsts. > > > > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > > --- > > > meta/recipes-core/util-linux/util-linux.inc | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc > > > index f4b547215e..d506783f9a 100644 > > > --- a/meta/recipes-core/util-linux/util-linux.inc > > > +++ b/meta/recipes-core/util-linux/util-linux.inc > > > @@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo > > > SECTION = "base" > > > > > > LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT" > > > +LICENSE:${PN}-fcntl-lock = "MIT" > > > LICENSE:${PN}-fdisk = "GPL-1.0-or-later" > > > LICENSE:${PN}-libblkid = "LGPL-2.1-or-later" > > > LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later" >
On Thu, 2024-04-04 at 17:25 +0000, Peter Kjellerstedt wrote: > > -----Original Message----- > > From: Alexandre Belloni <alexandre.belloni@bootlin.com> > > Sent: den 4 april 2024 01:45 > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > > Cc: openembedded-core@lists.openembedded.org > > Subject: Re: [OE-core] [PATCH] util-linux: Set the license for > > util-linux-fcntl-lock to MIT > > > > Hello, > > > > This caused: > > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio > > https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/ > > Doesn't this type of breakage happen all the time for pure recipe > changes that affect the output if the PR server is not enabled? The problem is that bitbake can't "see" that package license variable since it isn't in PACKAGES. It gets added there dynamically by the python module splitting code. If we add it to PACKAGES, the license change would then be in taskhash and when it changes things would rebuild. As things stand, the taskhash doesn't change and doesn't trigger a rebuild. > > I guess we need to bump PR? > > Given that RP removed all PR variables from the recipes in OE-Core > (see commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect > that he is not too keen to see them coming back... We do sometimes need them, I just got rid of a load of old obsolete stuff. You're right I'd prefer to avoid them though. Cheers, Richard
diff --git a/meta/recipes-core/util-linux/util-linux.inc b/meta/recipes-core/util-linux/util-linux.inc index f4b547215e..d506783f9a 100644 --- a/meta/recipes-core/util-linux/util-linux.inc +++ b/meta/recipes-core/util-linux/util-linux.inc @@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo SECTION = "base" LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT" +LICENSE:${PN}-fcntl-lock = "MIT" LICENSE:${PN}-fdisk = "GPL-1.0-or-later" LICENSE:${PN}-libblkid = "LGPL-2.1-or-later" LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since util-linux-fcntl-lock is now a dependency of run-postinsts. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> --- meta/recipes-core/util-linux/util-linux.inc | 1 + 1 file changed, 1 insertion(+)