| Message ID | 20240325102055.1037135-2-max.oss.09@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] perf: fix build with latest kernel | expand |
On Mon, 2024-03-25 at 11:20 +0100, Max Krummenacher wrote: > From: Max Krummenacher <max.krummenacher@toradex.com> > > Kernel commit 61d348f1e96f ("perf testsuite: Add common output checking > helpers") added with 6.9-rc1 added addional testscripts written in perl. > > Fixes: > > ERROR: perf-1.0-r0 do_package_qa: QA Issue: /usr/libexec/perf-core/tests/shell/common/check_no_patterns_found.pl contained in package perf-tests requires /usr/bin/perl, but no providers found in RDEPENDS:perf-tests? [file-rdeps] > > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> > --- > meta/recipes-kernel/perf/perf.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb > index 6408c65462..4b6834e614 100644 > --- a/meta/recipes-kernel/perf/perf.bb > +++ b/meta/recipes-kernel/perf/perf.bb > @@ -383,7 +383,7 @@ RDEPENDS:${PN} += "elfutils bash" > RDEPENDS:${PN}-archive =+ "bash" > RDEPENDS:${PN}-python =+ "bash python3 python3-modules ${@bb.utils.contains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" > RDEPENDS:${PN}-perl =+ "bash perl perl-modules" > -RDEPENDS:${PN}-tests =+ "python3 bash" > +RDEPENDS:${PN}-tests =+ "perl python3 bash" > > RSUGGESTS:${PN} += "${PN}-archive ${PN}-tests \ > ${@bb.utils.contains('PACKAGECONFIG', 'perl', '${PN}-perl', '', d)} \ Does perf avoid perl dependencies currently? Would it make more sense to put that script in ${PN}-perl? Cheers, Richard
On Tue, Mar 26, 2024 at 6:10 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Mon, 2024-03-25 at 11:20 +0100, Max Krummenacher wrote: > > From: Max Krummenacher <max.krummenacher@toradex.com> > > > > Kernel commit 61d348f1e96f ("perf testsuite: Add common output checking > > helpers") added with 6.9-rc1 added addional testscripts written in perl. > > > > Fixes: > > > ERROR: perf-1.0-r0 do_package_qa: QA Issue: /usr/libexec/perf-core/tests/shell/common/check_no_patterns_found.pl contained in package perf-tests requires /usr/bin/perl, but no providers found in RDEPENDS:perf-tests? [file-rdeps] > > > > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> > > --- > > meta/recipes-kernel/perf/perf.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb > > index 6408c65462..4b6834e614 100644 > > --- a/meta/recipes-kernel/perf/perf.bb > > +++ b/meta/recipes-kernel/perf/perf.bb > > @@ -383,7 +383,7 @@ RDEPENDS:${PN} += "elfutils bash" > > RDEPENDS:${PN}-archive =+ "bash" > > RDEPENDS:${PN}-python =+ "bash python3 python3-modules ${@bb.utils.contains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" > > RDEPENDS:${PN}-perl =+ "bash perl perl-modules" > > -RDEPENDS:${PN}-tests =+ "python3 bash" > > +RDEPENDS:${PN}-tests =+ "perl python3 bash" > > > > RSUGGESTS:${PN} += "${PN}-archive ${PN}-tests \ > > ${@bb.utils.contains('PACKAGECONFIG', 'perl', '${PN}-perl', '', d)} \ > > Does perf avoid perl dependencies currently? Would it make more sense > to put that script in ${PN}-perl? There's a packageconfig which enables the ${PN}-perl content. Whatever that stuff is used for. However kernel 6.9-rc1 added new *.pl files which are called from a shell script deployed into ${PN}-tests. So I think those new perl scripts need to go into ${PN}-tests. Regards Max > > Cheers, > > Richard > >
diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb index 6408c65462..4b6834e614 100644 --- a/meta/recipes-kernel/perf/perf.bb +++ b/meta/recipes-kernel/perf/perf.bb @@ -383,7 +383,7 @@ RDEPENDS:${PN} += "elfutils bash" RDEPENDS:${PN}-archive =+ "bash" RDEPENDS:${PN}-python =+ "bash python3 python3-modules ${@bb.utils.contains('PACKAGECONFIG', 'audit', 'audit-python', '', d)}" RDEPENDS:${PN}-perl =+ "bash perl perl-modules" -RDEPENDS:${PN}-tests =+ "python3 bash" +RDEPENDS:${PN}-tests =+ "perl python3 bash" RSUGGESTS:${PN} += "${PN}-archive ${PN}-tests \ ${@bb.utils.contains('PACKAGECONFIG', 'perl', '${PN}-perl', '', d)} \