Message ID | 20240223201745.16234-1-simone.p.weiss@posteo.com |
---|---|
State | Accepted, archived |
Commit | 51267f3c5d647fc6483ce6b597ed9e25c14bd425 |
Headers | show |
Series | [v2] patchtest: provide further guidance for failed testcases | expand |
On 2024-02-23 15:17, Simone Weiß wrote: > From: Simone Weiß <simone.p.weiss@posteo.com> > > Cross-reference the wiki page on patchtest now that it is updated and contains > more information how to address failed testcases. Adding it in patchtest only > is enough as patchtest-send-result already points to the wikipage for failures. > > Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com> > --- > v2: Instead of prodvidng the infos in the log point to the now updated wiki to > avoid issues with autobuilder when adding more lines. > scripts/patchtest | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/scripts/patchtest b/scripts/patchtest > index 3163420220..42e70fd4b7 100755 > --- a/scripts/patchtest > +++ b/scripts/patchtest > @@ -164,9 +164,9 @@ def run(patch, logfile=None): > if premerge_result == 2 and postmerge_result == 2: > logger.error('patchtest: No test cases found - did you specify the correct suite directory?') > if premerge_result == 1 or postmerge_result == 1: > - logger.error('WARNING: patchtest: At least one patchtest caused a failure or an error - please check') > + logger.error('WARNING: patchtest: At least one patchtest caused a failure or an error - please check https://wiki.yoctoproject.org/wiki/Patchtest for further guidance for further guidance') Hi, The idea here is good, but it looks like there's a typo here... > else: > - logger.error('OK: patchtest: All patchtests passed') > + logger.info('OK: patchtest: All patchtests passed') > print('----------------------------------------------------------------------\n') > return premerge_result or postmerge_result > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#196107): https://lists.openembedded.org/g/openembedded-core/message/196107 > Mute This Topic: https://lists.openembedded.org/mt/104535997/7611679 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [tgamblin@baylibre.com] > -=-=-=-=-=-=-=-=-=-=-=- >
diff --git a/scripts/patchtest b/scripts/patchtest index 3163420220..42e70fd4b7 100755 --- a/scripts/patchtest +++ b/scripts/patchtest @@ -164,9 +164,9 @@ def run(patch, logfile=None): if premerge_result == 2 and postmerge_result == 2: logger.error('patchtest: No test cases found - did you specify the correct suite directory?') if premerge_result == 1 or postmerge_result == 1: - logger.error('WARNING: patchtest: At least one patchtest caused a failure or an error - please check') + logger.error('WARNING: patchtest: At least one patchtest caused a failure or an error - please check https://wiki.yoctoproject.org/wiki/Patchtest for further guidance for further guidance') else: - logger.error('OK: patchtest: All patchtests passed') + logger.info('OK: patchtest: All patchtests passed') print('----------------------------------------------------------------------\n') return premerge_result or postmerge_result