diff mbox series

baremetal-helloworld: Update SRCREV to fix entry addresses for ARM architectures

Message ID 20230609221242.2961719-1-alejandro@enedino.org
State New
Headers show
Series baremetal-helloworld: Update SRCREV to fix entry addresses for ARM architectures | expand

Commit Message

Alejandro Enedino Hernandez Samaniego June 9, 2023, 10:12 p.m. UTC
Update to the latest SRCREV to bring fixes using the proper entry
addresses for ARM architectures [1], as well as fixing a race condition
in the Makefile during assembly [2].

Fix url in case automatic redirects stop working.

[1] https://github.com/ahcbb6/baremetal-helloqemu/commit/602e82aee7ae95ee50eedb7f40c4a225ec5a3fb9
[2] https://github.com/ahcbb6/baremetal-helloqemu/commit/ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
---
 .../baremetal-example/baremetal-helloworld_git.bb             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Richard Purdie June 16, 2023, 8:36 a.m. UTC | #1
On Fri, 2023-06-09 at 16:12 -0600, Alejandro Hernandez Samaniego wrote:
> Update to the latest SRCREV to bring fixes using the proper entry
> addresses for ARM architectures [1], as well as fixing a race condition
> in the Makefile during assembly [2].
> 
> Fix url in case automatic redirects stop working.
> 
> [1] https://github.com/ahcbb6/baremetal-helloqemu/commit/602e82aee7ae95ee50eedb7f40c4a225ec5a3fb9
> [2] https://github.com/ahcbb6/baremetal-helloqemu/commit/ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec
> 
> Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandro@enedino.org>
> ---
>  .../baremetal-example/baremetal-helloworld_git.bb             | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb b/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
> index 82b2901d51..4182372057 100644
> --- a/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
> +++ b/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
> @@ -4,10 +4,10 @@ DESCRIPTION = "These are introductory examples to showcase the use of QEMU to ru
>  LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=39346640a23c701e4f459e05f56f4449"
>  
> -SRCREV = "22016ecbb9fb6c5f3a7a06698aea7ff8a701c166"
> +SRCREV = "ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec"
>  PV = "0.1+git${SRCPV}"
>  
> -SRC_URI = "git://github.com/aehs29/baremetal-helloqemu.git;protocol=https;branch=master"
> +SRC_URI = "git://github.com/ahcbb6/baremetal-helloqemu.git;protocol=https;branch=master"
>  UPSTREAM_VERSION_UNKNOWN="1"
>  
>  S = "${WORKDIR}/git"

I think there is a build race in here:

https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/1609/steps/14/logs/stdio

Fatal error: can't create build/hello_baremetal_aarch64.o: No such file
or directory

so perhaps racing on the creation of build/ ?

Cheers,

Richard
Alejandro Enedino Hernandez Samaniego June 21, 2023, 4:51 a.m. UTC | #2
On Fri, 16 Jun 2023 at 02:36, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> On Fri, 2023-06-09 at 16:12 -0600, Alejandro Hernandez Samaniego wrote:
> > Update to the latest SRCREV to bring fixes using the proper entry
> > addresses for ARM architectures [1], as well as fixing a race condition
> > in the Makefile during assembly [2].
> >
> > Fix url in case automatic redirects stop working.
> >
> > [1]
> https://github.com/ahcbb6/baremetal-helloqemu/commit/602e82aee7ae95ee50eedb7f40c4a225ec5a3fb9
> > [2]
> https://github.com/ahcbb6/baremetal-helloqemu/commit/ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec
> >
> > Signed-off-by: Alejandro Enedino Hernandez Samaniego <
> alejandro@enedino.org>
> > ---
> >  .../baremetal-example/baremetal-helloworld_git.bb             | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-extended/baremetal-example/
> baremetal-helloworld_git.bb b/meta/recipes-extended/baremetal-example/
> baremetal-helloworld_git.bb
> > index 82b2901d51..4182372057 100644
> > --- a/meta/recipes-extended/baremetal-example/
> baremetal-helloworld_git.bb
> > +++ b/meta/recipes-extended/baremetal-example/
> baremetal-helloworld_git.bb
> > @@ -4,10 +4,10 @@ DESCRIPTION = "These are introductory examples to
> showcase the use of QEMU to ru
> >  LICENSE = "MIT"
> >  LIC_FILES_CHKSUM = "file://LICENSE;md5=39346640a23c701e4f459e05f56f4449"
> >
> > -SRCREV = "22016ecbb9fb6c5f3a7a06698aea7ff8a701c166"
> > +SRCREV = "ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec"
> >  PV = "0.1+git${SRCPV}"
> >
> > -SRC_URI = "git://
> github.com/aehs29/baremetal-helloqemu.git;protocol=https;branch=master"
> > +SRC_URI = "git://
> github.com/ahcbb6/baremetal-helloqemu.git;protocol=https;branch=master"
> >  UPSTREAM_VERSION_UNKNOWN="1"
> >
> >  S = "${WORKDIR}/git"
>
> I think there is a build race in here:
>
>
> https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/1609/steps/14/logs/stdio
>
> Fatal error: can't create build/hello_baremetal_aarch64.o: No such file
> or directory
>
> so perhaps racing on the creation of build/ ?
>
> Cheers,
>
> Richard
>
>
Apologies for the late reply, yes, one of the last update was an attempt to
fix such race condition, I will investigate further and send another update.

Alejandro
diff mbox series

Patch

diff --git a/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb b/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
index 82b2901d51..4182372057 100644
--- a/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
+++ b/meta/recipes-extended/baremetal-example/baremetal-helloworld_git.bb
@@ -4,10 +4,10 @@  DESCRIPTION = "These are introductory examples to showcase the use of QEMU to ru
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=39346640a23c701e4f459e05f56f4449"
 
-SRCREV = "22016ecbb9fb6c5f3a7a06698aea7ff8a701c166"
+SRCREV = "ea7f59b02467ed1fb36c3b4c6d5cabe702df26ec"
 PV = "0.1+git${SRCPV}"
 
-SRC_URI = "git://github.com/aehs29/baremetal-helloqemu.git;protocol=https;branch=master"
+SRC_URI = "git://github.com/ahcbb6/baremetal-helloqemu.git;protocol=https;branch=master"
 UPSTREAM_VERSION_UNKNOWN="1"
 
 S = "${WORKDIR}/git"