[11/11] classes/create-spdx-2.2: Make license errors fatal

Message ID	20230602133453.229023-11-richard.purdie@linuxfoundation.org
State	Accepted, archived
Commit	9d00f3ba4555510cf9525f4f6f186bf8a1371cee
Headers	show Return-Path: <richard.purdie@linuxfoundation.org> ip: 209.85.128.48, mailfrom: richard.purdie@linuxfoundation.org) From: Richard Purdie <richard.purdie@linuxfoundation.org> To: openembedded-core@lists.openembedded.org Cc: Joshua Watt <JPEWhacker@gmail.com> Subject: [PATCH 11/11] classes/create-spdx-2.2: Make license errors fatal Date: Fri, 2 Jun 2023 14:34:53 +0100 Message-Id: <20230602133453.229023-11-richard.purdie@linuxfoundation.org> In-Reply-To: <20230602133453.229023-1-richard.purdie@linuxfoundation.org> References: <20230602133453.229023-1-richard.purdie@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	[01/11] classes/create-spdx-2.2: Use hashfn from BB_TASKDEPDATA instead of MACHINE \| expand [01/11] classes/create-spdx-2.2: Use hashfn from BB_TASKDEPDATA instead of MACHINE [02/11] classes/create-spdx-2.2: Respect PKG for providers [03/11] classes/create-spdx-2.2: Fix build time dependency calculations [04/11] classes/create-spdx-2.2: Fix runtime dependency calculations [05/11] create-spdx-2-2: Fix packagedata usage to work with SDK packages [06/11] create-spdx-2.2: Add missing variable exclusions [07/11] layer.conf: Add missing dependency exclusion [08/11] sstatesig: Drop SPDX special casing [09/11] selftest/incompatible_lic: Ensure create_sdpx isn't used with the tests [10/11] oeqa/selftest/sstatetests: Add easier debug option [11/11] classes/create-spdx-2.2: Make license errors fatal

Message ID

20230602133453.229023-11-richard.purdie@linuxfoundation.org

State

Accepted, archived

Commit

9d00f3ba4555510cf9525f4f6f186bf8a1371cee

Headers

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core@lists.openembedded.org
Cc: Joshua Watt <JPEWhacker@gmail.com>
Subject: [PATCH 11/11] classes/create-spdx-2.2: Make license errors fatal
Date: Fri,  2 Jun 2023 14:34:53 +0100
Message-Id: <20230602133453.229023-11-richard.purdie@linuxfoundation.org>
In-Reply-To: <20230602133453.229023-1-richard.purdie@linuxfoundation.org>
References: <20230602133453.229023-1-richard.purdie@linuxfoundation.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

[01/11] classes/create-spdx-2.2: Use hashfn from BB_TASKDEPDATA instead of MACHINE | expand

Commit Message

Richard Purdie June 2, 2023, 1:34 p.m. UTC

From: Joshua Watt <JPEWhacker@gmail.com>

Otherwise the task is still put into sstate, which means the error can
effectively be hidden by ignoring it.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/classes/create-spdx-2.2.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/create-spdx-2.2.bbclass b/meta/classes/create-spdx-2.2.bbclass
index 7569f8792b2..844b674f6f1 100644
--- a/meta/classes/create-spdx-2.2.bbclass
+++ b/meta/classes/create-spdx-2.2.bbclass
@@ -138,7 +138,7 @@  def convert_license_to_spdx(lic, document, d, existing={}):
                     with open(filename, errors="replace") as f:
                         extracted_info.extractedText = f.read()
                 else:
-                    bb.error("Cannot find any text for license %s" % name)
+                    bb.fatal("Cannot find any text for license %s" % name)
 
         extracted[name] = extracted_info
         document.hasExtractedLicensingInfos.append(extracted_info)

[11/11] classes/create-spdx-2.2: Make license errors fatal

Commit Message

Patch