diff mbox series

[1/2] cmake.bbclass: do not search host paths for find_program()

Message ID 20230601144739.1525861-1-Qi.Chen@windriver.com
State Accepted, archived
Commit f4ea12f6635125ee793f4dd801c538c0186f9dc3
Headers show
Series [1/2] cmake.bbclass: do not search host paths for find_program() | expand

Commit Message

Chen, Qi June 1, 2023, 2:47 p.m. UTC 
From: Chen Qi <Qi.Chen@windriver.com>

OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM[1] controls the search
behavior of find_program(). When this variable's value was
first used in OE, it was deliberately set to BOTH to allow
searching of host tools. This is to ensure the necessary tools
from host could be used. The downside is that the configure
behavior may differ on different host environments.

Later, this cmake.bbclass was added the ability to search tools
under the HOSTTOOLS_DIR. This means we no longer needs cmake to
search the host paths. So we remove the class-native setting of
BOTH.

[1] https://cmake.org/cmake/help/latest/variable/CMAKE_FIND_ROOT_PATH_MODE_PROGRAM.html

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/classes-recipe/cmake.bbclass | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/meta/classes-recipe/cmake.bbclass b/meta/classes-recipe/cmake.bbclass
index 301367b515..0dda104a69 100644
--- a/meta/classes-recipe/cmake.bbclass
+++ b/meta/classes-recipe/cmake.bbclass
@@ -61,7 +61,6 @@  OECMAKE_PERLNATIVE_DIR ??= ""
 OECMAKE_EXTRA_ROOT_PATH ?= ""
 
 OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM = "ONLY"
-OECMAKE_FIND_ROOT_PATH_MODE_PROGRAM:class-native = "BOTH"
 
 EXTRA_OECMAKE:append = " ${PACKAGECONFIG_CONFARGS}"